Expense - Optimistic expense report preview not showing after creating an expense while being offline

[vincdargento]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.1.46-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Mac 15.3 / Chrome
App Component: Money Requests

Action Performed:

1. Go to staging.new.expensify.com
2. Create a new workspace.
3. Go to workspace chat.
4. Click + > Create expense > Manual.
5. Go offline
6. Submit a manual expense.

Expected Result:

Expense preview will appear immediately after creating an expense (even if offline).

Actual Result:

Optimistic preview doesn't show up. The preview only appears after coming back online and after the request RequestMoney finishes

When creating invoice, the delay is more obvious.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

bug.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @aldo-expensify (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[vincdargento]

@johncschuster FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[aldo-expensify]

I'm about to leave to a dentist appointment, I'll be out for around 1.5 hours, if this needs to be solved earlier, please reassign :)

[aldo-expensify]

Looking at the video, that delay is very small, I wonder if it could be something related to how production code is compiled vs staging code (if there is any difference in that).

[aldo-expensify]

Seems like something happened to the optimistic data, if I create the expense offline, I don't see the preview. I only see it after the request finishes and thus the delay.

[aldo-expensify]

The preview is in Onyx, but is it not showing:

[aldo-expensify]

The REPORTPREVIEW onyx data looks the same in production vs staging

The new report onyx data also looks the same, so I think this has to be some change in where we decide to show or not the preview, but the preview data and the report data didn't change.

[aldo-expensify]

I think this was caused by #62002, reverting it fixes the bug for me in dev

[aldo-expensify]

cc @JakubKorytko @allgandalf

[aldo-expensify]

I'm not sure if we want to try to fix the code or revert. If we want a revert, there is one here: #62151