-
Notifications
You must be signed in to change notification settings - Fork 3.2k
[CP Staging] Revert "Filter out report previews that shouldn't be shown in ReportPreview & MoneyRequestReportView" #62151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…review & MoneyRequestReportView"
I'm not sure if we will want a revert or try to fix the code, so I made it a draft meanwhile. |
Yeah lets revert as SWM wont get to this until Monday |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Straight revert
@mountiny looks like this was merged without a test passing. Please add a note explaining why this was done and remove the |
Straight revert |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Performance Comparison Report 📊 (1/15)Significant Changes To Duration
Show details
|
Performance Comparison Report 📊 (10/15)Meaningless Changes To Duration (9/14)Show entries
Show details
|
Performance Comparison Report 📊 (11/15)Meaningless Changes To Duration (10/14)Show entries
Show details
|
Performance Comparison Report 📊 (12/15)Meaningless Changes To Duration (11/14)Show entries
Show details
|
Performance Comparison Report 📊 (13/15)Meaningless Changes To Duration (12/14)Show entries
Show details
|
Performance Comparison Report 📊 (14/15)Meaningless Changes To Duration (13/14)Show entries
Show details
|
Performance Comparison Report 📊 (15/15)Meaningless Changes To Duration (14/14)Show entries
Show details
|
Performance Comparison Report 📊 (2/15)Meaningless Changes To Duration (1/14)Show entries
Show details
|
Performance Comparison Report 📊 (3/15)Meaningless Changes To Duration (2/14)Show entries
Show details
|
Performance Comparison Report 📊 (4/15)Meaningless Changes To Duration (3/14)Show entries
Show details
|
Performance Comparison Report 📊 (5/15)Meaningless Changes To Duration (4/14)Show entries
Show details
|
Performance Comparison Report 📊 (6/15)Meaningless Changes To Duration (5/14)Show entries
Show details
|
Performance Comparison Report 📊 (7/15)Meaningless Changes To Duration (6/14)Show entries
Show details
|
Performance Comparison Report 📊 (8/15)Meaningless Changes To Duration (7/14)Show entries
Show details
|
Performance Comparison Report 📊 (9/15)Meaningless Changes To Duration (8/14)Show entries
Show details
|
@Expensify/mobile-deployers 📣 Please look into this performance regression as it's a deploy blocker. |
…ty-report-preview [CP Staging] Revert "Filter out report previews that shouldn't be shown in ReportPreview & MoneyRequestReportView" (cherry picked from commit a742756) (cherry-picked to staging by francoisl)
Reverts #62002
For #62144