mweb - Reports - Bookmark menu is empty after saving search

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.1.45-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to Reports
3. Tap Filters
4. Tap Expense type
5. Select any type and tap Save
6. Tap Save search
7. Tap bookmark icon

Expected Result:

Menu will display with options

Actual Result:

Menu is empty

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Platforms Tested:

On which of our officially supported platforms was this issue tested:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6830015_1747159789105.Screen_Recording_20250514_020754_Chrome.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @aldo-expensify (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Menu is empty

What is the root cause of that problem?

Offending PR: #60959

We got error Uncaught ReferenceError: React is not defined. In useSearchTypeMenu file, ThreeDotsMenu component is being rendered in JSX syntax, which requires React to be in scope.

App/src/hooks/useSearchTypeMenu.tsx

Lines 155 to 165 in 2239609

	rightComponent: (
	<ThreeDotsMenu
	menuItems={getOverflowMenu(baseMenuItem.title ?? '', Number(baseMenuItem.hash ?? ''), item.query ?? '')}
	anchorPosition={{horizontal: 0, vertical: 380}}
	anchorAlignment={{
	horizontal: CONST.MODAL.ANCHOR_ORIGIN_HORIZONTAL.RIGHT,
	vertical: CONST.MODAL.ANCHOR_ORIGIN_VERTICAL.TOP,
	}}
	disabled={item.pendingAction === CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE}
	/>
	),

What changes do you think we should make in order to solve the problem?

We can fix this by adding the React import

    import React, {useCallback, useEffect, useMemo, useState} from 'react';

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

NA

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[aldo-expensify]

Thanks @nkdengineer , I think you are right, reverting that PR fixes the issue.

cc @OlimpiaZurek @rushatgabhane

[aldo-expensify]

@nkdengineer 's proposed fix sounds better than just reverting, specially considering how simple it is. I'll put up a PR.

[nkdengineer]

@aldo-expensify I can help to raise a PR now

[aldo-expensify]

@nkdengineer I appreciate the help, but I'll handle this internally since it is a very simple fix.

[nkdengineer]

@aldo-expensify Is there any chance for me to be compensated here? I identified the offending PR and my solution ended up working. In many other cases, contributors were compensated just for pointing out the offending PR.

[aldo-expensify]

@aldo-expensify Is there any chance for me to be compensated here? I identified the offending PR and my solution ended up working. In many other cases, contributors were compensated just for pointing out the offending PR.

I'll ask the team and get back to you

Asking here: https://expensify.slack.com/archives/C01SKUP7QR0/p1747166006431149

[aldo-expensify]

Tested web in staging and this is working now: https://expensify.slack.com/archives/C07J32337/p1747166169027569?thread_ts=1747164128.261989&cid=C07J32337

[melvin-bot]

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[aldo-expensify]

@adelekennedy we agreed on paying $75 to @nkdengineer here: https://expensify.slack.com/archives/C01SKUP7QR0/p1747166006431149

Does that sound good to you @nkdengineer ?

[nkdengineer]

thanks @aldo-expensify, that sounds good to me