Skip to content

[Report Creation UI] Expense - Unable to add unreported distance expense to workspace report #61997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
8 tasks done
jponikarchuk opened this issue May 14, 2025 · 16 comments
Closed
8 tasks done
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Reviewing Has a PR in review

Comments

@jponikarchuk
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.1.45-6
Reproducible in staging?: Yes
Reproducible in production?: Unable to check, new feature
If this was caught during regression testing, add the test name, ID and link from TestRail: #61760
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Mac 15.3 / Chrome
App Component: Money Requests

Action Performed:

Precondition:

  • Account has self DM and a workspace.
  1. Go to staging.new.expensify.com
  2. Go to self DM.
  3. Track a distance expense in self DM.
  4. Go to workspace chat.
  5. Submit a manual expense.
  6. Click on the expense preview.
  7. Click More.
  8. Click Add expense > Add unreported expense.
  9. Select the track distance from Step 3.
  10. Click Add to report.

Expected Result:

The track distance should be added to the workspace report without issue.

Actual Result:

The track distance is not added to the workspace report.

This issue also happens when track manual and track distance are added together to the report.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

@jponikarchuk jponikarchuk added DeployBlockerCash This issue or pull request should block deployment Bug Something is broken. Auto assigns a BugZero manager. labels May 14, 2025
Copy link

melvin-bot bot commented May 14, 2025

Triggered auto assignment to @maddylewis (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented May 14, 2025

Triggered auto assignment to @NikkiWines (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@melvin-bot melvin-bot bot added the Daily KSv2 label May 14, 2025
Copy link

melvin-bot bot commented May 14, 2025

💬 A slack conversation has been started in #expensify-open-source

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels May 14, 2025
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@SzymczakJ
Copy link
Contributor

With this PR(#62004) this button will be hidden behind a beta, so I think we can demote this deploy blocker and me or @sumo-slonik will work on the fix. cc @mountiny @luacmartins

@trjExpensify trjExpensify changed the title Expense - Unable to add unreported distance expense to workspace report [Report Creation UI] Expense - Unable to add unreported distance expense to workspace report May 14, 2025
@trjExpensify trjExpensify moved this to Second Cohort - HIGH in [#whatsnext] #migrate May 14, 2025
@trjExpensify
Copy link
Contributor

Demoting after the CP

@trjExpensify trjExpensify removed the DeployBlockerCash This issue or pull request should block deployment label May 14, 2025
@NikkiWines NikkiWines added Daily KSv2 and removed Hourly KSv2 labels May 14, 2025
@SzymczakJ
Copy link
Contributor

This is the response that BE gives when we want to move distance expense:

{
    "code": 666,
    "jsonCode": 666,
    "type": "Expensify\\Libs\\Error\\ExpError",
    "UUID": "1482DEDE-C9D4-4DD5-A00C-E6A62D988167",
    "message": "Heads up! You can't transfer Distance expenses between workspaces, as the Distance rates may differ on each workspace. Please select a report on the Adiwajd's Workspace 1 workspace, or create a new expense in the desired workspace to continue.",
    "title": "",
    "data": [],
    "htmlMessage": "",
    "onyxData": [],
    "requestID": "94011da2fb3bef91-SJC"
}

So I guess moving distance expenses should not be supported, should we just filter them out on Add unreported expenses page? cc @trjExpensify @luacmartins @mountiny

@trjExpensify
Copy link
Contributor

I think we should fix why you can't add an unreported distance expense to a workspace. That's totally possible on OldDot, as I illustrated here.

@trjExpensify
Copy link
Contributor

Video as well here:

2025-03-20_23-14-35.mp4

@SzymczakJ
Copy link
Contributor

Yeah, moving expense and putting up a violation to change the rate is a better idea.
Could we create an issue for BE then?

@trjExpensify
Copy link
Contributor

I think we'll use this issue and link the PRs to it.

@luacmartins
Copy link
Contributor

Working on a PR

@melvin-bot melvin-bot bot added the Overdue label May 19, 2025
Copy link

melvin-bot bot commented May 19, 2025

@trjExpensify, @luacmartins, @mountiny, @SzymczakJ, @allgandalf Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@mountiny
Copy link
Contributor

Pr was merged late last week

@melvin-bot melvin-bot bot removed the Overdue label May 19, 2025
@luacmartins
Copy link
Contributor

PR deployed to prod. Can we retest and close if this is fixed?

@luacmartins luacmartins added the Reviewing Has a PR in review label May 20, 2025
@luacmartins
Copy link
Contributor

Can confirm this is fixed. Closing since it was BE work.

Screen.Recording.2025-05-20.at.3.42.09.PM.mov

@github-project-automation github-project-automation bot moved this from Second Cohort - HIGH to Done in [#whatsnext] #migrate May 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Reviewing Has a PR in review
Projects
Development

No branches or pull requests

8 participants