-
Notifications
You must be signed in to change notification settings - Fork 3.2k
[Report Creation UI] Expense - Unable to add unreported distance expense to workspace report #61997
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Triggered auto assignment to @maddylewis ( |
Triggered auto assignment to @NikkiWines ( |
💬 A slack conversation has been started in #expensify-open-source |
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
With this PR(#62004) this button will be hidden behind a beta, so I think we can demote this deploy blocker and me or @sumo-slonik will work on the fix. cc @mountiny @luacmartins |
Demoting after the CP |
This is the response that BE gives when we want to move distance expense:
So I guess moving distance expenses should not be supported, should we just filter them out on Add unreported expenses page? cc @trjExpensify @luacmartins @mountiny |
I think we should fix why you can't add an unreported distance expense to a workspace. That's totally possible on OldDot, as I illustrated here. |
Video as well here: 2025-03-20_23-14-35.mp4 |
Yeah, moving expense and putting up a violation to change the rate is a better idea. |
I think we'll use this issue and link the PRs to it. |
Working on a PR |
@trjExpensify, @luacmartins, @mountiny, @SzymczakJ, @allgandalf Uh oh! This issue is overdue by 2 days. Don't forget to update your issues! |
Pr was merged late last week |
PR deployed to prod. Can we retest and close if this is fixed? |
Can confirm this is fixed. Closing since it was BE work. Screen.Recording.2025-05-20.at.3.42.09.PM.mov |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: 9.1.45-6
Reproducible in staging?: Yes
Reproducible in production?: Unable to check, new feature
If this was caught during regression testing, add the test name, ID and link from TestRail: #61760
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Mac 15.3 / Chrome
App Component: Money Requests
Action Performed:
Precondition:
Expected Result:
The track distance should be added to the workspace report without issue.
Actual Result:
The track distance is not added to the workspace report.
This issue also happens when track manual and track distance are added together to the report.
Workaround:
Unknown
Platforms:
Screenshots/Videos
1.mp4
View all open jobs on GitHub
The text was updated successfully, but these errors were encountered: