Skip to content

Deploy Checklist: New Expensify 2025-05-07 #61626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
90 tasks done
github-actions bot opened this issue May 7, 2025 · 16 comments
Closed
90 tasks done

Deploy Checklist: New Expensify 2025-05-07 #61626

github-actions bot opened this issue May 7, 2025 · 16 comments
Assignees
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging Monthly KSv2 StagingDeployCash

Comments

@github-actions
Copy link
Contributor

github-actions bot commented May 7, 2025

Release Version: 9.1.44-8
Compare Changes: production...staging

This release contains changes from the following pull requests:

Deploy Blockers:

Deployer verifications:

  • I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
  • I checked Firebase Crashlytics for this release version and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
  • I checked Firebase Crashlytics for the previous release version and verified that the release did not introduce any new crashes. More detailed instructions on this verification can be found here.
  • I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

@gleitebr gleitebr added the 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging label May 7, 2025
Copy link
Contributor Author

github-actions bot commented May 8, 2025

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/9.1.42-0 🚀

@izarutskaya
Copy link

Regression is at 79% completed.

Blockers:
#61630
#61633
#61634
#61637
#61640
#61642
#61646
#61649
#61650
#61652
#61662
#61668
#61671
#61674
#61675

@mvtglobally
Copy link

Regression is at 99% completed

@marcaaron
Copy link
Contributor

Checking off #61634 since it seems like a minor UI issue.

@mvtglobally
Copy link

mvtglobally commented May 9, 2025

Regression is completed

PRs
#61098 - issue repro #61639 when running PR. Checking off
#61135 - is blocked due to #61463
#61260 - is failing due to #61643
#61482 (comment) - Checking off
Checking CPs

@roryabraham
Copy link
Contributor

#61650 is resolved, checking off

@yuwenmemon
Copy link
Contributor

@mvtglobally @izarutskaya, Could we please retest all of the unchecked deploy blockers left? We just deployed a PR that we believe should fix the vast majority of them. 🙇‍♂

Please check off all that are now passing 🙏🏽

@IuliiaHerets
Copy link

Checking off the retested Blocker:
#61640
#61642
#61652
#61674
#61685
#61720
#61671 - fixed on Android, iOS was not updated yet

@yuwenmemon
Copy link
Contributor

Thanks!

@yuwenmemon
Copy link
Contributor

@mvtglobally @IuliiaHerets Can we retest #61260? The issue it was held on has been fixed in staging.

@yuwenmemon
Copy link
Contributor

I also see that #61633 is unchecked, but I don't see reference as to why - can we retest?

@IuliiaHerets
Copy link

@yuwenmemon Issue #61633 is still repro

@mjasikowski
Copy link
Contributor

Demoting #61820

@melvin-bot melvin-bot bot added the Monthly KSv2 label May 12, 2025
@francoisl
Copy link
Contributor

francoisl commented May 13, 2025

We had an issue with the iOS builds and TestFlights weren't properly generated, it should be fixed now as of 9.1.44-2. I'll retest the remaining blockers that should have been fixed by one of the previous cherry-picks.

We also still have a bunch of blockers waiting on #61844.

  • 61633 fixed on iOS, checking off
  • 61649: the fix PR is checked off, also marking this one

@mountiny
Copy link
Contributor

demoted #61822

@francoisl
Copy link
Contributor

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging Monthly KSv2 StagingDeployCash
Projects
None yet
Development

No branches or pull requests