[Due for payment 2025-05-22] [Due for payment 2025-05-20] Workspace - Searching for member using full name returns no result

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.1.42-0
Reproducible in staging?: Yes
Reproducible in production?: Unable to check, new feature
If this was caught during regression testing, add the test name, ID and link from TestRail: #60488
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Mac 15.3 / Chrome
App Component: Workspace Settings

Action Performed:

Precondition:

• Have a workspace with at least 16 members.
• At least one member has first and last name.

1. Go to staging.new.expensify.com
2. Go to workspace settings > Members.
3. Search for the member with first and last name using the full name.

Expected Result:

The search result will return the member with the full name.

Actual Result:

The search result returns nothing when searching for member using full name.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @strepanier03

[melvin-bot]

Triggered auto assignment to @cristipaval (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[daledah]

Coming from #60488, I'll open a follow-up soon.

[nabi-ebrahimi]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When a user searches for a member using a full name or partial full name (e.g., "Jane D" or "zarin 3"), the member is not returned unless the search query exactly matches one of the fields (text or alternateText). This results in unexpected behavior, where valid partial name matches do not appear in the search results.

What is the root cause of that problem?

The filtering logic only checks if the search query is found within either text or alternateText separately. It also lacks proper normalization of the data, so partial matches like "zarin 3" do not match "zarin 30" even though the beginning of the name clearly aligns. In addition, queries that span both the first and last name (e.g., "Jane D") also fail, because the match isn’t performed on a combined and normalized name string.

What changes do you think we should make in order to solve the problem?

Update the filterMember function to:

  const normalize = (value: string) => value.toLowerCase().replace(/\s+/g, ' ').trim();

    const filterMember = useCallback((memberOption: MemberOption, searchQuery: string) => {
        const fullText = normalize(`${memberOption.text ?? ''} ${memberOption.alternateText ?? ''}`);
        const normalizedQuery = normalize(searchQuery);
        return fullText.includes(normalizedQuery);
    }, []);

• Concatenate both text and alternateText fields.

• Normalize the combined string and the user input by:

  • Converting to lowercase
  • Replacing multiple spaces with a single space
  • Trimming surrounding spaces
    Then, check if the normalized query is included in the normalized combined string.

This approach ensures that partial and full-name queries like "Jane D", "zarin 3", or "Jane Sharifi" work reliably.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

[github-actions]

⚠️ @nabi-ebrahimi Thanks for your proposal. Please update it to follow the proposal template, as proposals are only reviewed if they follow that format (note the mandatory sections).

[cristipaval]

Handing over to @roryabraham as I see he has more context on the big PR that introduced this regression.

[daledah]

Okay this one is tricky, BE send user's displayName that uses non-breaking space (ASCII code 160), while keyboard input uses space character (ASCII code 32) so they're not equal. @roryabraham What are your thoughts on this?

[daledah]

I've come up with a solution and added in #61686

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[roryabraham]

It looks like that PR contains maybe a few different fixes - but the core fix (stripping both spaces and nbsp from the search query and the strings to search) seems sound. Let's get that fix in review 👍🏼

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[roryabraham]

Here's my fix: #61746

Definitely seems @daledah had the correct root cause, even if the implementation was slightly different.

[kavimuru]

Bug is not reproducible

Recording.3091.mp4

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.44-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Make search bars work with spaces #61746
• fix: add search bar followups #61686

If no regressions arise, payment will be issued on 2025-05-20. 🎊

For reference, here are some details about the assignees on this issue:

• @daledah requires payment (Needs manual offer from BZ)

[melvin-bot]

@roryabraham @strepanier03 @daledah The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.45-21 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Make search bars work with spaces #61746
• fix: add search bar followups #61686

If no regressions arise, payment will be issued on 2025-05-22. 🎊

For reference, here are some details about the assignees on this issue:

• @daledah requires payment (Needs manual offer from BZ)

[melvin-bot]

@roryabraham @strepanier03 @daledah The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]