Skip to content

[Due for payment 2025-05-20] [$250] Workspace - Intro text "Directory of all workspace members" disappears when there is no result #61820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
2 of 8 tasks
jponikarchuk opened this issue May 10, 2025 · 20 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering

Comments

@jponikarchuk
Copy link

jponikarchuk commented May 10, 2025

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.1.43-7
Reproducible in staging?: Yes
Reproducible in production?: Unable to check
If this was caught during regression testing, add the test name, ID and link from TestRail: #60488
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: iPhone 15 Pro Max / iOS 18.4
App Component: Workspace Settings

Action Performed:

Precondition:

  • Workspace has at least 16 members.
  1. Go to staging.new.expensify.com
  2. Go to workspace settings > Members.
  3. Tap on the search field.
  4. Enter any term that will not return any result.

Expected Result:

The introduction text "Directory of all workspace members" will not disappear when there is no search result.

Actual Result:

The introduction text "Directory of all workspace members" disappears when there is no search result.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6827124_1746859548007.ScreenRecording_05-10-2025_14-41-26_1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021921838489495374680
  • Upwork Job ID: 1921838489495374680
  • Last Price Increase: 2025-05-12
  • Automatic offers:
    • daledah | Contributor | 107268967
Issue OwnerCurrent Issue Owner: @
Issue OwnerCurrent Issue Owner: @twisterdotcom
@jponikarchuk jponikarchuk added DeployBlockerCash This issue or pull request should block deployment Bug Something is broken. Auto assigns a BugZero manager. labels May 10, 2025
Copy link

melvin-bot bot commented May 10, 2025

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented May 10, 2025

Triggered auto assignment to @mjasikowski (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented May 10, 2025

💬 A slack conversation has been started in #expensify-open-source

@melvin-bot melvin-bot bot added the Daily KSv2 label May 10, 2025
@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels May 10, 2025
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@samranahm
Copy link
Contributor

Proposal

Please re-state the problem that we are trying to solve in this issue.

Workspace - Intro text "Directory of all workspace members" disappears when there is no result

What is the root cause of that problem?

We only get the header message when there is some results filteredData.length > 0

What changes do you think we should make in order to solve the problem?

We should remove this condition here filteredData.length > 0

{shouldUseNarrowLayout && filteredData.length > 0 && <View style={[styles.pr5]}>{getHeaderContent()}</View>}

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

@ChavdaSachin
Copy link
Contributor

cc. @daledah

@mjasikowski mjasikowski removed the DeployBlockerCash This issue or pull request should block deployment label May 12, 2025
@melvin-bot melvin-bot bot added the Overdue label May 12, 2025
@mjasikowski
Copy link
Contributor

Minor UI issue, removing the DeployBlockerCash label

@melvin-bot melvin-bot bot removed the Overdue label May 12, 2025
@mjasikowski mjasikowski added Daily KSv2 Weekly KSv2 External Added to denote the issue can be worked on by a contributor and removed Hourly KSv2 Daily KSv2 labels May 12, 2025
@melvin-bot melvin-bot bot changed the title Workspace - Intro text "Directory of all workspace members" disappears when there is no result [$250] Workspace - Intro text "Directory of all workspace members" disappears when there is no result May 12, 2025
Copy link

melvin-bot bot commented May 12, 2025

Job added to Upwork: https://www.upwork.com/jobs/~021921838489495374680

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label May 12, 2025
Copy link

melvin-bot bot commented May 12, 2025

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rayane-d (External)

@melvin-bot melvin-bot bot added the Daily KSv2 label May 12, 2025
@melvin-bot melvin-bot bot added the Overdue label May 12, 2025
@mjasikowski mjasikowski added External Added to denote the issue can be worked on by a contributor and removed External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors labels May 12, 2025
@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label May 12, 2025
Copy link

melvin-bot bot commented May 12, 2025

Current assignee @rayane-d is eligible for the External assigner, not assigning anyone new.

@melvin-bot melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label May 12, 2025
Copy link

melvin-bot bot commented May 12, 2025

📣 @daledah 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

@melvin-bot melvin-bot bot removed the Overdue label May 12, 2025
@mjasikowski mjasikowski removed the External Added to denote the issue can be worked on by a contributor label May 12, 2025
@mjasikowski
Copy link
Contributor

@daledah I messed something up with the tags, please discard the Upwork message.

@daledah
Copy link
Contributor

daledah commented May 12, 2025

Will be fixed in #61844

Copy link

melvin-bot bot commented May 12, 2025

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

Copy link

melvin-bot bot commented May 12, 2025

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@rayane-d
Copy link
Contributor

cc @thesahindia as PR reviewer

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Daily KSv2 Weekly KSv2 labels May 13, 2025
@melvin-bot melvin-bot bot changed the title [$250] Workspace - Intro text "Directory of all workspace members" disappears when there is no result [Due for payment 2025-05-20] [$250] Workspace - Intro text "Directory of all workspace members" disappears when there is no result May 13, 2025
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label May 13, 2025
Copy link

melvin-bot bot commented May 13, 2025

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented May 13, 2025

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.44-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-05-20. 🎊

For reference, here are some details about the assignees on this issue:

Copy link

melvin-bot bot commented May 13, 2025

@rayane-d @twisterdotcom @rayane-d The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels May 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering
Projects
None yet
Development

No branches or pull requests

7 participants