[CP Staging] Categories - Checkmark appears briefly next to the toggle after exiting selection mode #61906

thelullabyy · 2025-05-13T12:58:33Z

…tion mode

Explanation of Change

Fixed Issues

$#61823
PROPOSAL:#61823 (comment)

Tests

Open the App
Go to workspace settings > Categories.
Long press on any category.
Tap Select.
Tap app back button to exit selection mode
Verify checkmark not appear next to the toggle after exiting selection mode

Verify that no errors appear in the JS console

Offline tests

QA Steps

Open the App
Go to workspace settings > Categories.
Long press on any category.
Tap Select.
Tap app back button to exit selection mode
Verify checkmark not appear next to the toggle after exiting selection mode

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I verified there are no new alerts related to the canBeMissing param for useOnyx
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

android_chorme.mov

iOS: Native

ios.mp4

iOS: mWeb Safari

safari.mp4

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

…tion mode

melvin-bot · 2025-05-13T13:04:09Z

@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

github-actions · 2025-05-13T13:09:02Z

🚧 @mountiny has triggered a test app build. You can view the workflow run here.

DylanDylann · 2025-05-13T13:14:10Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2025-05-13.at.20.33.14.mov

Android: mWeb Chrome

Screen.Recording.2025-05-13.at.20.31.51.mov

iOS: HybridApp

Screen.Recording.2025-05-13.at.20.31.07.mov

iOS: mWeb Safari

Screen.Recording.2025-05-13.at.20.31.35.mov

MacOS: Chrome / Safari

MacOS: Desktop

mountiny · 2025-05-13T13:35:58Z

src/components/SelectionList/BaseListItem.tsx

@@ -40,6 +40,7 @@ function BaseListItem<TItem extends ListItem>({
    hoverStyle,
    onLongPressRow,
    testID,
+    shouldUseDefaultRightHandSideCheckmark = true,


I wonder though if there is a better long term solution than this one? @daledah @thelullabyy

…s-briefly [CP Staging] Categories - Checkmark appears briefly next to the toggle after exiting selection mode (cherry picked from commit 03bed1a) (cherry-picked to staging by mountiny)

OSBotify · 2025-05-13T13:46:35Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-05-13T13:48:32Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
Android 🤖🔄	iOS 🍎🔄
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/61906-hybrid/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/61906-hybrid/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/61906/NewExpensify.dmg	https://61906.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

github-actions · 2025-05-13T14:21:47Z

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.1.44-7 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	failure ❌

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

github-actions · 2025-05-13T17:54:45Z

🚀 Deployed to production by https://github.com/francoisl in version: 9.1.44-8 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

github-actions · 2025-05-13T18:26:18Z

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.1.45-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	failure ❌

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

github-actions · 2025-05-13T19:36:11Z

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.1.45-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

github-actions · 2025-05-15T19:03:34Z

🚀 Deployed to production by https://github.com/francoisl in version: 9.1.45-21 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

fix: Checkmark appears briefly next to the toggle after exiting selec…

60bdeaf

…tion mode

thelullabyy marked this pull request as ready for review May 13, 2025 13:04

thelullabyy requested a review from a team as a code owner May 13, 2025 13:04

melvin-bot bot requested review from DylanDylann and removed request for a team May 13, 2025 13:04

DylanDylann approved these changes May 13, 2025

View reviewed changes

melvin-bot bot requested a review from techievivek May 13, 2025 13:34

mountiny changed the title ~~Categories - Checkmark appears briefly next to the toggle after exiting selection mode~~ [CP Staging] Categories - Checkmark appears briefly next to the toggle after exiting selection mode May 13, 2025

mountiny assigned thelullabyy May 13, 2025

mountiny approved these changes May 13, 2025

View reviewed changes

mountiny merged commit 03bed1a into Expensify:main May 13, 2025
19 checks passed

OSBotify added the CP Staging marks PRs that have been CP'd to staging label May 13, 2025

github-actions bot mentioned this pull request May 13, 2025

Deploy Checklist: New Expensify 2025-05-07 #61626

Closed

90 tasks

melvin-bot bot mentioned this pull request May 13, 2025

[Due for payment 2025-05-20] [$250] Categories - Checkmark appears briefly next to the toggle after exiting selection mode #61823

Closed

8 tasks

mountiny mentioned this pull request May 14, 2025

Deploy Checklist: New Expensify 2025-05-13 #61917

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[CP Staging] Categories - Checkmark appears briefly next to the toggle after exiting selection mode #61906

[CP Staging] Categories - Checkmark appears briefly next to the toggle after exiting selection mode #61906

thelullabyy commented May 13, 2025 •

edited

Loading

melvin-bot bot commented May 13, 2025

github-actions bot commented May 13, 2025

DylanDylann commented May 13, 2025 •

edited

Loading

mountiny May 13, 2025

OSBotify commented May 13, 2025

github-actions bot commented May 13, 2025

github-actions bot commented May 13, 2025

github-actions bot commented May 13, 2025

github-actions bot commented May 13, 2025

github-actions bot commented May 13, 2025

github-actions bot commented May 15, 2025

[CP Staging] Categories - Checkmark appears briefly next to the toggle after exiting selection mode #61906

[CP Staging] Categories - Checkmark appears briefly next to the toggle after exiting selection mode #61906

Conversation

thelullabyy commented May 13, 2025 • edited Loading

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented May 13, 2025

github-actions bot commented May 13, 2025

DylanDylann commented May 13, 2025 • edited Loading

Reviewer Checklist

Screenshots/Videos

mountiny May 13, 2025

Choose a reason for hiding this comment

OSBotify commented May 13, 2025

github-actions bot commented May 13, 2025

github-actions bot commented May 13, 2025

github-actions bot commented May 13, 2025

github-actions bot commented May 13, 2025

github-actions bot commented May 13, 2025

github-actions bot commented May 15, 2025

thelullabyy commented May 13, 2025 •

edited

Loading

DylanDylann commented May 13, 2025 •

edited

Loading