Skip to content

Search icon in Category WS has no hint #61638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
2 of 8 tasks
mitarachim opened this issue May 8, 2025 · 8 comments
Closed
2 of 8 tasks

Search icon in Category WS has no hint #61638

mitarachim opened this issue May 8, 2025 · 8 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering

Comments

@mitarachim
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: v9.1.42-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail: #60488
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Macbook Pro 2023 / Sequoia 15.2
App Component: Workspace Settings

Action Performed:

  1. Open the ND app
  2. Sign into a valid Beta user
  3. Go to a Workspace with more than 15 categories
  4. Observe the search icon in the Category Search page for Workspaces

Expected Result:

User expects there to be a tooltip

Actual Result:

No tooltip is displayed

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6825069_1746670139156.Search_icon_in_Category_WS_has_no_hint.mp4

View all open jobs on GitHub

@mitarachim mitarachim added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. DeployBlocker Indicates it should block deploying the API labels May 8, 2025
Copy link

melvin-bot bot commented May 8, 2025

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented May 8, 2025

Triggered auto assignment to @robertjchen (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented May 8, 2025

💬 A slack conversation has been started in #expensify-open-source

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels May 8, 2025
Copy link
Contributor

github-actions bot commented May 8, 2025

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@samranahm
Copy link
Contributor

Proposal

Please re-state the problem that we are trying to solve in this issue.


What is the root cause of that problem?

We have not added the tooltip here

{categoryList.length > CONST.SEARCH_ITEM_LIMIT && (
<SearchBar
label={translate('workspace.categories.findCategory')}
inputValue={inputValue}
onChangeText={setInputValue}
shouldShowEmptyState={hasVisibleCategories && !isLoading && filteredCategoryList.length === 0}
/>
)}

What changes do you think we should make in order to solve the problem?

We should wrap the SearchBar with ToolTip here with text findCategory

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

@daledah
Copy link
Contributor

daledah commented May 8, 2025

cc @Expensify/design @shawnborton There's no precedent of adding tooltip to InputField icon before, what do you think we should do here?

@mitarachim
Copy link
Author

mitarachim commented May 8, 2025

Just for reference , QA team compare with tooltip while hover search icon in inbox.

Image
Screen.Recording.2025-05-08.at.11.50.36.AM.mov

@robertjchen robertjchen added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment DeployBlocker Indicates it should block deploying the API Hourly KSv2 labels May 8, 2025
@shawnborton
Copy link
Contributor

I don't think we need a tooltip on the inputs personally, I think we can close this and consider it not a blocker.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering
Projects
None yet
Development

No branches or pull requests

6 participants