[Due for payment 2025-05-22] [$250] Reports - Outstanding tooltip in Reports > Tasks mentions "expenses" instead of "tasks"

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.1.42-0
Reproducible in staging?: Yes
Reproducible in production?: Unable to check
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Mac 15.3 / Chrome
App Component: Search

Action Performed:

1. Go to staging.new.expensify.com
2. Log in with a new account that has workspace.
3. Dismiss Account tooltip.
4. Go to Reports.
5. Go to Tasks.

Expected Result:

Outstanding tooltip content will explain the task outstanding tab.

Actual Result:

Outstanding tooltip in Tasks tab shows "Filter for expenses that need approval", which does not explain the tasks.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6825026_1746664229005.20250508_080833.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021920365115012200876
• Upwork Job ID: 1920365115012200876
• Last Price Increase: 2025-05-08

Issue Owner

Current Issue Owner: @

Issue Owner

Current Issue Owner: @RachCHopkins

[melvin-bot]

Triggered auto assignment to @RachCHopkins (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @robertjchen (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[ChavdaSachin]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Reports - Outstanding tooltip in Reports > Tasks mentions "expenses" instead of "tasks"

What is the root cause of that problem?

Here's the logic to render the outstanding tooltip

App/src/components/Search/SearchPageHeader/SearchStatusBar.tsx

Lines 272 to 275 in bd59655

	const {renderProductTrainingTooltip, shouldShowProductTrainingTooltip, hideProductTrainingTooltip} = useProductTrainingContext(
	CONST.PRODUCT_TRAINING_TOOLTIP_NAMES.OUTSANDING_FILTER,
	isScreenFocused && !isOutstandingStatusActive,
	);

And notice it does not check for the selected type to render the tooltip.

What changes do you think we should make in order to solve the problem?

Change condition to

        isScreenFocused && !isOutstandingStatusActive && (queryJSON.type === CONST.SEARCH.DATA_TYPES.EXPENSE),

App/src/components/Search/SearchPageHeader/SearchStatusBar.tsx

Lines 272 to 275 in bd59655

	const {renderProductTrainingTooltip, shouldShowProductTrainingTooltip, hideProductTrainingTooltip} = useProductTrainingContext(
	CONST.PRODUCT_TRAINING_TOOLTIP_NAMES.OUTSANDING_FILTER,
	isScreenFocused && !isOutstandingStatusActive,
	);

this will ensure the tooltip is only visible when type is expense or expense reports.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

NA

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[ChavdaSachin]

I could raise a quick PR if needed here.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021920365115012200876

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @hungvu193 (External)

[hungvu193]

@ChavdaSachin 's proposal here looks good to me!

🎀 👀 🎀

[melvin-bot]

Current assignee @robertjchen is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

[melvin-bot]

❌ There was an error making the offer to @ChavdaSachin for the Contributor role. The BZ member will need to manually hire the contributor.

[robertjchen]

LGTM!

[ChavdaSachin]

Raising PR within a couple hours.

[ChavdaSachin]

PR ready for review
cc. @robertjchen @hungvu193

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.45-21 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Render outstanding tooltip only on expense & expense reports page. #61727

If no regressions arise, payment will be issued on 2025-05-22. 🎊

For reference, here are some details about the assignees on this issue:

• @hungvu193 requires payment through NewDot Manual Requests
• @ChavdaSachin requires payment (Needs manual offer from BZ)

[melvin-bot]

@hungvu193 @RachCHopkins @hungvu193 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[ChavdaSachin]

• @ChavdaSachin requires payment (Needs manual offer from BZ)

I have applied for the job on upwork.
My upwork: https://www.upwork.com/freelancers/~016a0f0a12bce54a49