[Due for payment 2025-05-22] [Due for payment 2025-05-20] mweb - LHN is shifted to right

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.1.42-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Samsung Galaxy Z Fold 4 / Android 14
App Component: Left Hand Navigation (LHN)

Action Performed:

1. Go to staging.new.expensify.com
2. Check the LHN.

Expected Result:

LHN will not be shifted to right.

Actual Result:

LHN is shifted to right.
Account and Workspaces settings pages are also shifted to right.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @kadiealexander

[melvin-bot]

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @marcaaron (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[ChavdaSachin]

Proposal

Please re-state the problem that we are trying to solve in this issue.

mweb - LHN is shifted to right

What is the root cause of that problem?

padding passed here is not passed conditionally.

App/src/libs/Navigation/AppNavigator/useSplitNavigatorScreenOptions.ts

Line 43 in bd59655

paddingLeft: variables.navigationTabBarSize,

What changes do you think we should make in order to solve the problem?

pass the padding style conditionally

    paddingLeft: shouldUseNarrowLayout ? 0 : variables.navigationTabBarSize,

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

NA

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[ChavdaSachin]

I could raise a quick PR if needed

[linhvovan29546]

Regression #61506 cc @ikevin127

[ikevin127]

@WojtekBoman To possibly raise a follow-up PR with a fix, I'll review it asap 👍

[WojtekBoman]

I'll take a look at it together with @adamgrzybowski 👀

[adamgrzybowski]

@ikevin127 #61679 fixed here

[ikevin127]

@marcaaron PR reviewer checklist completed, I just can't Approve because auto-assigned C+ is still assigned.

[kavimuru]

Bug is not reproducible anymore

0-02-01-dce7b256c2cd8f89437076af137f30e3fae07cc9a61cfd3fc01ec4c0791938e4_11e8c605a0611ed0.mp4

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.44-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Fix: Padding for navigation bar on narrow layout #61679

If no regressions arise, payment will be issued on 2025-05-20. 🎊

For reference, here are some details about the assignees on this issue:

• @ikevin127 requires payment (Needs manual offer from BZ)

[melvin-bot]

@ikevin127 @kadiealexander @ikevin127 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[ikevin127]

@kadiealexander This can be closed as it was a regression issue coming from #61460 where payment will be handled for me.

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.45-21 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Fix: Padding for navigation bar on narrow layout #61679

If no regressions arise, payment will be issued on 2025-05-22. 🎊

For reference, here are some details about the assignees on this issue:

• @ikevin127 requires payment (Needs manual offer from BZ)

[melvin-bot]

@ikevin127 @kadiealexander @ikevin127 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[ikevin127]

No payment required here in the regression issue, will be handled in the main issue.