Skip to content

[CP Staging] Revert "Fix manual confirmation page shows per diem confirmation page" #61695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 8, 2025

Conversation

mollfpr
Copy link
Contributor

@mollfpr mollfpr commented May 8, 2025

Revert #60940

Fixed issue #61637

QA

Retest the step #61637

@mollfpr mollfpr requested a review from a team as a code owner May 8, 2025 14:05
@melvin-bot melvin-bot bot requested a review from MarioExpensify May 8, 2025 14:06
Copy link

melvin-bot bot commented May 8, 2025

@MarioExpensify Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot bot removed the request for review from a team May 8, 2025 14:06
@mollfpr mollfpr self-assigned this May 8, 2025
@mollfpr mollfpr merged commit f9e4ee7 into main May 8, 2025
18 of 20 checks passed
@mollfpr mollfpr deleted the revert-60940-59499-manual-confirmation branch May 8, 2025 14:12
@melvin-bot melvin-bot bot added the Emergency label May 8, 2025
Copy link

melvin-bot bot commented May 8, 2025

@mollfpr looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@mollfpr mollfpr removed the Emergency label May 8, 2025
@mollfpr
Copy link
Contributor Author

mollfpr commented May 8, 2025

Straight revert

@OSBotify
Copy link
Contributor

OSBotify commented May 8, 2025

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify pushed a commit that referenced this pull request May 8, 2025
…nfirmation

[CP Staging] Revert "Fix manual confirmation page shows per diem confirmation page"

(cherry picked from commit f9e4ee7)

(cherry-picked to staging by yuwenmemon)
@OSBotify OSBotify added the CP Staging marks PRs that have been CP'd to staging label May 8, 2025
Copy link
Contributor

github-actions bot commented May 8, 2025

🚀 Cherry-picked to staging by https://github.com/yuwenmemon in version: 9.1.42-3 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

Copy link
Contributor

github-actions bot commented May 9, 2025

🚀 Cherry-picked to staging by https://github.com/yuwenmemon in version: 9.1.43-5 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 failure ❌

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

Copy link
Contributor

🚀 Deployed to production by https://github.com/francoisl in version: 9.1.44-8 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 failure ❌
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CP Staging marks PRs that have been CP'd to staging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants