[$250] Workspace - Error message appears when delete approver

[nlemma]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: v9.1.41-1
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/6074170&group_by=cases:section_id&group_order=asc&group_id=229065
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Lenovo 80ES / Windows 10 Pro
App Component: Workspace Settings

Action Performed:

1. Log in with gmail account
2. Create workspace> Invite member
3. Promote the invited member as approver
4. Remove the approver from workspace members list
5. Go back to the workspaces page

Expected Result:

There should be no error message

Actual Result:

Error message "402 default approver is not a member of the policy:" appears under workspace section

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6825385_1746695163820.Recording__5402.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021921856170250657164
• Upwork Job ID: 1921856170250657164
• Last Price Increase: 2025-05-12

Issue Owner

Current Issue Owner: @mjasikowski

[melvin-bot]

Triggered auto assignment to @RachCHopkins (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @mjasikowski (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[nlemma]

@RachCHopkins FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[mjasikowski]

@RachCHopkins do you think it's a bug? I think it's a valid error and should be shown, but could be worded differently (i.e. "workspace" instead of "policy").

[yuwenmemon]

@mjasikowski I feel like it's showing in the wrong place though, wouldn't you say?

[yuwenmemon]

Removing blocker label: https://expensify.slack.com/archives/C01GTK53T8Q/p1746740796299029?thread_ts=1746697332.715449&cid=C01GTK53T8Q

[RachCHopkins]

Actually, I take that back - if you click the box and remove, you get told that the default approver will be the billing owner. And then the approver changes, but they can't be deleted with the check box method.

deleteapprover.mp4

Also, when you go to add the user and set the default approver again, it takes multiple attempts for the new approver to "stick". You have to go to the workflows page and refresh it first.

2025-05-09_13-52-49.mp4

If you come in fresh and you delete the user from the RHP, it DOES delete the user and also reset the approver.

So in summary, I have no idea how to repro this OP issue, but it appears there are two more issues:

1. The updated approver only sticks after refreshing the Members page
2. The system is not deleting the user from the members table after updating the approver, when done via check-box.

You should not even be able to delete a default approver, so if that's in a deploy then maybe it is a deploy blocker @yuwenmemon ?

[mjasikowski]

Thanks @yuwenmemon and @RachCHopkins, I'll see where this is coming from and try to diagnose it.

[mjasikowski]

Slack discussion here: https://expensify.slack.com/archives/C01GTK53T8Q/p1746998011277749?thread_ts=1746697332.715449&cid=C01GTK53T8Q

The gist of this issue is: you shouldn't be able to delete the default approver without it auto-updating to the billing owner.

Since it's a front-end thing, I'm marking this issue as external.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021921856170250657164

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)

[LorenzoBloedow]

Unable to reproduce except for one time but I was offline and got an extra error too.
Tried many variations of old and new accounts including choosing different onboarding options.
Something might be missing in the repro steps. Maybe a prerequisite?

[huult]

I can't reproduce this issue

[IuliiaHerets]

Tester can't reproduce the issue either in v9.1.45-7

Recording.5473.mp4

[mjasikowski]

@RachCHopkins is it good to close then?

[mjasikowski]

Not overdue

[RachCHopkins]

Yes, I think so! Closing.