Skip to content

Android - Reports - "Filter for expenses that need approval" tooltip is displayed cutted off #61634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 of 8 tasks
mitarachim opened this issue May 8, 2025 · 14 comments
Closed
1 of 8 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering

Comments

@mitarachim
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.1.42-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Motorola MotoG60 - Android 12
App Component: Other

Action Performed:

  1. Open the Expensify app.
  2. Sign up with a new account.
  3. Create a new workspace.
  4. Navigate to "Reports"
  5. Note that the tooltip displayed on outstanding filter is displayed cutted off.

Expected Result:

"Filter for expenses that need approval" tooltip should be completelly visible.

Actual Result:

"Filter for expenses that need approval" on outstanding tab on "Reports" is displayed cutted off and the "X" button to dismiss it can´t be reached. User has to scroll the filters to see the tooltip complete.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6825034_1746665933795.Cutted.mp4

View all open jobs on GitHub

@mitarachim mitarachim added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. DeployBlocker Indicates it should block deploying the API labels May 8, 2025
Copy link

melvin-bot bot commented May 8, 2025

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented May 8, 2025

Triggered auto assignment to @marcaaron (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented May 8, 2025

💬 A slack conversation has been started in #expensify-open-source

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels May 8, 2025
Copy link
Contributor

github-actions bot commented May 8, 2025

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@marcaaron
Copy link
Contributor

Appears to be introduced by #59950 cc @ishpaul777 @MarioExpensify

Honestly, does not look so bad to me - but maybe could be improved? I think we make this a non-blocker or perhaps even close.

@marcaaron marcaaron added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment DeployBlocker Indicates it should block deploying the API Hourly KSv2 labels May 8, 2025
@ishpaul777
Copy link
Contributor

same thoughts @marcaaron, @rayane-d what do you think it would be possible to improve this?

@marcaaron
Copy link
Contributor

Something like... if the entire tooltip can't be shown then don't show it. Or offset it so that it's always on the right edge of the screen without overlap. It could be done, but not sure if it's worth the effort. @trjExpensify WDYT?

@MarioExpensify
Copy link
Contributor

I really have mixed feelings on this. I have a very narrow screen phone (Z Fold) and thus the "Outstanding" filter is cut, I feel like we would be in a worst position if the tooltip appears to be pointing to the "Unreported" for very narrow phones than it being floating with the list of filters, but that is obviously my opinion.

Let's tag @Expensify/design if anyone can give us some thoughts on what would be the best way to handle this.

@trjExpensify
Copy link
Contributor

Mhm, I think we do probably need to shift it over because it has an X to dismiss it which is cut off right now out of view. 🤔

@dubielzyk-expensify
Copy link
Contributor

Yeah agree. Part of me thinks we should make this tooltip go on another filter and maybe make it more generic to avoid this issue. If we can easily scroll and shift the tooltip, then that'd be great. I got this bug yesterday and I had more cut-off than the video due to a smaller screen

@MarioExpensify
Copy link
Contributor

MarioExpensify commented May 9, 2025

A more generic text pointing to the first filter would probably solve the issue as we will always have it appearing on screen.

@rayane-d @flaviadefaria if you can take a look.

@shawnborton
Copy link
Contributor

Hmm I feel like we should do nothing here, these are all going to change soon with the Suggested Search project. When that happens, we'll want to change the tooltip location entirely as we won't have exposed status tabs like this.

@trjExpensify
Copy link
Contributor

Fair point. We'll likely want to highlight the bookmark button to lead people to the suggested searches for Submit, Approve, Pay etc.

@marcaaron
Copy link
Contributor

Gonna close for now. Feel free to reopen if experiencing strong feelings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering
Projects
None yet
Development

No branches or pull requests

8 participants