Skip to content

[Due for payment 2025-05-20] [Due for payment 2025-05-13] [$500] Update Migrate tooltips #57045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
flaviadefaria opened this issue Feb 18, 2025 · 56 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item. Weekly KSv2

Comments

@flaviadefaria
Copy link
Contributor

flaviadefaria commented Feb 18, 2025

Problem:

After watching several FS sessions, we've seen that not everyone engaged with the tooltips, and engagement varied depending on whether the user was an admin or an employee.

Solution:

Update our existing set of tooltips so that we have admin and employee specific tooltips that are more relevant to each user role.

  1. [ADD] Expense Report (filter type): 💡Welcome! Find all of your company's reports here.
    Action when clicked: Switches to the Report option on the LHN (screenshot below)
    Priority: 2000
    Conditions: role = Admin (in at least 1 workspace), the user is on the Reports tab and the nudgeMigration.timestamp is not null.
Image
  1. [UPDATE] Global Create: 💡 Create expenses, start chatting, and more. Try it out!
    Priority 1950 | Conditions: role = Employee (in at least 1 workspace), the user can see the global create icon.

  2. [UPDATE] Inbox tab: 💡Check what needs your attention and chat about expenses.
    Priority 1700
    Conditions: role = All, the user can see the bottom nav, hasn't been on the Inbox tab yet, and the nudgeMigration.timestamp is not null.

  3. [ADD] RBR/GBR chat: 💡You’ll see 🟢 on actions to take, and 🔴 on errors to review.
    Priority 1900
    Conditions: role = All, the user can see a chat with a green or red dot (RBR or GBR)

  4. [UPDATE] Workspace chat:💡Chat with approvers
    Priority 1800
    Conditions: role = Employee (in at least 1 workspace), the user is in the Inbox and sees their workspace chat (expense chat)

  5. [ADD] Account switcher/copilot access: 💡Access your copilot accounts here
    Priority 1600
    Conditions: role = All, when a user is or becomes a copilot for another account and navigates to Account/Settings page for the first time:

Image
  1. [ADD] Outstanding filter: 💡Filter for expenses that need approval
    Priority 1925
    Conditions: role = Admin, In Reports page, with either "Expenses" or "Expense Reports" selected

  2. [ADD] Settings tab: 💡Explore your workspace and account settings
    Priority 1750
    Conditions: role = Admin User is in the Inbox or Reports page

  3. [ADD] Workspaces tab: 💡View your workspaces
    Priority 1550
    Conditions: role = Admin User is on the Settings page

  4. [REMOVE] Concierge chat row and GBR: 💡 Get started here!

  5. [REMOVE] Create in the Workspace chat: 💡 Get started! Submit your expenses here!

  6. [REMOVE] QAB: 💡 Quick action! Just a tap away

  7. [REMOVE] Filter: 💡 Customize your search here!

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021896560139607289654
  • Upwork Job ID: 1896560139607289654
  • Last Price Increase: 2025-05-13
Issue OwnerCurrent Issue Owner: @rayane-d
@flaviadefaria flaviadefaria added the Daily KSv2 label Feb 18, 2025
@flaviadefaria flaviadefaria self-assigned this Feb 18, 2025
@melvin-bot melvin-bot bot added the Overdue label Feb 21, 2025
Copy link

melvin-bot bot commented Feb 24, 2025

@flaviadefaria Eep! 4 days overdue now. Issues have feelings too...

@flaviadefaria flaviadefaria moved this to Second Cohort - CRITICAL in [#whatsnext] #migrate Feb 25, 2025
Copy link

melvin-bot bot commented Feb 26, 2025

@flaviadefaria Still overdue 6 days?! Let's take care of this!

@flaviadefaria
Copy link
Contributor Author

This is almost ready to apply all the labels.

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Feb 26, 2025
@flaviadefaria flaviadefaria added the External Added to denote the issue can be worked on by a contributor label Mar 3, 2025
@melvin-bot melvin-bot bot changed the title Update Migrate tooltips [$250] Update Migrate tooltips Mar 3, 2025
Copy link

melvin-bot bot commented Mar 3, 2025

Job added to Upwork: https://www.upwork.com/jobs/~021896560139607289654

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Mar 3, 2025
@flaviadefaria flaviadefaria added NewFeature Something to build that is a new item. and removed Daily KSv2 Overdue labels Mar 3, 2025
Copy link

melvin-bot bot commented Mar 3, 2025

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eh2077 (External)

@melvin-bot melvin-bot bot added the Daily KSv2 label Mar 3, 2025
Copy link

melvin-bot bot commented Mar 3, 2025

Current assignee @flaviadefaria is eligible for the NewFeature assigner, not assigning anyone new.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Mar 3, 2025
@flaviadefaria flaviadefaria added Daily KSv2 and removed Weekly KSv2 labels Mar 3, 2025
@flaviadefaria
Copy link
Contributor Author

@eh2077 I will unassign you and assign @ishpaul777 as the C+ since he has good context around tooltips and will also be leading the implementation for Convert admin tooltips.

@flaviadefaria flaviadefaria assigned ishpaul777 and unassigned eh2077 Mar 3, 2025
@melvin-bot melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Mar 3, 2025
@melvin-bot melvin-bot bot added the Weekly KSv2 label May 1, 2025
@rayane-d
Copy link
Contributor

rayane-d commented May 1, 2025

Last PR is ready for review:

@rayane-d
Copy link
Contributor

rayane-d commented May 1, 2025

@flaviadefaria The remaining PRs, which are ready for review, add new tooltips. For now, if the user dismisses them, signs out, and signs in again, these tooltips show again. We need some backend changes so that the new tooltip dismissal persists in the backend. Is it okay to merge these new tooltips without the backend changes, ready so the team can evaluate them, or do we need to wait for an internal engineer to work on the backend changes?

@flaviadefaria
Copy link
Contributor Author

Let's merge them, but already create an issue to fix it so that an engineer can work on it asap.

@flaviadefaria
Copy link
Contributor Author

I created the GH and cc'ed you both - #61244
Now I'm going to check on an engineer that can take it on.

Copy link

melvin-bot bot commented May 2, 2025

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels May 6, 2025
@melvin-bot melvin-bot bot changed the title [$250] Update Migrate tooltips [Due for payment 2025-05-13] [$250] Update Migrate tooltips May 6, 2025
Copy link

melvin-bot bot commented May 6, 2025

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label May 6, 2025
Copy link

melvin-bot bot commented May 6, 2025

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.39-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-05-13. 🎊

For reference, here are some details about the assignees on this issue:

  • @rayane-d requires payment through NewDot Manual Requests
  • @ishpaul777 requires payment through NewDot Manual Requests

Copy link

melvin-bot bot commented May 6, 2025

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@rayane-d / @ishpaul777] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [@flaviadefaria] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

Copy link

melvin-bot bot commented May 8, 2025

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

Copy link

melvin-bot bot commented May 13, 2025

Payment Summary

Upwork Job

BugZero Checklist (@flaviadefaria)

  • I have verified the correct assignees and roles are listed above and updated the necessary manual offers
  • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1896560139607289654/hired)
  • I have paid out the Upwork contracts or cancelled the ones that are incorrect
  • I have verified the payment summary above is correct

@flaviadefaria flaviadefaria changed the title [Due for payment 2025-05-13] [$250] Update Migrate tooltips [Due for payment 2025-05-13] [$500] Update Migrate tooltips May 13, 2025
Copy link

melvin-bot bot commented May 13, 2025

Upwork job price has been updated to $500

@flaviadefaria
Copy link
Contributor Author

Payment Summary:

Reviewer: @rayane-d owed $500 via NewDot
Reviewer: @ishpaul777 owed $500 via NewDot

@flaviadefaria
Copy link
Contributor Author

@rayane-d can you please propose regression test steps? Thanks!

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels May 13, 2025
@melvin-bot melvin-bot bot changed the title [Due for payment 2025-05-13] [$500] Update Migrate tooltips [Due for payment 2025-05-20] [Due for payment 2025-05-13] [$500] Update Migrate tooltips May 13, 2025
Copy link

melvin-bot bot commented May 13, 2025

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.44-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-05-20. 🎊

For reference, here are some details about the assignees on this issue:

  • @rayane-d requires payment through NewDot Manual Requests
  • @ishpaul777 requires payment through NewDot Manual Requests

Copy link

melvin-bot bot commented May 13, 2025

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@rayane-d / @ishpaul777] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [@flaviadefaria] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

Copy link

melvin-bot bot commented May 20, 2025

Payment Summary

Upwork Job

BugZero Checklist (@flaviadefaria)

  • I have verified the correct assignees and roles are listed above and updated the necessary manual offers
  • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1896560139607289654/hired)
  • I have paid out the Upwork contracts or cancelled the ones that are incorrect
  • I have verified the payment summary above is correct

@flaviadefaria
Copy link
Contributor Author

I actually think we can skip a regression test for this one. We're likely to make some more adjustments to the tooltips as new product changes go live soon.

@flaviadefaria
Copy link
Contributor Author

Payment Summary

Contributor: @rayane-d owed $500 via NewDot
Reviewer: @ishpaul777 owed $500 via NewDot

@github-project-automation github-project-automation bot moved this from Second Cohort - CRITICAL to Done in [#whatsnext] #migrate May 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item. Weekly KSv2
Projects
Development

No branches or pull requests

5 participants