Update inbox tooltip and add expense report filter type tooltip #58721

rayane-d · 2025-03-19T14:41:22Z

Explanation of Change

[UPDATE] Inbox tab: 💡Check what needs your attention and chat about expenses.
Priority 1700
Conditions: role = All, the user can see the bottom nav, hasn't been on the Inbox tab yet, and the nudgeMigration.timestamp is not null.

[ADD] Expense Report (filter type): 💡Welcome! Find all of your company's reports here.
Action when clicked: Switches to the Report option on the LHN (screenshot below)
Priority: 2000
Conditions: role = Admin (in at least 1 workspace), the user is on the Reports tab and the nudgeMigration.timestamp is not null.

Fixed Issues

$ #57045

The changes for the issue are divided into multiple PRs, as outlined in this comment: #57045 (comment)

Tests

Test case 1:

Create a new account with "track my own expenses" intent (to not create a workspace)
Go to the reports page
Verify that the tooltip on the "expense reports" filter is not displayed
Verify that the tooltip on the inbox tab is not displayed
Create a workspace
Verify that the tooltip on the "expense reports" filter is not displayed

Test case 2:

Create an account on expensify.com (OldDot), choosing the 10+ employees option on signup, so that you are directed to Expensify Classic
In the browser console, run the following code snippet:

NVP.set('tryNewDot', {
    "classicRedirect": {
        "dismissed": "false",
        "timestamp": "2024-10-28 20:04:24.610"
    },
    "nudgeMigration": {
        "timestamp": "2024-10-28 20:04:24.610"
    }
})

Sign out and back in
You will get signed in to Expensify Classic
Click on the "Try New Expensify" button in the right panel
You will get re-directed to NewDot and see the modal
Dismiss the modal
Verify that the tooltip on the "expense reports" filter is displayed
On small screen, the tooltip on the "expense reports" filter should not be displayed
Verify that the tooltip on the inbox tab is displayed

Verify that no errors appear in the JS console

Offline tests

QA Steps

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2025-04-08T19:08:28Z

@ishpaul777 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

…igration-or-isUserPolicyEmployee

ishpaul777 · 2025-04-08T19:56:41Z

ping me when this ready : )

…igration-or-isUserPolicyEmployee

rayane-d · 2025-04-09T15:52:55Z

@ishpaul777 Do you know the correct Onyx command to migrate an account? Onyx.merge('nvp_tryNewDot', {nudgeMigration: {timestamp: Date.now()}}); Didn't work for me, the nvp_tryNewDot value seems to be initiated to an empty array.

ishpaul777 · 2025-04-09T15:58:00Z

Can you try this https://expensify.enterprise.slack.com/archives/C049HHMV9SM/p1741719835856779?thread_ts=1741288396.166429&channel=C049HHMV9SM&message_ts=1741719835.856779

rayane-d · 2025-04-09T16:13:42Z

This worked. Thanks!

ishpaul777 · 2025-04-11T18:39:51Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

ishpaul777 · 2025-04-14T22:14:57Z

src/languages/es.ts

i assume Translation confirmation needed

ishpaul777 · 2025-04-14T22:16:01Z

src/components/ProductTrainingContext/TOOLTIPS.ts

+        name: EXPENSE_REPORTS_FILTER,
+        priority: 2000,
+        shouldShow: ({shouldUseNarrowLayout, isUserPolicyAdmin, hasBeenAddedToNudgeMigration}: ShouldShowConditionProps) =>
+            !shouldUseNarrowLayout && isUserPolicyAdmin && hasBeenAddedToNudgeMigration,


lets confirm if we would like to show this on mobile or not

I followed the RENAME_SAVED_SEARCH tooltip, which is displayed in the same location and hidden in smaller layouts:

App/src/components/ProductTrainingContext/TOOLTIPS.ts

Lines 45 to 53 in f48ee32

[RENAME_SAVED_SEARCH]: {

content: [

{text: 'productTrainingTooltip.saveSearchTooltip.part1', isBold: true},

{text: 'productTrainingTooltip.saveSearchTooltip.part2', isBold: false},

],

onHideTooltip: (isDismissedUsingCloseButton = false) => dismissProductTraining(RENAME_SAVED_SEARCH, isDismissedUsingCloseButton),

name: RENAME_SAVED_SEARCH,

priority: 1250,

shouldShow: ({shouldUseNarrowLayout}) => !shouldUseNarrowLayout,

…igration-or-isUserPolicyEmployee

rayane-d · 2025-04-15T17:33:07Z

Asked for translations confirmation here: https://expensify.slack.com/archives/C01GTK53T8Q/p1744738354719109

shawnborton · 2025-04-21T08:02:35Z

We have some conflicts

github-actions · 2025-04-22T21:36:42Z

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

…edToNudgeMigration-or-isUserPolicyEmployee

rayane-d · 2025-04-23T16:31:06Z

@ishpaul777 This is ready for review

MarioExpensify

Nice, let's move forward!!

MarioExpensify · 2025-04-24T11:55:28Z

@rayane-d code is good, but it seems the PR is missing videos for most platforms, can you provide those before we move forward with merge?

…igration-or-isUserPolicyEmployee

rayane-d · 2025-04-25T11:45:02Z

@MarioExpensify Done!

MarioExpensify · 2025-04-25T17:00:54Z

Thank you @rayane-d, @Expensify/design can you take a look before we move forward?

dannymcclain · 2025-04-25T20:10:42Z

Screenshots look good to me!

kavimuru · 2025-04-28T20:00:33Z

@ishpaul777 @rayane-d could you help with the step?

"Migrate account"

What should we do here?

rayane-d · 2025-04-28T20:11:57Z

@kavimuru Here are the steps for migrating the account:

Create an account on expensify.com (OldDot), choosing the 10+ employees option on signup, so that you are directed to Expensify Classic
In the browser console, run the following code snippet:

NVP.set('tryNewDot', {
    "classicRedirect": {
        "dismissed": "false",
        "timestamp": "2024-10-28 20:04:24.610"
    },
    "nudgeMigration": {
        "timestamp": "2024-10-28 20:04:24.610"
    }
})

Sign out and back in
You will get signed in to Expensify Classic
Click on the "Try New Expensify" button in the right panel
You will get re-directed to NewDot and see the modal

github-actions · 2025-04-28T20:20:43Z

🚀 Deployed to staging by https://github.com/MarioExpensify in version: 9.1.33-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

github-actions · 2025-04-29T19:54:37Z

🚀 Deployed to staging by https://github.com/MarioExpensify in version: 9.1.35-1 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	failure ❌

github-actions · 2025-04-29T20:49:39Z

🚀 Deployed to staging by https://github.com/MarioExpensify in version: 9.1.36-3 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

github-actions · 2025-04-29T22:15:40Z

🚀 Deployed to staging by https://github.com/MarioExpensify in version: 9.1.37-1 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	cancelled 🔪
🍎 iOS 🍎	success ✅

github-actions · 2025-04-30T00:43:43Z

🚀 Deployed to production by https://github.com/thienlnam in version: 9.1.37-3 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	failure ❌

Update inbox tooltip and add expense report filter type tooltip

093e1d7

This was referenced Mar 19, 2025

[Due for payment 2025-05-20] [Due for payment 2025-05-13] [$500] Update Migrate tooltips #57045

Closed

Update Migrate tooltips #57927

Closed

rayane-d mentioned this pull request Apr 8, 2025

Add RBR/GBR chat and Account switcher tooltips #58540

Merged

50 tasks

rayane-d marked this pull request as ready for review April 8, 2025 19:08

rayane-d requested review from a team as code owners April 8, 2025 19:08

melvin-bot bot requested review from ishpaul777 and removed request for a team April 8, 2025 19:08

rayane-d marked this pull request as draft April 8, 2025 19:08

Merge branch 'main' into tooltips-that-depend-on-hasBeenAddedToNudgeM…

6371bba

…igration-or-isUserPolicyEmployee

rayane-d added 5 commits April 9, 2025 14:06

Merge branch 'main' into tooltips-that-depend-on-hasBeenAddedToNudgeM…

22ddf6f

…igration-or-isUserPolicyEmployee

prettier

1ba51c4

fix test

d982a3c

include user policy admin and migration in visibility conditions

cc3a2f5

fix test

99709ee

remove unnecessary test

8bf0355

rayane-d marked this pull request as ready for review April 9, 2025 16:13

ishpaul777 reviewed Apr 14, 2025

View reviewed changes

src/languages/es.ts Outdated

Copy link

Contributor

ishpaul777 Apr 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i assume Translation confirmation needed

rayane-d reacted with thumbs up emoji

ishpaul777 reviewed Apr 14, 2025

View reviewed changes

Merge branch 'main' into tooltips-that-depend-on-hasBeenAddedToNudgeM…

5bd135e

…igration-or-isUserPolicyEmployee

rayane-d requested a review from ishpaul777 April 23, 2025 14:41

rayane-d added 4 commits April 23, 2025 15:53

improve Spanish translations for expense reports filter

a7ddc82

fix formatting in expense reports filter translation

40e2118

Merge branch 'Expensify:main' into tooltips-that-depend-on-hasBeenAdd…

da0242e

…edToNudgeMigration-or-isUserPolicyEmployee

adjust line breaks

a203362

rayane-d mentioned this pull request Apr 23, 2025

Update Global Create and Workspace chat tooltips #58997

Merged

50 tasks

ishpaul777 approved these changes Apr 23, 2025

View reviewed changes

melvin-bot bot requested a review from MarioExpensify April 23, 2025 18:53

MarioExpensify previously approved these changes Apr 24, 2025

View reviewed changes

Merge branch 'main' into tooltips-that-depend-on-hasBeenAddedToNudgeM…

08e2195

…igration-or-isUserPolicyEmployee

rayane-d dismissed MarioExpensify’s stale review via 08e2195 April 25, 2025 11:44

rayane-d requested a review from MarioExpensify April 25, 2025 11:45

MarioExpensify approved these changes Apr 27, 2025

View reviewed changes

MarioExpensify merged commit 0b9bab2 into Expensify:main Apr 27, 2025
17 checks passed

rayane-d deleted the tooltips-that-depend-on-hasBeenAddedToNudgeMigration-or-isUserPolicyEmployee branch April 28, 2025 10:09

github-actions bot mentioned this pull request Apr 28, 2025

Deploy Checklist: New Expensify 2025-04-28 #60971

Closed

This was referenced Apr 29, 2025

Tooltip - Inbox tooltip is missing for new users #61074

Closed

[$250] Tooltip-Tooltip on the "expense reports" filter is not displayed #61099

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update inbox tooltip and add expense report filter type tooltip #58721

Update inbox tooltip and add expense report filter type tooltip #58721

rayane-d commented Mar 19, 2025 •

edited

Loading

melvin-bot bot commented Apr 8, 2025

ishpaul777 commented Apr 8, 2025

rayane-d commented Apr 9, 2025

ishpaul777 commented Apr 9, 2025

rayane-d commented Apr 9, 2025

ishpaul777 commented Apr 11, 2025 •

edited

Loading

ishpaul777 Apr 14, 2025

ishpaul777 Apr 14, 2025

rayane-d Apr 23, 2025

rayane-d commented Apr 15, 2025

shawnborton commented Apr 21, 2025

github-actions bot commented Apr 22, 2025

rayane-d commented Apr 23, 2025

MarioExpensify left a comment

MarioExpensify commented Apr 24, 2025

rayane-d commented Apr 25, 2025

MarioExpensify commented Apr 25, 2025

dannymcclain commented Apr 25, 2025

kavimuru commented Apr 28, 2025

rayane-d commented Apr 28, 2025

github-actions bot commented Apr 28, 2025

github-actions bot commented Apr 29, 2025

github-actions bot commented Apr 29, 2025

github-actions bot commented Apr 29, 2025

github-actions bot commented Apr 30, 2025

	[RENAME_SAVED_SEARCH]: {
	content: [
	{text: 'productTrainingTooltip.saveSearchTooltip.part1', isBold: true},
	{text: 'productTrainingTooltip.saveSearchTooltip.part2', isBold: false},
	],
	onHideTooltip: (isDismissedUsingCloseButton = false) => dismissProductTraining(RENAME_SAVED_SEARCH, isDismissedUsingCloseButton),
	name: RENAME_SAVED_SEARCH,
	priority: 1250,
	shouldShow: ({shouldUseNarrowLayout}) => !shouldUseNarrowLayout,

Update inbox tooltip and add expense report filter type tooltip #58721

Update inbox tooltip and add expense report filter type tooltip #58721

Conversation

rayane-d commented Mar 19, 2025 • edited Loading

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Apr 8, 2025

ishpaul777 commented Apr 8, 2025

rayane-d commented Apr 9, 2025

ishpaul777 commented Apr 9, 2025

rayane-d commented Apr 9, 2025

ishpaul777 commented Apr 11, 2025 • edited Loading

Reviewer Checklist

Screenshots/Videos

ishpaul777 Apr 14, 2025

Choose a reason for hiding this comment

ishpaul777 Apr 14, 2025

Choose a reason for hiding this comment

rayane-d Apr 23, 2025

Choose a reason for hiding this comment

rayane-d commented Apr 15, 2025

shawnborton commented Apr 21, 2025

github-actions bot commented Apr 22, 2025

rayane-d commented Apr 23, 2025

MarioExpensify left a comment

Choose a reason for hiding this comment

MarioExpensify commented Apr 24, 2025

rayane-d commented Apr 25, 2025

MarioExpensify commented Apr 25, 2025

dannymcclain commented Apr 25, 2025

kavimuru commented Apr 28, 2025

rayane-d commented Apr 28, 2025

github-actions bot commented Apr 28, 2025

github-actions bot commented Apr 29, 2025

github-actions bot commented Apr 29, 2025

github-actions bot commented Apr 29, 2025

github-actions bot commented Apr 30, 2025

rayane-d commented Mar 19, 2025 •

edited

Loading

ishpaul777 commented Apr 11, 2025 •

edited

Loading