-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Update Migrate tooltips #57927
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Migrate tooltips #57927
Conversation
@ishpaul777 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Hmm fair shout, @dannymcclain I think you worked on that particular tooltip - thoughts? |
I honestly don't have particularly strong feelings—I centered it to try to call attention to the up-down-arrows icon, but I'm now realizing that the name is variable so that icon won't always be in the same spot. Also, everything outlined in the screenshot below opens that menu: So the tooltip can really point to any part of that header (obviously minus the status button). @Expensify/design do y'all think this makes more sense? 👇 If we positioned it this way, it would always be pointing the "correct" thing. |
I could get down with that, and that definitely simplifies things re: position. I like it! |
Sounds good to me! @ishpaul777 Let's go ahead and update the tooltip to be positioned how I mocked up here. |
Thank you team! @rayane-d ^ task for you : ) |
@rayane-d when do you expect this PR will be ready for another round of reviews? |
Sorry for the delay. I will try to complete it today. |
Updated ![]() |
Looks good to me! |
Same! |
Reviewer Checklist
Screenshots/VideosAndroid: NativeAndroid: mWeb ChromeiOS: NativeiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
@rayane-d, what's the latest here? Can we aim to merge this week? |
@ishpaul777 can you jump in to review this? |
is this PR still relevant, i think we going to split the changes in small PR |
As I see, so should we close this PR to avoid further confusion? |
As discussed in Slack, We will divide this PR into smaller ones so we can avoid regressions and avoid the full revert:
|
@ishpaul777
Explanation of Change
Fixed Issues
$ #57045
PROPOSAL:
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop