Update Global Create and Workspace chat tooltips #58997

rayane-d · 2025-03-24T17:32:47Z

Explanation of Change

[UPDATE] Global Create: 💡 Create expenses, start chatting, and more. Try it out!
Priority 1950 | Conditions: role = Employee (in at least 1 workspace), the user can see the global create icon.

[UPDATE] Workspace chat::bulb:Chat with approvers
Priority 1800
Conditions: role = Employee (in at least 1 workspace), the user is in the Inbox and sees their workspace chat (expense chat)

Fixed Issues

$ #57045

The changes for the issue are divided into multiple PRs, as outlined in this comment: #57045 (comment)

Tests

Create a new account
Verify that the "Global create", and the "workspace chat" tooltips do not show when the user does not have any workspace or is an admin of some workspaces but is not an employee member of some workspaces.
Login with another account, create a workspace, and invite the first user as a member
Verify that the "Global create", and the "workspace chat" tooltips show up for the first user.
Verify that no errors appear in the JS console

Offline tests

QA Steps

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screen.Recording.2025-04-09.at.6.35.51.PM.mov

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

…tips

melvin-bot · 2025-04-09T17:47:31Z

@ishpaul777 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ishpaul777 · 2025-04-09T19:37:06Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2025-04-12.at.1.11.46.AM.mov

Android: mWeb Chrome

Screen.Recording.2025-04-12.at.1.14.07.AM.mov

iOS: Native

Screen.Recording.2025-04-12.at.12.56.28.AM.mov

iOS: mWeb Safari

Screen.Recording.2025-04-12.at.12.51.32.AM.mov

MacOS: Chrome / Safari

Screen.Recording.2025-04-12.at.12.25.05.AM.mov

MacOS: Desktop

Screen.Recording.2025-04-12.at.1.21.37.AM.mov

ishpaul777 · 2025-04-09T20:33:06Z

src/components/ProductTrainingContext/TOOLTIPS.ts

-        priority: 1200,
-        shouldShow: () => true,
+        priority: 1950,
+        shouldShow: ({isUserPolicyEmployee}) => isUserPolicyEmployee,
    },
    [BOTTOM_NAV_INBOX_TOOLTIP]: {


lets update this one also

oh i see its done on other PR, nvm!

ishpaul777 · 2025-04-09T20:33:26Z

src/languages/es.ts

        },
        globalCreateTooltip: {
            part1: 'Crea gastos',
            part2: ', comienza a chatear,',
            part3: '\ny mucho más!',
+            part4: ' ¡Pruébalo!',
        },


Transalations confirmed in slack?

ishpaul777 · 2025-04-11T18:40:31Z

@rayane-d bump on translation confirmation rest LGTM!

…tips

rayane-d · 2025-04-15T17:33:24Z

Asked for translations confirmation here: https://expensify.slack.com/archives/C01GTK53T8Q/p1744738354719109

ishpaul777 · 2025-04-22T18:51:30Z

just checkin in for updates @rayane-d

rayane-d · 2025-04-22T22:09:38Z

Provided context screenshots for translation confirmation in Slack

…-chat-tooltips

…tips

ishpaul777 · 2025-04-23T16:25:48Z

@rayane-d we have some errors in checks

…-chat-tooltips

rayane-d · 2025-04-23T16:33:01Z

@rayane-d we have some errors in checks

Changed files ESLint check errors for src/components/ProductTrainingContext/index.tsx are fixed in PR #58721

rayane-d · 2025-04-23T19:04:24Z

This is ready for another review

MarioExpensify · 2025-04-27T21:05:42Z

@rayane-d #58721 has just been merged, can you merge main here so we have the tests passing?

…tips

…-chat-tooltips

rayane-d · 2025-04-28T10:53:41Z

@MarioExpensify - Done!

MarioExpensify

Awesome, let's move forward with merge!

MarioExpensify · 2025-04-28T18:51:43Z

@rayane-d before merging, please add the screenshots / videos for all platforms so we have it documented here.

ishpaul777 · 2025-04-30T12:21:14Z

@rayane-d gentle bump

…-chat-tooltips

rayane-d · 2025-04-30T15:41:39Z

I added all screenshots except the iOS native one. I can't log in to the app right now; I will try again later.

MarioExpensify · 2025-04-30T20:28:32Z

Okay @rayane-d, please add the screenshot when you have it. For now, we have the video in @ishpaul777's checklist so we can move forward.

OSBotify · 2025-04-30T20:37:17Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-05-01T20:06:37Z

🚀 Deployed to staging by https://github.com/MarioExpensify in version: 9.1.39-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

github-actions · 2025-05-06T01:04:30Z

🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.1.39-8 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

Update Global Create and Workspace chat tooltips

23558c5

This was referenced Mar 24, 2025

[Due for payment 2025-05-20] [Due for payment 2025-05-13] [$500] Update Migrate tooltips #57045

Open

Update Migrate tooltips #57927

Closed

rayane-d added 5 commits April 9, 2025 18:14

Merge branch 'main' into Update-Global-Create-and-Workspace-chat-tool…

9a44f6c

…tips

Add user policy employee check to tooltips visibility logic

519706a

Add fourth part to global create tooltip text

447377c

prettier

f1655f7

fix tests

5348699

rayane-d marked this pull request as ready for review April 9, 2025 17:47

rayane-d requested a review from a team as a code owner April 9, 2025 17:47

melvin-bot bot requested review from ishpaul777 and removed request for a team April 9, 2025 17:47

ishpaul777 reviewed Apr 9, 2025

View reviewed changes

Merge branch 'main' into Update-Global-Create-and-Workspace-chat-tool…

979daae

…tips

rayane-d added 3 commits April 22, 2025 23:09

Merge branch 'Expensify:main' into Update-Global-Create-and-Workspace…

fa4f3db

…-chat-tooltips

update translations

ba5f7df

Merge branch 'main' into Update-Global-Create-and-Workspace-chat-tool…

73885b4

…tips

Merge branch 'Expensify:main' into Update-Global-Create-and-Workspace…

4b9d1d8

…-chat-tooltips

rayane-d requested a review from ishpaul777 April 23, 2025 19:03

ishpaul777 approved these changes Apr 25, 2025

View reviewed changes

melvin-bot bot requested a review from MarioExpensify April 25, 2025 20:10

rayane-d added 5 commits April 27, 2025 23:19

Merge branch 'main' into Update-Global-Create-and-Workspace-chat-tool…

9d72986

…tips

Merge branch 'Expensify:main' into Update-Global-Create-and-Workspace…

1e72b97

…-chat-tooltips

fix test

afd7320

fix test

d4e1294

Fix test

8c42584

MarioExpensify approved these changes Apr 28, 2025

View reviewed changes

Merge branch 'Expensify:main' into Update-Global-Create-and-Workspace…

853bc2d

…-chat-tooltips

MarioExpensify merged commit ec1dd0c into Expensify:main Apr 30, 2025
16 checks passed

github-actions bot mentioned this pull request May 1, 2025

Deploy Checklist: New Expensify 2025-05-01 #61263

Closed

61 tasks

mitarachim mentioned this pull request May 2, 2025

[Due for payment 2025-05-14] [Due for payment 2025-05-13] Tooltips - Workspace chat tooltip not displayed when invited to workspace #61295

Closed

8 tasks

rayane-d deleted the Update-Global-Create-and-Workspace-chat-tooltips branch May 6, 2025 11:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update Global Create and Workspace chat tooltips #58997

Update Global Create and Workspace chat tooltips #58997

rayane-d commented Mar 24, 2025 •

edited

Loading

melvin-bot bot commented Apr 9, 2025

ishpaul777 commented Apr 9, 2025 •

edited

Loading

ishpaul777 Apr 9, 2025

ishpaul777 Apr 11, 2025

ishpaul777 Apr 9, 2025

ishpaul777 commented Apr 11, 2025 •

edited

Loading

rayane-d commented Apr 15, 2025

ishpaul777 commented Apr 22, 2025 •

edited

Loading

rayane-d commented Apr 22, 2025

ishpaul777 commented Apr 23, 2025 •

edited

Loading

rayane-d commented Apr 23, 2025

rayane-d commented Apr 23, 2025

MarioExpensify commented Apr 27, 2025

rayane-d commented Apr 28, 2025 •

edited

Loading

MarioExpensify left a comment

MarioExpensify commented Apr 28, 2025

ishpaul777 commented Apr 30, 2025

rayane-d commented Apr 30, 2025

MarioExpensify commented Apr 30, 2025

OSBotify commented Apr 30, 2025

github-actions bot commented May 1, 2025

github-actions bot commented May 6, 2025

Update Global Create and Workspace chat tooltips #58997

Update Global Create and Workspace chat tooltips #58997

Conversation

rayane-d commented Mar 24, 2025 • edited Loading

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Apr 9, 2025

ishpaul777 commented Apr 9, 2025 • edited Loading

Reviewer Checklist

Screenshots/Videos

ishpaul777 Apr 9, 2025

Choose a reason for hiding this comment

ishpaul777 Apr 11, 2025

Choose a reason for hiding this comment

ishpaul777 Apr 9, 2025

Choose a reason for hiding this comment

ishpaul777 commented Apr 11, 2025 • edited Loading

rayane-d commented Apr 15, 2025

ishpaul777 commented Apr 22, 2025 • edited Loading

rayane-d commented Apr 22, 2025

ishpaul777 commented Apr 23, 2025 • edited Loading

rayane-d commented Apr 23, 2025

rayane-d commented Apr 23, 2025

MarioExpensify commented Apr 27, 2025

rayane-d commented Apr 28, 2025 • edited Loading

MarioExpensify left a comment

Choose a reason for hiding this comment

MarioExpensify commented Apr 28, 2025

ishpaul777 commented Apr 30, 2025

rayane-d commented Apr 30, 2025

MarioExpensify commented Apr 30, 2025

OSBotify commented Apr 30, 2025

github-actions bot commented May 1, 2025

github-actions bot commented May 6, 2025

rayane-d commented Mar 24, 2025 •

edited

Loading

ishpaul777 commented Apr 9, 2025 •

edited

Loading

ishpaul777 commented Apr 11, 2025 •

edited

Loading

ishpaul777 commented Apr 22, 2025 •

edited

Loading

ishpaul777 commented Apr 23, 2025 •

edited

Loading

rayane-d commented Apr 28, 2025 •

edited

Loading