fix(onboarding): update plan when integration is selected #60551

jaydamani · 2025-04-20T21:12:18Z

Explanation of Change

Fixed Issues

$ #59473
PROPOSAL: #59473 (comment)

Tests

Open app
Sign up
Tap on 'Manage my team's expenses' > '1-10 employees' > 'QuickBooks Desktop' > 'Continue'
Tap on 'Settings > 'Workspaces'
Verify the workspace has Control plan

Verify that no errors appear in the JS console

Offline tests

Same as tests

QA Steps

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

onboarding-a.mp4

Android: mWeb Chrome

android.webm.mp4

iOS: Native

ios-onboarding.mp4

iOS: mWeb Safari

Simulator.Screen.Recording.-.iPhone.16.Pro.-.2025-04-20.at.23.05.57.mp4

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

melvin-bot · 2025-04-20T21:12:23Z

@eVoloshchak Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

jaydamani · 2025-04-25T15:13:21Z

@eVoloshchak minor bump

eVoloshchak · 2025-04-27T15:08:04Z

src/libs/ReportUtils.ts

@@ -9989,11 +9989,18 @@ function prepareOnboardingOnyxData(
    }

    if (userReportedIntegration) {
+        const requiresCorporatPlan: OnboardingAccounting[] = [CONST.POLICY.CONNECTIONS.NAME.NETSUITE, CONST.POLICY.CONNECTIONS.NAME.QBD, CONST.POLICY.CONNECTIONS.NAME.SAGE_INTACCT];


Suggested change

const requiresCorporatPlan: OnboardingAccounting[] = [CONST.POLICY.CONNECTIONS.NAME.NETSUITE, CONST.POLICY.CONNECTIONS.NAME.QBD, CONST.POLICY.CONNECTIONS.NAME.SAGE_INTACCT];

const requiresControlPlan: OnboardingAccounting[] = [CONST.POLICY.CONNECTIONS.NAME.NETSUITE, CONST.POLICY.CONNECTIONS.NAME.QBD, CONST.POLICY.CONNECTIONS.NAME.SAGE_INTACCT];

Should we use AllConnections instead?

@eVoloshchak I have updated, please review again

@jaydamani, can we use AllConnections instead of manually listing the connections?

@eVoloshchak Not sure if I follow but allConnections is a type and we need to check on runtime so we need the values as array/object. Also I think allConnections is like interface/type for data after the connection is enabled so it does not have any information about the plan required to enable a configuration.

eVoloshchak · 2025-04-27T15:10:22Z

Could you also add the screen recordings for native platforms, please?

…ng/updte-plan-for-integrations

jaydamani · 2025-04-27T22:35:22Z

Could you also add the screen recordings for native platforms, please?

Done

eVoloshchak · 2025-04-29T19:43:15Z

Also, could you pull the latest main please? There seems to be an issue with GH checks

…ng/updte-plan-for-integrations

eVoloshchak · 2025-05-04T18:35:24Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2025-05-07.at.22.09.31.mov

Android: mWeb Chrome

Screen.Recording.2025-05-04.at.20.53.19.mov

iOS: HybridApp

Screen.Recording.2025-05-07.at.22.19.18.mov

iOS: mWeb Safari

Screen.Recording.2025-05-04.at.20.48.54.mov

MacOS: Chrome / Safari

Screen.Recording.2025-05-04.at.20.40.59.mov

MacOS: Desktop

Screen.Recording.2025-05-07.at.22.24.15.mov

eVoloshchak · 2025-05-07T08:37:08Z

Still experiencing problems building HybridApp (iOS and Android), expect an update later today

eVoloshchak

LGTM!

OSBotify · 2025-05-07T20:40:38Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-05-08T00:16:07Z

🚀 Deployed to staging by https://github.com/blimpich in version: 9.1.42-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

github-actions · 2025-05-09T09:26:35Z

🚀 Deployed to staging by https://github.com/blimpich in version: 9.1.43-5 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	failure ❌

github-actions · 2025-05-13T17:52:18Z

🚀 Deployed to production by https://github.com/francoisl in version: 9.1.44-8 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

fix(onboarding): update plan when integration is selected

b64a856

jaydamani requested a review from a team as a code owner April 20, 2025 21:12

melvin-bot bot requested a review from eVoloshchak April 20, 2025 21:12

melvin-bot bot removed the request for review from a team April 20, 2025 21:12

jaydamani changed the title ~~fix(onboarding): update plan when integration is selected~~ [Hold] fix(onboarding): update plan when integration is selected Apr 20, 2025

jaydamani mentioned this pull request Apr 20, 2025

[Due for payment 2025-05-20] [$250] Workspaces - 'Collect' plan is displayed instead of 'Control' #59473

Closed

8 tasks

blimpich assigned jaydamani Apr 23, 2025

jaydamani changed the title ~~[Hold] fix(onboarding): update plan when integration is selected~~ fix(onboarding): update plan when integration is selected Apr 25, 2025

eVoloshchak suggested changes Apr 27, 2025

View reviewed changes

jaydamani added 2 commits April 27, 2025 20:33

review changes

b514dae

Merge branch 'main' of https://github.com/expensify/app into onboardi…

383807d

…ng/updte-plan-for-integrations

Merge branch 'main' of https://github.com/expensify/app into onboardi…

19cdf34

…ng/updte-plan-for-integrations

eVoloshchak approved these changes May 7, 2025

View reviewed changes

melvin-bot bot requested a review from blimpich May 7, 2025 20:26

blimpich approved these changes May 7, 2025

View reviewed changes

blimpich merged commit 1915bd6 into Expensify:main May 7, 2025
17 checks passed

github-actions bot mentioned this pull request May 7, 2025

Deploy Checklist: New Expensify 2025-05-07 #61626

Closed

90 tasks

	const requiresCorporatPlan: OnboardingAccounting[] = [CONST.POLICY.CONNECTIONS.NAME.NETSUITE, CONST.POLICY.CONNECTIONS.NAME.QBD, CONST.POLICY.CONNECTIONS.NAME.SAGE_INTACCT];
	const requiresControlPlan: OnboardingAccounting[] = [CONST.POLICY.CONNECTIONS.NAME.NETSUITE, CONST.POLICY.CONNECTIONS.NAME.QBD, CONST.POLICY.CONNECTIONS.NAME.SAGE_INTACCT];

fix(onboarding): update plan when integration is selected #60551

fix(onboarding): update plan when integration is selected #60551

Uh oh!

Conversation

jaydamani commented Apr 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Apr 20, 2025

Uh oh!

jaydamani commented Apr 25, 2025

Uh oh!

eVoloshchak Apr 27, 2025

Choose a reason for hiding this comment

Uh oh!

eVoloshchak Apr 27, 2025

Choose a reason for hiding this comment

Uh oh!

jaydamani Apr 27, 2025

Choose a reason for hiding this comment

Uh oh!

eVoloshchak Apr 29, 2025

Choose a reason for hiding this comment

Uh oh!

jaydamani Apr 29, 2025

Choose a reason for hiding this comment

Uh oh!

eVoloshchak commented Apr 27, 2025

Uh oh!

jaydamani commented Apr 27, 2025

Uh oh!

eVoloshchak commented Apr 29, 2025

Uh oh!

eVoloshchak commented May 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

eVoloshchak commented May 7, 2025

Uh oh!

eVoloshchak left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented May 7, 2025

Uh oh!

github-actions bot commented May 8, 2025

Uh oh!

github-actions bot commented May 9, 2025

Uh oh!

github-actions bot commented May 13, 2025

Uh oh!

Uh oh!

jaydamani commented Apr 20, 2025 •

edited

Loading

eVoloshchak commented May 4, 2025 •

edited

Loading