Skip to content

chat-Claim offer banner in concierge page is not centred. #61662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
2 of 8 tasks
mitarachim opened this issue May 8, 2025 · 12 comments
Open
2 of 8 tasks

chat-Claim offer banner in concierge page is not centred. #61662

mitarachim opened this issue May 8, 2025 · 12 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Reviewing Has a PR in review Weekly KSv2

Comments

@mitarachim
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: V9.1.42-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail: N/a
Email or phone of affected tester (no customers): Slottwo1 [email protected]
Issue reported by: Applause Internal Team
Device used: Redminote note 10s android 13
App Component: Other

Action Performed:

  1. Launch app
  2. Login with gmail account
  3. Complete onboarding via track and budget expenses
  4. Create a workspace
  5. Tap overview and change it to control workspace
  6. Go to concierge & note claim offer banner

Expected Result:

Claim offer banner in concierge page must be centred.

Actual Result:

Claim offer banner in concierge page is not centred.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Image

Bug6825283_1746688711721.Screenrecorder-2025-05-08-12-47-34-26.mp4

View all open jobs on GitHub

@mitarachim mitarachim added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. DeployBlocker Indicates it should block deploying the API labels May 8, 2025
Copy link

melvin-bot bot commented May 8, 2025

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented May 8, 2025

Triggered auto assignment to @NikkiWines (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented May 8, 2025

💬 A slack conversation has been started in #expensify-open-source

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels May 8, 2025
Copy link
Contributor

github-actions bot commented May 8, 2025

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@nabi-ebrahimi
Copy link
Contributor

Couldn't reproduce the problem!

@NikkiWines
Copy link
Contributor

I was able to reproduce this on dev

Screen.Recording.2025-05-08.at.11.16.59.mov

@NikkiWines
Copy link
Contributor

Discussion here

@NikkiWines NikkiWines removed the DeployBlocker Indicates it should block deploying the API label May 8, 2025
@NikkiWines
Copy link
Contributor

App only blocker

@samranahm
Copy link
Contributor

@NikkiWines I was author of offending PR and found the root cause, do i need assignment here to open a PR

@NikkiWines
Copy link
Contributor

@samranahm I don't believe you need to be assigned but i'll add ya anyway.

Note: This bug is a regression from #61267

@hungvu193
Copy link
Contributor

Any ETA for the PR? @samranahm

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Hourly KSv2 labels May 8, 2025
@samranahm
Copy link
Contributor

@hungvu193 PR ready

@yuwenmemon yuwenmemon removed the DeployBlockerCash This issue or pull request should block deployment label May 8, 2025
@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels May 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Reviewing Has a PR in review Weekly KSv2
Projects
None yet
Development

No branches or pull requests

7 participants