fix: Onboarding - Onboarding tasks in #admins room are grayed out in offline mode. #60973

Krishna2323 · 2025-04-28T20:05:02Z

Explanation of Change

Fixed Issues

$ #60833
PROPOSAL: #60833 (comment)

Tests

Log in with a new Gmail account
Click Skip on Work email step
Select Manage my team's expenses
Select 1-10 employees
Select any accounting > Continue
Go to #admins
Send a message
Wait for a while
Go offline
Verify the message starting with Here is a task list I’d recommend for a company of your size is not greyed out
Verify the tasks are not greyed out
Verify the message starting with We can explore more features such is not greyed out

Verify that no errors appear in the JS console

Offline tests

Internet connection is required

QA Steps

Log in with a new Gmail account
Click Skip on Work email step
Select Manage my team's expenses
Select 1-10 employees
Select any accounting > Continue
Go to #admins
Send a message
Wait for a while
Go offline
Verify the message starting with Here is a task list I’d recommend for a company of your size is not greyed out
Verify the tasks are not greyed out
Verify the message starting with We can explore more features such is not greyed out

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android_native.mp4

Android: mWeb Chrome

android_chrome.mp4

iOS: Native

ios_native.mp4

iOS: mWeb Safari

ios_safari.mp4

MacOS: Chrome / Safari

web_chrome.mp4

MacOS: Desktop

desktop_app.mp4

…offline mode. Signed-off-by: krishna2323 <[email protected]>

Signed-off-by: krishna2323 <[email protected]>

Krishna2323 · 2025-04-28T20:05:30Z

Will upload the recordings in the morning.

melvin-bot · 2025-04-29T21:12:24Z

@jayeshmangwani Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

jayeshmangwani · 2025-05-01T06:12:50Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android.mp4

Android: mWeb Chrome

mweb-chrome.mov

iOS: HybridApp

iOS.mov

iOS: mWeb Safari

mweb-safari.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

jayeshmangwani · 2025-05-01T06:14:50Z

@Krishna2323 Can we add a test for the completeOnboarding API here and verify that isOptimisticAction is null and the tasks isn’t greyed out?

jayeshmangwani · 2025-05-03T04:47:51Z

@Krishna2323 bump for the above comment

Signed-off-by: krishna2323 <[email protected]>

Krishna2323 · 2025-05-03T18:01:46Z

@jayeshmangwani, test added.

jayeshmangwani · 2025-05-04T06:53:19Z

tests/unit/onboardingApiTest.ts

+import waitForBatchedUpdates from '../utils/waitForBatchedUpdates';
+
+const ESH_EMAIL = '[email protected]';
+const ESH_ACCOUNT_ID = 1;


@Krishna2323 Either you've used your own details here instead of another contributor's, or you can use a placeholder like TEST_USER_ACCOUNT_ID.

Instead of creating a new test file named onboardingApiTest, what do you think about adding the test directly under tests/actions/ReportTest.ts, since we're only testing completeOnboarding as part of the Report actions?

Yes, agreed. I have added the completeOnboarding test inside tests/actions/ReportTest.ts and removed the file onboardingApiTest.

jayeshmangwani · 2025-05-04T07:26:07Z

tests/unit/onboardingApiTest.ts

+
+            const adminsChatReportID = '7957055873634067';
+            const onboardingPolicyID = 'A70D00C752416807';
+


Suggested change

const engagementChoice = CONST.INTRO_CHOICES.MANAGE_TEAM;

Report.completeOnboarding({

engagementChoice,

onboardingMessage: CONST.ONBOARDING_MESSAGES[engagementChoice],

adminsChatReportID,

onboardingPolicyID,

companySize: CONST.ONBOARDING_COMPANY_SIZE.MICRO,

userReportedIntegration: null,

});

Signed-off-by: krishna2323 <[email protected]>

jayeshmangwani · 2025-05-06T06:56:27Z

tests/actions/ReportTest.ts

+
+            Report.completeOnboarding({
+                engagementChoice,
+                onboardingMessage: CONST.ONBOARDING_MESSAGES.newDotManageTeam,


Suggested change

onboardingMessage: CONST.ONBOARDING_MESSAGES.newDotManageTeam,

onboardingMessage: CONST.ONBOARDING_MESSAGES[engagementChoice],

jayeshmangwani · 2025-05-06T06:56:47Z

tests/actions/ReportTest.ts

+                onboardingMessage: CONST.ONBOARDING_MESSAGES.newDotManageTeam,
+                adminsChatReportID,
+                onboardingPolicyID,
+                companySize: '1-10',


Suggested change

companySize: '1-10',

companySize: CONST.ONBOARDING_COMPANY_SIZE.MICRO,

sorry for overlooking. Updated.

Signed-off-by: krishna2323 <[email protected]>

jayeshmangwani · 2025-05-06T07:43:49Z

@Krishna2323 Please merge main and push the changes to resolve the failing Tests.

jayeshmangwani

LGTM 🚀

yuwenmemon · 2025-05-06T17:08:59Z

@Krishna2323 You might need to pull main to update the unit tests.

OSBotify · 2025-05-07T00:45:32Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-05-08T00:16:28Z

🚀 Deployed to staging by https://github.com/yuwenmemon in version: 9.1.42-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

github-actions · 2025-05-09T09:26:56Z

🚀 Deployed to staging by https://github.com/yuwenmemon in version: 9.1.43-5 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	failure ❌

github-actions · 2025-05-13T17:52:39Z

🚀 Deployed to production by https://github.com/francoisl in version: 9.1.44-8 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

Krishna2323 added 2 commits April 29, 2025 01:23

fix: Onboarding - Onboarding tasks in #admins room are grayed out in …

6f25a75

…offline mode. Signed-off-by: krishna2323 <[email protected]>

minor update.

1bc6d68

Signed-off-by: krishna2323 <[email protected]>

Merge branch 'Expensify:main' into krishna2323/issue/60833

35be4b5

Krishna2323 marked this pull request as ready for review April 29, 2025 21:12

Krishna2323 requested a review from a team as a code owner April 29, 2025 21:12

melvin-bot bot requested review from jayeshmangwani and removed request for a team April 29, 2025 21:12

Krishna2323 mentioned this pull request Apr 29, 2025

[Due for payment 2025-05-20] [$250] Onboarding - Onboarding tasks in #admins room are grayed out in offline mode #60833

Closed

18 tasks

Krishna2323 added 2 commits May 3, 2025 15:18

add tests for 'completeOnboarding' api.

29c8e97

Signed-off-by: krishna2323 <[email protected]>

Merge branch 'Expensify:main' into krishna2323/issue/60833

4b37f46

jayeshmangwani reviewed May 4, 2025

View reviewed changes

add completeOnboarding in ReportTest.ts.

3c3e8ca

Signed-off-by: krishna2323 <[email protected]>

jayeshmangwani reviewed May 6, 2025

View reviewed changes

minor update.

2ba5339

Signed-off-by: krishna2323 <[email protected]>

jayeshmangwani approved these changes May 6, 2025

View reviewed changes

melvin-bot bot requested a review from yuwenmemon May 6, 2025 07:44

Merge branch 'Expensify:main' into krishna2323/issue/60833

6e349d3

yuwenmemon approved these changes May 7, 2025

View reviewed changes

yuwenmemon merged commit 32dde8a into Expensify:main May 7, 2025
17 checks passed

github-actions bot mentioned this pull request May 7, 2025

Deploy Checklist: New Expensify 2025-05-07 #61626

Closed

90 tasks


		const adminsChatReportID = '7957055873634067';
		const onboardingPolicyID = 'A70D00C752416807';

	onboardingMessage: CONST.ONBOARDING_MESSAGES.newDotManageTeam,
	onboardingMessage: CONST.ONBOARDING_MESSAGES[engagementChoice],

	companySize: '1-10',
	companySize: CONST.ONBOARDING_COMPANY_SIZE.MICRO,

fix: Onboarding - Onboarding tasks in #admins room are grayed out in offline mode. #60973

fix: Onboarding - Onboarding tasks in #admins room are grayed out in offline mode. #60973

Uh oh!

Conversation

Krishna2323 commented Apr 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

Krishna2323 commented Apr 28, 2025

Uh oh!

melvin-bot bot commented Apr 29, 2025

Uh oh!

jayeshmangwani commented May 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

jayeshmangwani commented May 1, 2025

Uh oh!

jayeshmangwani commented May 3, 2025

Uh oh!

Krishna2323 commented May 3, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jayeshmangwani commented May 6, 2025

Uh oh!

jayeshmangwani left a comment

Choose a reason for hiding this comment

Uh oh!

yuwenmemon commented May 6, 2025

Uh oh!

Uh oh!

OSBotify commented May 7, 2025

Uh oh!

github-actions bot commented May 8, 2025

Uh oh!

github-actions bot commented May 9, 2025

Uh oh!

github-actions bot commented May 13, 2025

Uh oh!

Uh oh!

Krishna2323 commented Apr 28, 2025 •

edited

Loading

jayeshmangwani commented May 1, 2025 •

edited

Loading