-
Notifications
You must be signed in to change notification settings - Fork 3.2k
fix: Onboarding - Onboarding tasks in #admins room are grayed out in offline mode. #60973
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
yuwenmemon
merged 8 commits into
Expensify:main
from
Krishna2323:krishna2323/issue/60833
May 7, 2025
Merged
Changes from 6 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
6f25a75
fix: Onboarding - Onboarding tasks in #admins room are grayed out in …
Krishna2323 1bc6d68
minor update.
Krishna2323 35be4b5
Merge branch 'Expensify:main' into krishna2323/issue/60833
Krishna2323 29c8e97
add tests for 'completeOnboarding' api.
Krishna2323 4b37f46
Merge branch 'Expensify:main' into krishna2323/issue/60833
Krishna2323 3c3e8ca
add completeOnboarding in ReportTest.ts.
Krishna2323 2ba5339
minor update.
Krishna2323 6e349d3
Merge branch 'Expensify:main' into krishna2323/issue/60833
Krishna2323 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -68,6 +68,7 @@ describe('actions/Report', () => { | |||||
beforeEach(() => { | ||||||
HttpUtils.xhr = originalXHR; | ||||||
const promise = Onyx.clear().then(jest.useRealTimers); | ||||||
|
||||||
if (getIsUsingFakeTimers()) { | ||||||
// flushing pending timers | ||||||
// Onyx.clear() promise is resolved in batch which happens after the current microtasks cycle | ||||||
|
@@ -1606,4 +1607,45 @@ describe('actions/Report', () => { | |||||
expect(derivedConciergeChatReportID).toBe(conciergeChatReport2.reportID); | ||||||
}); | ||||||
}); | ||||||
|
||||||
describe('completeOnboarding', () => { | ||||||
const TEST_USER_LOGIN = '[email protected]'; | ||||||
const TEST_USER_ACCOUNT_ID = 1; | ||||||
global.fetch = TestHelper.getGlobalFetchMock(); | ||||||
|
||||||
it('should set "isOptimisticAction" to false/null for all actions in admins report after completing onboarding setup', async () => { | ||||||
await Onyx.set(ONYXKEYS.SESSION, {email: TEST_USER_LOGIN, accountID: TEST_USER_ACCOUNT_ID}); | ||||||
await waitForBatchedUpdates(); | ||||||
|
||||||
const adminsChatReportID = '7957055873634067'; | ||||||
const onboardingPolicyID = 'A70D00C752416807'; | ||||||
const engagementChoice = CONST.INTRO_CHOICES.MANAGE_TEAM; | ||||||
|
||||||
Report.completeOnboarding({ | ||||||
engagementChoice, | ||||||
onboardingMessage: CONST.ONBOARDING_MESSAGES.newDotManageTeam, | ||||||
adminsChatReportID, | ||||||
onboardingPolicyID, | ||||||
companySize: '1-10', | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. sorry for overlooking. Updated. |
||||||
userReportedIntegration: null, | ||||||
}); | ||||||
|
||||||
await waitForBatchedUpdates(); | ||||||
|
||||||
const reportActions: OnyxEntry<OnyxTypes.ReportActions> = await new Promise((resolve) => { | ||||||
const connection = Onyx.connect({ | ||||||
key: `${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${adminsChatReportID}`, | ||||||
callback: (id) => { | ||||||
Onyx.disconnect(connection); | ||||||
resolve(id); | ||||||
}, | ||||||
}); | ||||||
}); | ||||||
expect(reportActions).not.toBeNull(); | ||||||
expect(reportActions).not.toBeUndefined(); | ||||||
Object.values(reportActions ?? {}).forEach((action) => { | ||||||
expect(action.isOptimisticAction).toBeFalsy(); | ||||||
}); | ||||||
}); | ||||||
}); | ||||||
}); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.