-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Add Call Scheduling page for users #59951
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Call Scheduling page for users #59951
Conversation
Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers! |
I will add screenshots in some time. Doing some cleanup. We can start reviewing the code and functionality now. |
@parasharrajat Do I need access to the design doc for this?
Also are you simulating this step, or do we have to spam a real guide? 😄 |
Don't submit the event on the final screen otherwise you can work with it. Yes, get access to design doc, I have added the front-end logic which is outdated but outlines the same approach as this PR. @jjcoffee |
Do you know whether we should translate the dates to Spanish as well? Like |
@parasharrajat Hmm good question, I guess ideally yes as we do this in the date picker. |
Do you know which functions I can use to do this? |
Sure, That is what I have done. Thanks |
That feels right to me too |
IMO this makes sense to do, since it does feel a bit weird that when you return from calendly that there's no visual feedback in-app that anything happened. Curious what @MonilBhavsar thinks, though! |
Sounds good 👍 |
Hardcoded flag...we will remove that in next PR. |
Can we have it in such a way that it can allow us to test the feature. May be by visiting the route directly |
Yeah, you can visit the route directly to open the flow. |
Sounds good 👍 |
@shawnborton, unfortuantely calendly does not allow us to schedule an event using API, so we have to redirect user to calendly's site to schedule an event |
I wonder if we should disable year selection if there's only one year in the selection list Screen.Recording.2025-05-07.at.5.18.28.PM.mov |
That's how the calendar behaves overall in the whole app. I would try to keep the same behaviour. Nothing is broken. |
Vids uploaded, tests updated. cc: @jjcoffee |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I like that idea, though I'm fine if we want to do that in a follow up. |
Dang, this is a bummer - I thought the whole point was the keep the user in the product? cc @anmurali for thoughts on that |
Thanks for the thought! I think we should do it as a followup. NAB though cc @parasharrajat |
Yeah, let's do that in a follow-up. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks all 🚀
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/MonilBhavsar in version: 9.1.42-0 🚀
|
🚀 Deployed to staging by https://github.com/MonilBhavsar in version: 9.1.43-5 🚀
|
🚀 Deployed to production by https://github.com/francoisl in version: 9.1.44-8 🚀
|
Explanation of Change
Design doc
https://docs.google.com/document/d/1Q_FsNMTX9vKx_pWD75011atzJNV6kGUCBItqyHWVvaw/edit?tab=t.0#bookmark=kix.gbv1cxd24t1i
Fixed Issues
$ #59747
PROPOSAL: https://docs.google.com/document/d/1Q_FsNMTX9vKx_pWD75011atzJNV6kGUCBItqyHWVvaw/edit?tab=t.0#bookmark=kix.gbv1cxd24t1i
Tests
Prerequisites
Schedule Call
button is visible on the report header of #admins room of guide assigned workspace.Steps
Schedule Call
button.date&time
is shown indate&time
row.Offline tests
User can not take this action while offline so we will show FullScreenOfflineLoader.
QA Steps
Prerequisites
Schedule Call
button is visible on the report header of #admins room of the guide assigned workspace.Steps
/schedule-call/book
to the rooms URL in the browser. For native, you will have to open this flow via deeplinking the new URL. e.g Deeplink/r/roomreportid/schedule-call/book
.date&time
is shown indate&time
row.PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
07.05.2025_17.06.13_REC.mp4
Android: mWeb Chrome
07.05.2025_17.11.56_REC.mp4
iOS: Native
07.05.2025_17.30.06_REC.mp4
iOS: mWeb Safari
07.05.2025_17.36.26_REC.mp4
MacOS: Chrome / Safari
07.05.2025_17.01.12_REC.mp4
MacOS: Desktop
07.05.2025_17.13.52_REC.mp4