Skip to content

Add Call Scheduling page for users #59951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

parasharrajat
Copy link
Member

@parasharrajat parasharrajat commented Apr 9, 2025

Explanation of Change

Design doc

https://docs.google.com/document/d/1Q_FsNMTX9vKx_pWD75011atzJNV6kGUCBItqyHWVvaw/edit?tab=t.0#bookmark=kix.gbv1cxd24t1i

Fixed Issues

$ #59747
PROPOSAL: https://docs.google.com/document/d/1Q_FsNMTX9vKx_pWD75011atzJNV6kGUCBItqyHWVvaw/edit?tab=t.0#bookmark=kix.gbv1cxd24t1i

Tests

Prerequisites

  1. Have a guide assigned account.
  2. Schedule Call button is visible on the report header of #admins room of guide assigned workspace.

Steps

  1. Go to #admins room of guide assigned workspace.
  2. Click the Schedule Call button.
  3. Check that while data is loading, a loader is shown.
  4. Verify that the first available date is selected by default.
  5. Select any date from the available dates.
  6. Verify that slots are updated for that date.
  7. Select any slot.
  8. Verify that user is taken to confirmation screen.
  9. Verify that selected date&time is shown in date&time row.
  10. Verify clicking it takes you back to date and time selection page.
  11. Click confirm on the confirmation screen, verify that it takes you to the Calendly scheduling page.
  12. Verify that date and time match with the user selection, and the name and email is prefilled.
  • Verify that the design matches the design doc.
  • Verify that no errors appear in the JS console

Offline tests

User can not take this action while offline so we will show FullScreenOfflineLoader.

QA Steps

Prerequisites

  1. Have a guide assigned account.
  2. Schedule Call button is visible on the report header of #admins room of the guide assigned workspace.

Steps

  1. Go to #admins room of guide assigned workspace.
  2. Now append /schedule-call/book to the rooms URL in the browser. For native, you will have to open this flow via deeplinking the new URL. e.g Deeplink /r/roomreportid/schedule-call/book.
  3. Check that while data is loading, a loader is shown.
  4. Verify that the first available date is selected by default.
  5. Select any date from the available dates.
  6. Verify that slots are updated for that date.
  7. Select any slot.
  8. Verify that user is taken to confirmation screen.
  9. Verify that selected date&time is shown in date&time row.
  10. Verify clicking it takes you back to date and time selection page.
  11. Click confirm on the confirmation screen, verify that it takes you to the Calendly scheduling page.
  12. Verify that date and time match with the user selection, and the name and email is prefilled.
  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
07.05.2025_17.06.13_REC.mp4
Android: mWeb Chrome
07.05.2025_17.11.56_REC.mp4
iOS: Native
07.05.2025_17.30.06_REC.mp4
iOS: mWeb Safari
07.05.2025_17.36.26_REC.mp4
MacOS: Chrome / Safari
07.05.2025_17.01.12_REC.mp4
MacOS: Desktop
07.05.2025_17.13.52_REC.mp4

Copy link

melvin-bot bot commented Apr 9, 2025

Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!

@parasharrajat parasharrajat marked this pull request as ready for review April 25, 2025 12:49
@parasharrajat parasharrajat requested review from a team as code owners April 25, 2025 12:49
@melvin-bot melvin-bot bot requested review from jjcoffee and removed request for a team April 25, 2025 12:49
Copy link

melvin-bot bot commented Apr 25, 2025

@jjcoffee Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@parasharrajat
Copy link
Member Author

parasharrajat commented Apr 25, 2025

I will add screenshots in some time. Doing some cleanup. We can start reviewing the code and functionality now.

@jjcoffee
Copy link
Contributor

@parasharrajat Do I need access to the design doc for this?

Have a guide assigned account.

Also are you simulating this step, or do we have to spam a real guide? 😄

@parasharrajat
Copy link
Member Author

Don't submit the event on the final screen otherwise you can work with it. Yes, get access to design doc, I have added the front-end logic which is outdated but outlines the same approach as this PR. @jjcoffee

@parasharrajat
Copy link
Member Author

Do you know whether we should translate the dates to Spanish as well? Like April to Spanish? @jjcoffee

@jjcoffee
Copy link
Contributor

@parasharrajat Hmm good question, I guess ideally yes as we do this in the date picker.

@parasharrajat
Copy link
Member Author

Do you know which functions I can use to do this?

@parasharrajat
Copy link
Member Author

parasharrajat commented May 6, 2025

Sure, That is what I have done. Thanks

@dubielzyk-expensify
Copy link
Contributor

I kinda feel like we'd just unset the time each time you go back to the time selection page. cc @Expensify/design for a gut check

That feels right to me too

@jjcoffee
Copy link
Contributor

jjcoffee commented May 7, 2025

Should I put this feature behind a check until we are done with the second PR?

IMO this makes sense to do, since it does feel a bit weird that when you return from calendly that there's no visual feedback in-app that anything happened. Curious what @MonilBhavsar thinks, though!

@MonilBhavsar
Copy link
Contributor

Sounds good 👍
What kind of check are you thinking?

@parasharrajat
Copy link
Member Author

Hardcoded flag...we will remove that in next PR.

@MonilBhavsar
Copy link
Contributor

Can we have it in such a way that it can allow us to test the feature. May be by visiting the route directly

@parasharrajat
Copy link
Member Author

Yeah, you can visit the route directly to open the flow.

@MonilBhavsar
Copy link
Contributor

Sounds good 👍

@MonilBhavsar
Copy link
Contributor

I didn't realize we needed a step where you got kicked out to Calendy - I thought the whole point of this was to keep you in the product?

This is the way, I guess. cc @MonilBhavsar

@shawnborton, unfortuantely calendly does not allow us to schedule an event using API, so we have to redirect user to calendly's site to schedule an event

@MonilBhavsar
Copy link
Contributor

I wonder if we should disable year selection if there's only one year in the selection list

Screen.Recording.2025-05-07.at.5.18.28.PM.mov

@parasharrajat
Copy link
Member Author

That's how the calendar behaves overall in the whole app. I would try to keep the same behaviour. Nothing is broken.

@parasharrajat
Copy link
Member Author

Vids uploaded, tests updated. cc: @jjcoffee

Copy link
Contributor

@jjcoffee jjcoffee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@melvin-bot melvin-bot bot requested a review from MonilBhavsar May 7, 2025 14:02
@shawnborton
Copy link
Contributor

I wonder if we should disable year selection if there's only one year in the selection list

I like that idea, though I'm fine if we want to do that in a follow up.

@shawnborton
Copy link
Contributor

unfortuantely calendly does not allow us to schedule an event using API, so we have to redirect user to calendly's site to schedule an event

Dang, this is a bummer - I thought the whole point was the keep the user in the product? cc @anmurali for thoughts on that

@MonilBhavsar
Copy link
Contributor

I wonder if we should disable year selection if there's only one year in the selection list

I like that idea, though I'm fine if we want to do that in a follow up.

Thanks for the thought! I think we should do it as a followup. NAB though cc @parasharrajat

@parasharrajat
Copy link
Member Author

Yeah, let's do that in a follow-up.

Copy link
Contributor

@MonilBhavsar MonilBhavsar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks all 🚀

@MonilBhavsar MonilBhavsar merged commit 406eb74 into Expensify:main May 7, 2025
19 checks passed
@OSBotify
Copy link
Contributor

OSBotify commented May 7, 2025

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

Copy link
Contributor

github-actions bot commented May 8, 2025

🚀 Deployed to staging by https://github.com/MonilBhavsar in version: 9.1.42-0 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Copy link
Contributor

github-actions bot commented May 9, 2025

🚀 Deployed to staging by https://github.com/MonilBhavsar in version: 9.1.43-5 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 failure ❌

Copy link
Contributor

🚀 Deployed to production by https://github.com/francoisl in version: 9.1.44-8 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 failure ❌
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants