Skip to content

Deploy Checklist: New Expensify 2025-04-03 #59590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
86 tasks done
github-actions bot opened this issue Apr 3, 2025 · 21 comments
Closed
86 tasks done

Deploy Checklist: New Expensify 2025-04-03 #59590

github-actions bot opened this issue Apr 3, 2025 · 21 comments
Assignees
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging Monthly KSv2 StagingDeployCash

Comments

@github-actions
Copy link
Contributor

github-actions bot commented Apr 3, 2025

Release Version: 9.1.23-7
Compare Changes: production...staging

This release contains changes from the following pull requests:

Deploy Blockers:

Deployer verifications:

  • I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
  • I checked Firebase Crashlytics for this release version and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
  • I checked Firebase Crashlytics for the previous release version and verified that the release did not introduce any new crashes. More detailed instructions on this verification can be found here.
  • I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

@gleitebr gleitebr added the 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging label Apr 3, 2025
Copy link
Contributor Author

github-actions bot commented Apr 3, 2025

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/9.1.23-1 🚀

@francoisl
Copy link
Contributor

The CP for #59633 will hide the attendee selector, and resolve all attendees blocker. I'm also going to check #58120 as it's no longer testable.

@francoisl
Copy link
Contributor

Demoted 59608

@kavimuru
Copy link

kavimuru commented Apr 4, 2025

Regression is at 96%

Unchecked PRs:

#56479 pending validation on Desktop and iOS
#57483 Pending validation on Desktop
#57647 Pending validation on all the platforms
#57920 Pending validation on all the platforms
#58072 Pending validation on iOS
#58495 pending validation on Desktop and iOS and web
#58674 pending validation on Desktop and iOS
#58852 Pending validation on all the platforms (requires for delayed submission of a day)
#58902 (comment)
#59062 Pending validation on all the platforms
#59154 Pending validation in iOS
#59221 Pending validation on all the platforms
#59292 Pending validation on all the platforms
#59308 Pending validation in iOS
#59415 Pending validation in iOS
#59503 Pending validation on web
#59564 Pending validation on desktop and iOS

@grgia
Copy link
Contributor

grgia commented Apr 4, 2025

No Fresh Crashes, Nice

Image Image

@izarutskaya
Copy link

Regression just a few steps left

We still don't see build 9.1.23-3 for Android and iOS

Blockers:
#59357
#59615
#59639

@grgia
Copy link
Contributor

grgia commented Apr 4, 2025

We still don't see build 9.1.23-3 for Android and iOS

Working on this here https://expensify.slack.com/archives/C07J32337/p1743766038513989

@kavimuru
Copy link

kavimuru commented Apr 4, 2025

unchecked PRs:
#58495 failing with #59449 repro in PROD checking it off
#58674 - Pending validation on Desktop
#58902 (comment)
#59154 (comment)
#59221 pending validation on desktop and iOS
#59292 (comment)
#59633 android and iOS are pending validation
#59620 waiting for the build
#58852 Pending validation on all the platforms (requires for delayed submission of a day)

@grgia
Copy link
Contributor

grgia commented Apr 4, 2025

checking off #59357 as prod bug

@melvin-bot melvin-bot bot added the Monthly KSv2 label Apr 7, 2025
@grgia
Copy link
Contributor

grgia commented Apr 7, 2025

@kavimuru IOS / Android builds should be fixed now

@kavimuru
Copy link

kavimuru commented Apr 7, 2025

@grgia we have validated the Cps and checked off from the list.

Unchecked PRs:
#58902 (comment) we are unsure if applause.expensifail.com domain are beta enabled.
#58852 Waiting for desktop result.
#58495 failing with #59449 repro in PROD checking it off
#59154 (comment)
#59292 (comment)

Open blockers:
#59615
#59639

@grgia
Copy link
Contributor

grgia commented Apr 7, 2025

checking off #59615 as fix passes QA

@grgia
Copy link
Contributor

grgia commented Apr 7, 2025

checking off #59154 as linked issue was closed

@grgia
Copy link
Contributor

grgia commented Apr 7, 2025

on #58852 Pending validation on all the platforms (requires for delayed submission of a day)

we will not block on this, but can this be checked off soon since this checklist was opened on friday?

@kavimuru

@kavimuru
Copy link

kavimuru commented Apr 7, 2025

@grgia we are validating this CP now #59730. The build is not available for iOS and android

#58852 is validated in all the platforms and checked it off.

@grgia
Copy link
Contributor

grgia commented Apr 7, 2025

Thank you @kavimuru. IOS and android should be available now

@grgia
Copy link
Contributor

grgia commented Apr 7, 2025

Checking off #59639 as fixed was CPd

@grgia
Copy link
Contributor

grgia commented Apr 7, 2025

@kavimuru would you please give an update on the unchecked QA issues?

@mvtglobally
Copy link

@grgia #58902 is pass on all platforms but Android. We found an issue #59742, but it doesn't look to be a blocker. Checking off

@grgia
Copy link
Contributor

grgia commented Apr 7, 2025

Thank you @mvtglobally !

@jasperhuangg
Copy link
Contributor

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging Monthly KSv2 StagingDeployCash
Projects
None yet
Development

No branches or pull requests

8 participants