Fix wrong popover position #57920

bernhardoj · 2025-03-06T08:09:53Z

Explanation of Change

Fixed Issues

$ #57011
PROPOSAL: #57011 (comment)

Tests

Same as QA Steps

Verify that no errors appear in the JS console

Offline tests

Same as QA Steps

QA Steps

Log in with a Gmail account that is already an admin of a workspace (or create one)
Navigate to Settings - Subscription
Scroll down to the bottom of the page
Click on the 3-dot button next to "Subscription details"
For web/desktop, verify the popover menu position is around the 3-dot menu
For mWeb/Android/iOS, verify the popover shows as a bottom modal

For Android & iOS, there is no 3-dot on the subscription page, so you can test on other 3-dots, for example, on the workspace list page.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android.mp4

Android: mWeb Chrome

android.mweb.mp4

iOS: Native

ios.mp4

iOS: mWeb Safari

ios.mweb.mp4

MacOS: Chrome / Safari

web.mp4

MacOS: Desktop

desktop.mp4

melvin-bot · 2025-03-06T08:09:58Z

@parasharrajat Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

bernhardoj · 2025-03-06T08:11:12Z

Additional video of other 3-dots

aa.mp4

parasharrajat · 2025-03-06T08:49:43Z

src/pages/settings/Subscription/TaxExemptActions/index.tsx

        >
            <ThreeDotsMenu
+                getAnchorPosition={calculateAndSetThreeDotsMenuPosition}


Why are we calculating it from the outside View but not from inside the ThreeDotsMenu?

i notice that not all 3 dot has the same calculation. saved search 3 dot for example doesn't add height to the vertical position.

vertical: y

parasharrajat · 2025-03-11T18:11:05Z

ETA: tomorrow.

bernhardoj · 2025-03-20T01:31:38Z

@parasharrajat bump for the review

parasharrajat · 2025-03-30T15:12:36Z

src/components/ThreeDotsMenu/index.tsx

@@ -121,7 +131,7 @@ function ThreeDotsMenu({
            <PopoverMenu
                onClose={hidePopoverMenu}
                isVisible={isPopupMenuVisible && !isBehindModal}
-                anchorPosition={anchorPosition}
+                anchorPosition={position ?? anchorPosition ?? {horizontal: 0, vertical: 0}}


Why are we passing both position and anchorPosition, when we already passing the anchorPosition callback?

We should pass {horizontal: 0, vertical: 0} as default value to position state.

If a component passes anchorPosition and not getAnchorPosition, then the position will be undefined and fallback to anchorPosition props.

parasharrajat · 2025-03-30T15:13:18Z

src/components/ThreeDotsMenu/types.ts

+type ThreeDotsMenuWithOptionalAnchorProps =
+    | (ThreeDotsMenuProps & {
+          /** The anchor position of the menu */
+          anchorPosition: AnchorPosition;
+
+          /** A callback to get the anchor position dynamically */
+          getAnchorPosition?: () => Promise<AnchorPosition>;
+      })
+    | (ThreeDotsMenuProps & {
+          /** The anchor position of the menu */
+          anchorPosition?: AnchorPosition;
+
+          /** A callback to get the anchor position dynamically */
+          getAnchorPosition: () => Promise<AnchorPosition>;
+      });


What is the difference between both types?

First type requires anchorPosition, second type requires getAnchorPosition.

Let's choose one. I think getAnchorPosition is good enough.

@bernhardoj Is there a need for both props? Should we just keep one getAnchorPosition? If a user wants to send static position they can do this via this callback as well?

We need both. With this type, the user needs to either pass anchorPosition or getAnchorPosition.

getAnchorPosition={() => Promise.resolve(threeDotsAnchorPosition)} I believe this.

Hmm, yeah it is a little overhead of promise but having two props for same thing while a single prop can handle both cases is confusing. While you must have noticed, we have a few components which are consuming a huge number of props making is very confusing on how these components can be utilized

I think some components have too many props because they're too big, trying to handle many cases/responsibilities.

If we use getAnchorPosition only, it will:

add delay (because of promise)

extra render (because of set state)

for component that already has the anchor position information.

OK, I am fine with it. It's not a blocker.

So, should the user pass only one or both can be passed?

In case, only one should be set. We can update the type to

Suggested change

type ThreeDotsMenuWithOptionalAnchorProps =

| (ThreeDotsMenuProps & {

/** The anchor position of the menu */

anchorPosition: AnchorPosition;

/** A callback to get the anchor position dynamically */

getAnchorPosition?: () => Promise<AnchorPosition>;

})

| (ThreeDotsMenuProps & {

/** The anchor position of the menu */

anchorPosition?: AnchorPosition;

/** A callback to get the anchor position dynamically */

getAnchorPosition: () => Promise<AnchorPosition>;

});

type ThreeDotsMenuWithOptionalAnchorProps =

| (ThreeDotsMenuProps & {

/** The anchor position of the menu */

anchorPosition: AnchorPosition;

/** A callback to get the anchor position dynamically */

getAnchorPosition?: never;

})

| (ThreeDotsMenuProps & {

/** The anchor position of the menu */

anchorPosition?: never;

/** A callback to get the anchor position dynamically */

getAnchorPosition: () => Promise<AnchorPosition>;

});

src/pages/settings/Subscription/SubscriptionDetails/index.tsx

src/pages/workspace/accounting/PolicyAccountingPage.tsx

src/pages/workspace/WorkspacesListRow.tsx

parasharrajat · 2025-03-31T14:39:37Z

@bernhardoj There are some conflicts.

bernhardoj · 2025-03-31T23:14:56Z

@parasharrajat fixed

parasharrajat · 2025-03-31T23:17:07Z

Screenshots

🔲 iOS / native

31.03.2025_00.28.03_REC.mp4

🔲 iOS / Safari

31.03.2025_00.18.46_REC.mp4

🔲 MacOS / Desktop

31.03.2025_00.20.08_REC.mp4

🔲 MacOS / Chrome

31.03.2025_00.11.20_REC.mp4

🔲 Android / Chrome

31.03.2025_01.04.32_REC.mp4

🔲 Android / native

31.03.2025_00.54.23_REC.mp4

parasharrajat

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

🎀 👀 🎀 C+ reviewed

lakchote · 2025-04-01T04:31:57Z

prettier and perf tests are failing @bernhardoj

lakchote · 2025-04-02T08:00:28Z

prettier and perf tests are failing @bernhardoj

friendly bump @bernhardoj

bernhardoj · 2025-04-03T13:12:36Z

@lakchote done

OSBotify · 2025-04-03T15:37:35Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-04-03T17:10:27Z

🚀 Deployed to staging by https://github.com/lakchote in version: 9.1.23-2 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

github-actions · 2025-04-07T20:31:01Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.1.23-7 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

fix wrong popover position

9811f2e

bernhardoj requested a review from a team as a code owner March 6, 2025 08:09

melvin-bot bot requested review from parasharrajat and removed request for a team March 6, 2025 08:09

bernhardoj added 2 commits March 6, 2025 16:15

lint

fd41d62

lint

8302ac1

parasharrajat reviewed Mar 6, 2025

View reviewed changes

bernhardoj mentioned this pull request Mar 20, 2025

[$250] Request tax exempt status menu is WAY off in subscription #58737

Closed

8 tasks

Merge branch 'main' into fix/57011-modal-opens-at-bottom-page

544b47f

This was referenced Mar 24, 2025

[HOLD FOR #57920] WS- 3 dot workspace menu options misaligned to left side after submitting expense in WS chat #58971

Closed

[$250] Web - Workspace - Workspace More menu opens on the left #58492

Closed

parasharrajat suggested changes Mar 30, 2025

View reviewed changes

bernhardoj added 2 commits March 31, 2025 12:41

revert unexpected changes

868fdef

update type

67eee8b

Merge branch 'main' into fix/57011-modal-opens-at-bottom-page

a90224f

parasharrajat approved these changes Mar 31, 2025

View reviewed changes

melvin-bot bot requested a review from lakchote March 31, 2025 23:19

bernhardoj added 2 commits April 3, 2025 21:06

Merge branch 'main' into fix/57011-modal-opens-at-bottom-page

4d9339b

prettier

61ed05e

lakchote approved these changes Apr 3, 2025

View reviewed changes

lakchote merged commit 73e3884 into Expensify:main Apr 3, 2025
16 checks passed

github-actions bot mentioned this pull request Apr 3, 2025

Deploy Checklist: New Expensify 2025-04-03 #59590

Closed

86 tasks

melvin-bot bot mentioned this pull request Apr 7, 2025

[Due for payment 2025-04-14] [$250] Web - Subscription - Web - "Request tax exempt status" button opens at the bottom of the page #57011

Closed

8 tasks

Fix wrong popover position #57920

Fix wrong popover position #57920

Uh oh!

Conversation

bernhardoj commented Mar 6, 2025

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Mar 6, 2025

Uh oh!

bernhardoj commented Mar 6, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

parasharrajat commented Mar 11, 2025

Uh oh!

bernhardoj commented Mar 20, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

parasharrajat commented Mar 31, 2025

Uh oh!

bernhardoj commented Mar 31, 2025

Uh oh!

parasharrajat commented Mar 31, 2025

Screenshots

🔲 iOS / native

🔲 iOS / Safari

🔲 MacOS / Desktop

🔲 MacOS / Chrome

🔲 Android / Chrome

🔲 Android / native

Uh oh!

parasharrajat left a comment

Choose a reason for hiding this comment

Reviewer Checklist

Uh oh!

lakchote commented Apr 1, 2025

Uh oh!

lakchote commented Apr 2, 2025

Uh oh!

bernhardoj commented Apr 3, 2025

Uh oh!

Uh oh!

OSBotify commented Apr 3, 2025

Uh oh!