Skip to content

[HOLD FOR #57920] WS- 3 dot workspace menu options misaligned to left side after submitting expense in WS chat #58971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 of 8 tasks
mitarachim opened this issue Mar 24, 2025 · 9 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors retest-weekly Apply this label if you want this issue tested on a Weekly basis by Applause Weekly KSv2

Comments

@mitarachim
Copy link

mitarachim commented Mar 24, 2025

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: v9.1.17-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: Exploratory
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Windows 11/Chrome, Macbook Pro/14.5/Chrome
App Component: Workspace Settings

Action Performed:

  1. Navigate to staging.new.expensify.com
  2. Create a new account either with expensifail or gmail domain
  3. Go to Settings >> Workspaces
  4. Create a new workspace
  5. Go to WS list page & tap on 3 dot menu (Note: menu options are correctly aligned on right side)
  6. Go to workspace chat page & submit an expense
  7. Go back to WS list page & tap on 3 dot menu

Expected Result:

3 dot workspace menu options should be correctly right aligned just below the 3 dot menu

Actual Result:

3 dot workspace menu options misaligned to left side after submitting expense in WS chat

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6779911_1742758286166.Recording__59__2_.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021904047332643175075
  • Upwork Job ID: 1904047332643175075
  • Last Price Increase: 2025-03-24
Issue OwnerCurrent Issue Owner: @allroundexperts
@mitarachim mitarachim added Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 labels Mar 24, 2025
Copy link

melvin-bot bot commented Mar 24, 2025

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@daledah
Copy link
Contributor

daledah commented Mar 24, 2025

Proposal

Please re-state the problem that we are trying to solve in this issue.

3 dot workspace menu options misaligned to left side after submitting expense in WS chat

What is the root cause of that problem?

we are calculating the position of the popover here

onLayout={(e: LayoutChangeEvent) => {
if (shouldUseNarrowLayout) {
return;
}
const target = e.target || (e as LayoutChangeEventWithTarget).nativeEvent.target;
target?.measureInWindow((x, y, width) => {
setThreeDotsMenuPosition({
horizontal: x + width,
vertical: y,
});
});
}}

What changes do you think we should make in order to solve the problem?

We should use InteractionManager.runAfterInteractions to make sure we calculate correctly after all interactions are done

          InteractionManager.runAfterInteractions(() => {
              const target = e.target || (e as LayoutChangeEventWithTarget).nativeEvent.target; 
              target?.measureInWindow((x, y, width) => { 
                  setThreeDotsMenuPosition({ 
                      horizontal: x + width, 
                      vertical: y, 
                  }); 
              }); 
          });

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

@jliexpensify jliexpensify added the External Added to denote the issue can be worked on by a contributor label Mar 24, 2025
@melvin-bot melvin-bot bot changed the title WS- 3 dot workspace menu options misaligned to left side after submitting expense in WS chat [$250] WS- 3 dot workspace menu options misaligned to left side after submitting expense in WS chat Mar 24, 2025
Copy link

melvin-bot bot commented Mar 24, 2025

Job added to Upwork: https://www.upwork.com/jobs/~021904047332643175075

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Mar 24, 2025
Copy link

melvin-bot bot commented Mar 24, 2025

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts (External)

@jliexpensify
Copy link
Contributor

Able to repro. Should be #quality.

@bernhardoj
Copy link
Contributor

This should be fixed by #57920

@jliexpensify
Copy link
Contributor

Awesome, thank you @bernhardoj!

@jliexpensify jliexpensify added Weekly KSv2 and removed Daily KSv2 labels Mar 24, 2025
@jliexpensify jliexpensify changed the title [$250] WS- 3 dot workspace menu options misaligned to left side after submitting expense in WS chat [HOLD FOR #57920] WS- 3 dot workspace menu options misaligned to left side after submitting expense in WS chat Mar 24, 2025
@jliexpensify jliexpensify added the retest-weekly Apply this label if you want this issue tested on a Weekly basis by Applause label Mar 24, 2025
@mvtglobally
Copy link

Issue not reproducible during KI retests. (First week)

@melvin-bot melvin-bot bot added the Overdue label Apr 12, 2025
@jliexpensify
Copy link
Contributor

Closing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors retest-weekly Apply this label if you want this issue tested on a Weekly basis by Applause Weekly KSv2
Projects
Status: Done
Development

No branches or pull requests

6 participants