fix: Task - Mark down is not copied when task preview is copied to clipboard. #58572

Krishna2323 · 2025-03-17T17:29:41Z

Explanation of Change

Fixed Issues

$ #58154
$ #58137
$ #58136
PROPOSAL: NA

Tests

Go to any chat.
Tap + > Assign task.
Tap Title.
Enter text with mark down and save it.
Create the task.
Right click on the task preview > Copy to clipboard.
Paste the content.
Verify task title with mark down is copied.

Test 2

Go to any chat.
Click + > Assign task.
Click Title.
Enter text with blockquote and save it.
Create the task.
Hover over the task preview in the main chat.
Note that the block quote line is visible when hovered.
Click on the task preview.
Verify the block quote text is rendered as normal task title text.

Test 3

Go to chat.
Tap + > Assign task.
Tap Title.
Enter > > hey and save it.
Go to task report.
Verify hey is rendered as normal task title text.
Tap Title.
Clear the field and enter

hey

Save the new title.
Verify that "hey" is rendered as normal task title text.
Verify that the task report header does not had extra space.

Verify that no errors appear in the JS console

Offline tests

Same as Tests

QA Steps

Same as Tests
Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android_native.mp4

Android: mWeb Chrome

android_chrome.mp4

iOS: Native

ios_native.mp4

iOS: mWeb Safari

ios_safari.mp4

MacOS: Chrome / Safari

web_chrome.mp4

MacOS: Desktop

desktop_app.mp4

…ipboard. Signed-off-by: krishna2323 <[email protected]>

…tle field in task report. Signed-off-by: krishna2323 <[email protected]>

Signed-off-by: krishna2323 <[email protected]>

…s used in task title. Signed-off-by: krishna2323 <[email protected]>

Signed-off-by: krishna2323 <[email protected]>

src/components/HTMLEngineProvider/HTMLRenderers/BlockQuoteRenderer.tsx

src/components/HTMLEngineProvider/HTMLRenderers/StrongRenderer.tsx

src/components/ReportActionItem/TaskView.tsx

mananjadhav · 2025-03-23T18:09:22Z

src/libs/StringUtils.ts

+/**
+ * Remove pre tag from the html
+ */
+function removePreCodeBlock(text = '') {


do we have tests for this method

The function is quite simple, and a test might not add much value.

mananjadhav

Can we add tests for the methods?

melvin-bot · 2025-03-24T01:43:34Z

@mananjadhav Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Signed-off-by: krishna2323 <[email protected]>

mananjadhav · 2025-03-26T15:29:50Z

@Krishna2323 Can you merge the latest main and resolve conflicts?

Signed-off-by: krishna2323 <[email protected]>

mananjadhav · 2025-03-27T13:42:54Z

@Krishna2323 The screenshots are missing for all the platforms. Can you please go through the checklist once more and ensure you've only checked off after verifying each item?

Signed-off-by: krishna2323 <[email protected]>

Krishna2323 · 2025-03-27T22:19:53Z

src/components/HTMLEngineProvider/BaseHTMLEngineProvider.tsx

                    }
-                    return styles.onlyEmojisTextLineHeight;
+                    return HTMLEngineUtils.isChildOfTaskTitle(tnode as TNode) ? {} : {...styles.blockquote, ...styles.onlyEmojisTextLineHeight};


@mananjadhav, I removed the custom blockquote renderer file after learning a better way to override styles for the task title from @bernhardoj's PR. This approach works really well for our case.

Krishna2323 · 2025-03-27T22:20:10Z

@mananjadhav, I have added the screenshots.

Signed-off-by: krishna2323 <[email protected]>

mananjadhav · 2025-03-31T16:38:48Z

Testing this PR.

dubielzyk-expensify · 2025-04-01T02:58:02Z

I think this looks fine to me, but just a cc to @Expensify/design that we keep running into these weird edge cases for markdown support now.

dannymcclain · 2025-04-01T13:38:29Z

Totally agree. I think at some point it would be nice to come up with a really tight, global strategy on how we handle markdown throughout the app. It's getting a bit wild.

mananjadhav · 2025-04-01T15:22:46Z

@Krishna2323 Can you please resolve the conflicts?

Krishna2323 · 2025-04-02T08:12:27Z

@mananjadhav, done.

mananjadhav · 2025-04-02T16:56:36Z

@Expensify/design Just confirming that in the Task report, we don't want the > block quote to show up right?

web-block-quote-task.mov

shawnborton · 2025-04-02T17:01:23Z

Yeah, that seems fine to me 👍

mananjadhav · 2025-04-02T17:02:09Z

Thanks for confirming.

mananjadhav · 2025-04-02T17:15:48Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

android-block-quote-task.mov

Android: mWeb Chrome

mweb-chrome-block-quote-task.mov

iOS: Native

ios-block-quote-task.mov

iOS: mWeb Safari

mweb-safari-block-quote-task.mov

MacOS: Chrome / Safari

web-block-quote-task.mov

MacOS: Desktop

desktop-block-quote-task.mov

robertjchen

Looks good, thank you!

github-actions · 2025-04-03T16:10:30Z

🚀 Deployed to staging by https://github.com/robertjchen in version: 9.1.23-1 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

github-actions · 2025-04-07T20:31:19Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.1.23-7 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

Krishna2323 added 7 commits March 17, 2025 22:58

fix: Task - Mark down is not copied when task preview is copied to cl…

ede02ac

…ipboard. Signed-off-by: krishna2323 <[email protected]>

fix: Web - Task - Block quote line is invisible when hovering over Ti…

066b75c

…tle field in task report. Signed-off-by: krishna2323 <[email protected]>

fix: StrongRenderer.

aff6f4c

Signed-off-by: krishna2323 <[email protected]>

fix extra line in task title.

952b873

Signed-off-by: krishna2323 <[email protected]>

Merge branch 'Expensify:main' into krishna2323/issue/58154

6630dae

fix: iOS - Task - Content is cut off when block quote or code block i…

622ab5b

…s used in task title. Signed-off-by: krishna2323 <[email protected]>

remove pre tag style from title.

4f73211

Signed-off-by: krishna2323 <[email protected]>

mananjadhav reviewed Mar 23, 2025

View reviewed changes

src/components/HTMLEngineProvider/HTMLRenderers/BlockQuoteRenderer.tsx Outdated Show resolved Hide resolved

mananjadhav reviewed Mar 23, 2025

View reviewed changes

src/components/HTMLEngineProvider/HTMLRenderers/StrongRenderer.tsx Outdated Show resolved Hide resolved

mananjadhav reviewed Mar 23, 2025

View reviewed changes

src/components/ReportActionItem/TaskView.tsx Outdated Show resolved Hide resolved

mananjadhav reviewed Mar 23, 2025

View reviewed changes

Merge branch 'Expensify:main' into krishna2323/issue/58154

ceef474

Krishna2323 marked this pull request as ready for review March 24, 2025 01:43

Krishna2323 requested review from a team as code owners March 24, 2025 01:43

melvin-bot bot requested review from mananjadhav and removed request for a team March 24, 2025 01:43

update props name.

513b2b2

Signed-off-by: krishna2323 <[email protected]>

Krishna2323 added 2 commits March 27, 2025 03:31

Merge branch 'main' into krishna2323/issue/58154

61612b6

fix duplicated code.

38c8962

Signed-off-by: krishna2323 <[email protected]>

use getMixedUAStyles for blockquote styles.

2c64e73

Signed-off-by: krishna2323 <[email protected]>

Krishna2323 commented Mar 27, 2025

View reviewed changes

Krishna2323 added 3 commits March 28, 2025 03:51

remove duplicate styles.

4119667

Signed-off-by: krishna2323 <[email protected]>

fix blockquote styles.

ed4e0cd

Signed-off-by: krishna2323 <[email protected]>

Merge branch 'Expensify:main' into krishna2323/issue/58154

7f3bc9b

Krishna2323 mentioned this pull request Mar 31, 2025

fix: Completed task does not show strikethrough style. #58629

Merged

49 tasks

Merge branch 'Expensify:main' into krishna2323/issue/58154

69dbbb2

mananjadhav approved these changes Apr 2, 2025

View reviewed changes

melvin-bot bot requested a review from robertjchen April 2, 2025 17:16

robertjchen approved these changes Apr 3, 2025

View reviewed changes

robertjchen merged commit 824bd87 into Expensify:main Apr 3, 2025
17 checks passed

github-actions bot mentioned this pull request Apr 3, 2025

Deploy Checklist: New Expensify 2025-04-03 #59590

Closed

86 tasks

fix: Task - Mark down is not copied when task preview is copied to clipboard. #58572

fix: Task - Mark down is not copied when task preview is copied to clipboard. #58572

Uh oh!

Conversation

Krishna2323 commented Mar 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Test 2

Test 3

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mananjadhav Mar 23, 2025

Choose a reason for hiding this comment

Uh oh!

Krishna2323 Mar 24, 2025

Choose a reason for hiding this comment

Uh oh!

mananjadhav left a comment

Choose a reason for hiding this comment

Uh oh!

melvin-bot bot commented Mar 24, 2025

Uh oh!

mananjadhav commented Mar 26, 2025

Uh oh!

mananjadhav commented Mar 27, 2025

Uh oh!

Krishna2323 Mar 27, 2025

Choose a reason for hiding this comment

Uh oh!

Krishna2323 commented Mar 27, 2025

Uh oh!

mananjadhav commented Mar 31, 2025

Uh oh!

dubielzyk-expensify commented Apr 1, 2025

Uh oh!

dannymcclain commented Apr 1, 2025

Uh oh!

mananjadhav commented Apr 1, 2025

Uh oh!

Krishna2323 commented Apr 2, 2025

Uh oh!

mananjadhav commented Apr 2, 2025

Uh oh!

shawnborton commented Apr 2, 2025

Uh oh!

mananjadhav commented Apr 2, 2025

Uh oh!

mananjadhav commented Apr 2, 2025

Reviewer Checklist

Screenshots/Videos

Uh oh!

robertjchen left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Apr 3, 2025

Uh oh!

github-actions bot commented Apr 7, 2025

Uh oh!

Uh oh!

Krishna2323 commented Mar 17, 2025 •

edited

Loading