Skip to content

[Due for payment 2025-04-16] Attendees - Unable to select attendee when categorizing expense #59599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
4 of 8 tasks
jponikarchuk opened this issue Apr 3, 2025 · 15 comments · Fixed by #60067
Closed
4 of 8 tasks
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Engineering Reviewing Has a PR in review Weekly KSv2

Comments

@jponikarchuk
Copy link

jponikarchuk commented Apr 3, 2025

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.1.23-1
Reproducible in staging?: Yes
Reproducible in production?: Unable to check, new feature
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Mac 15.3 / Chrome
App Component: Money Requests

Action Performed:

Precondition:

  • Account has self DM.
  1. Go to staging.new.expensify.com
  2. Go to workspace chat.
  3. Click + > Create expense > Manual.
  4. Enter amount > Next,
  5. On confirmation page, click Attendees.
  6. Note that Attendees field is auto-selected to yourself and has a Save button.
  7. Go to self DM.
  8. Track a manual expense.
  9. Click Categorize it.
  10. Select a category.
  11. Click Show more.
  12. Click Attendees field.

Expected Result:

Attendees field will auto-select to yourself and have a Save button.

Actual Result:

Attendees field does not auto-select to yourself and does not have a Save button.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @greg-schroeder
@jponikarchuk jponikarchuk added Bug Something is broken. Auto assigns a BugZero manager. DeployBlockerCash This issue or pull request should block deployment labels Apr 3, 2025
Copy link

melvin-bot bot commented Apr 3, 2025

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Apr 3, 2025

Triggered auto assignment to @jasperhuangg (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@melvin-bot melvin-bot bot added the Daily KSv2 label Apr 3, 2025
Copy link

melvin-bot bot commented Apr 3, 2025

💬 A slack conversation has been started in #expensify-open-source

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Apr 3, 2025
Copy link
Contributor

github-actions bot commented Apr 3, 2025

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@jasperhuangg
Copy link
Contributor

Reached out here to @allroundexperts to see if they can fix this, coming from #58120

@francoisl
Copy link
Contributor

We're CP'ing a PR to hide the attendee selector, I'm going to remove the blocker label and keep this open as an issue to fix later.

@francoisl francoisl removed the DeployBlockerCash This issue or pull request should block deployment label Apr 3, 2025
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Apr 7, 2025
@melvin-bot melvin-bot bot changed the title Attendees - Unable to select attendee when categorizing expense [Due for payment 2025-04-14] Attendees - Unable to select attendee when categorizing expense Apr 7, 2025
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Apr 7, 2025
Copy link

melvin-bot bot commented Apr 7, 2025

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Apr 7, 2025

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.23-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-04-14. 🎊

Copy link

melvin-bot bot commented Apr 7, 2025

@jasperhuangg @greg-schroeder @jasperhuangg The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Apr 9, 2025
@melvin-bot melvin-bot bot changed the title [Due for payment 2025-04-14] Attendees - Unable to select attendee when categorizing expense [Due for payment 2025-04-16] [Due for payment 2025-04-14] Attendees - Unable to select attendee when categorizing expense Apr 9, 2025
Copy link

melvin-bot bot commented Apr 9, 2025

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.24-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-04-16. 🎊

For reference, here are some details about the assignees on this issue:

Copy link

melvin-bot bot commented Apr 9, 2025

@allroundexperts @greg-schroeder @allroundexperts The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Apr 14, 2025
@greg-schroeder greg-schroeder changed the title [Due for payment 2025-04-16] [Due for payment 2025-04-14] Attendees - Unable to select attendee when categorizing expense [Due for payment 2025-04-16] Attendees - Unable to select attendee when categorizing expense Apr 14, 2025
Copy link

melvin-bot bot commented Apr 16, 2025

Payment Summary

Regression fix, no payments due.

BugZero Checklist (@greg-schroeder)

  • I have verified the correct assignees and roles are listed above and updated the necessary manual offers
  • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
  • I have paid out the Upwork contracts or cancelled the ones that are incorrect
  • I have verified the payment summary above is correct

@melvin-bot melvin-bot bot added the Overdue label Apr 16, 2025
@greg-schroeder
Copy link
Contributor

Processing today

@melvin-bot melvin-bot bot removed the Overdue label Apr 16, 2025
@greg-schroeder
Copy link
Contributor

This is a regression fix by the contributor initially involved, so no payments due.

@allroundexperts
Copy link
Contributor

@greg-schroeder This is actually not completed yet. We're still working on it, and it was agreed that all the issues would be paid separately as bugs because they were not technically caused by the above mentioned PR. Let's re-open this and track #60067

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Apr 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Engineering Reviewing Has a PR in review Weekly KSv2
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants