Track Expense - Polish #60067

allroundexperts · 2025-04-10T20:39:13Z

Explanation of Change

fixes #59602
fixes #59603
fixes #59617
fixes #59621
fixes #59631
fixes #59597
fixes #59599
fixes #59600

Fixed Issues

$ #44725
PROPOSAL: N/A

Tests

Test 1

#59602

Open app, and create a workspace that has enabled invoicing.
Go to FAB > Send invoice.
Enter amount > Next.
Select a new user with no previous chat.
Click Show more.
Note that there is no Attendees field on the confirmation page.
Submit the invoice.
Go to invoice thread.

Expected Result:
Verify that the attendees field is not present in the thread.

Test 2

#59603

Open the app, go to WS setting and add a member
Open the FAB menu and click on create expense.
Select manual expense creation and enter an amount.
On the confirmation screen, click on Attendees section and add one attendee users ( the one you add in step 2).
Submit the expense and go to expense details page.
Click on the Attendees section

Verify that the selected member shouldn't be available to add again in contact list

Test 3

#59617

Log in with a new Gmail account
Create a new workspace
Go to workspace chat
Click + > Create expense > Manual
Enter amount > Next
Click Show more
Click Attendees
Select Manager McTest

Verify that the test manager tooltip will disappear after selecting the manager

Test 4

#59621

Launch app and Open employee workspace chat
Create a scan expense and wait till scanning failed
Open the scan expense
Tap attendees - select a attendee

Verify that in failed scan expense, selecting an attendee after scanning does not display error.

Test 5

#59631

Open the app and go to any workspace chat.
Click + > Create expense > Distance.
Enter waypoints > Next.
On confirmation page, click Show more.
Note that Attendees field has yourself selected.
Create the expense.
Go to transaction thread.

Verify that the attendees field in the transaction thread will retain the selection on the confirmation page.

Test 6

#59597

Open the app and go to workspace chat.
Click + > Create expense > Scan.
Upload a receipt.
On confirmation page, click Attendees.
Select another user and click Save.

Verify that Attendees field shows "Attendees" only.

Create the expense.
Go to transaction thread.

Verify that the attendees field will show "Attendees" in the transaction thread while the receipt is scanning. Once scanned successfully, it should show <currency> <amount> per person

Test 7

#59599

Go to self DM.
Track a manual expense.
Click Categorize it.
Select a category.
Click Show more.
Click Attendees field.

Verify that the Attendees field has a Save button.

Test 8

fixes #59600

Open App > Go to FAB > Create expense > Manual
Enter amount > Next.
Select a destination if needed.
Click Show more.
Click Attendees.
Enter any user name.
Click on the user.

Verify that the user will not appear twice after the user is selected.

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Same as above

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Unable to build android

Android: mWeb Chrome

Screen.Recording.2025-04-22.at.3.14.42.PM.mov

iOS: Native

Screen.Recording.2025-04-22.at.3.11.38.PM.mov

iOS: mWeb Safari

Screen.Recording.2025-04-22.at.3.07.09.PM.mov

MacOS: Chrome / Safari

Screen.Recording.2025-04-22.at.5.18.56.AM.mov

Screen.Recording.2025-04-22.at.5.20.13.AM.mov

Screen.Recording.2025-04-22.at.5.23.36.AM.mov

Screen.Recording.2025-04-22.at.5.24.51.AM.mov

Screen.Recording.2025-04-22.at.5.29.26.AM.mov

MacOS: Desktop

Screen.Recording.2025-04-22.at.2.42.43.PM.mov

melvin-bot · 2025-04-22T10:19:28Z

@mananjadhav Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

francoisl · 2025-04-22T18:30:48Z

@mananjadhav would you be able to prioritize reviewing this one please? It fixes a bunch of issues blocking us from releasing this feature. Thanks! 🙌

Also, there are a few conflicts @allroundexperts

mananjadhav · 2025-04-23T05:03:24Z

Started reviewing.

src/libs/OptionsListUtils.ts

mananjadhav · 2025-05-01T20:13:01Z

@mananjadhav I don't see verification on test 3. Would you mind retesting please, or sharing how you verified? thanks

Looks like I missed. I don't see Manager McTest at all in the display list.

mananjadhav · 2025-05-02T17:15:13Z

@allroundexperts There's a conflict in the PR. Also can you also verify the test step 3 at youe ned?

allroundexperts · 2025-05-05T09:10:10Z

@allroundexperts There's a conflict in the PR.

Resolved

allroundexperts · 2025-05-05T09:10:33Z

Also can you also verify the test step 3 at youe ned?

I am no longer able to reproduce it.

github-actions · 2025-05-05T16:17:44Z

🚧 @Julesssss has triggered a test app build. You can view the workflow run here.

Julesssss · 2025-05-05T16:18:13Z

I am no longer able to reproduce it.

Cool, I'll regen builds and ask for a retest.

github-actions · 2025-05-05T16:59:59Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
Android 🤖🔄	iOS 🍎🔄
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/60067-hybrid/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/60067-hybrid/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/60067/NewExpensify.dmg	https://60067.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

Julesssss · 2025-05-05T20:19:24Z

Actually this is 1/9 issues. Lets get it merged and tested and we can always submit a follow up for the 1 remaining issue which might not even be occuring.

OSBotify · 2025-05-05T20:32:35Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-05-06T01:26:08Z

🚀 Deployed to staging by https://github.com/Julesssss in version: 9.1.40-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

MonilBhavsar · 2025-05-06T05:18:37Z

src/components/MoneyRequestConfirmationListFooter.tsx

@@ -618,7 +618,7 @@ function MoneyRequestConfirmationListFooter({
                    shouldShowRightIcon
                    title={iouAttendees?.map((item) => item?.displayName ?? item?.login).join(', ')}
                    description={`${translate('iou.attendees')} ${
-                        iouAttendees?.length && iouAttendees.length > 1 ? `\u00B7 ${formattedAmountPerAttendee} ${translate('common.perPerson')}` : ''
+                        iouAttendees?.length && iouAttendees.length > 1 && formattedAmountPerAttendee ? `\u00B7 ${formattedAmountPerAttendee} ${translate('common.perPerson')}` : ''


Why we removed \u00B7? Was that by purpose? It caused #61429

Good question. I don't recall. @allroundexperts do you recall?

I don't remember that. I think this was removed by mistake.

Julesssss · 2025-05-06T15:29:43Z

This was a large feature with many components. Rather than revert I have simply switched the feature flag back off for now. #61501

github-actions · 2025-05-07T00:06:52Z

🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.1.40-7 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	failure ❌

fix the bugs

eb4c247

allroundexperts added 10 commits April 18, 2025 02:07

Merge branch 'main' into feat-44725-followups

547a43f

prettier

a457f7b

add missing canBeMissing

b902652

more finetunings

1eb8cd6

lint

b5d4b6f

lint

27a5ef4

Merge branch 'main' into feat-44725-followups

86d8020

lint errors

72c0d53

lint errors

17d990a

lint errors

2afd300

allroundexperts marked this pull request as ready for review April 22, 2025 10:19

allroundexperts requested a review from a team as a code owner April 22, 2025 10:19

melvin-bot bot requested review from mananjadhav and removed request for a team April 22, 2025 10:19

mananjadhav reviewed Apr 23, 2025

View reviewed changes

src/libs/OptionsListUtils.ts Show resolved Hide resolved

mananjadhav reviewed Apr 23, 2025

View reviewed changes

src/libs/OptionsListUtils.ts Outdated Show resolved Hide resolved

Merge branch 'main' into feat-44725-followups

c97d9d7

allroundexperts dismissed Julesssss’s stale review via c97d9d7 May 1, 2025 19:25

prettier

1d36b75

Merge branch 'main' into feat-44725-followups

eec206f

Julesssss approved these changes May 5, 2025

View reviewed changes

Julesssss merged commit 7afd209 into Expensify:main May 5, 2025
16 checks passed

github-actions bot mentioned this pull request May 6, 2025

Deploy Checklist: New Expensify 2025-05-06 #61424

Closed

77 tasks

MonilBhavsar reviewed May 6, 2025

View reviewed changes

jponikarchuk mentioned this pull request May 6, 2025

[$250] Expense - Manager McTest does not appear on the Attendees list #61468

Closed

8 tasks

mitarachim mentioned this pull request May 6, 2025

[$250] Attendees field is missing on the confirmation page when creating per diem expense from FAB #61491

Closed

8 tasks

Julesssss mentioned this pull request May 6, 2025

[NO QA] Disable attendee feature until next release #61501

Merged

50 tasks

Track Expense - Polish #60067

Track Expense - Polish #60067

Uh oh!

Conversation

allroundexperts commented Apr 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Apr 22, 2025

Uh oh!

francoisl commented Apr 22, 2025

Uh oh!

mananjadhav commented Apr 23, 2025

Uh oh!

Uh oh!

Uh oh!

mananjadhav commented May 1, 2025

Uh oh!

mananjadhav commented May 2, 2025

Uh oh!

allroundexperts commented May 5, 2025

Uh oh!

allroundexperts commented May 5, 2025

Uh oh!

github-actions bot commented May 5, 2025

Uh oh!

Julesssss commented May 5, 2025

Uh oh!

github-actions bot commented May 5, 2025

Uh oh!

Julesssss commented May 5, 2025

Uh oh!

Uh oh!

OSBotify commented May 5, 2025

Uh oh!

github-actions bot commented May 6, 2025

Uh oh!

MonilBhavsar May 6, 2025

Choose a reason for hiding this comment

Uh oh!

Julesssss May 6, 2025

Choose a reason for hiding this comment

Uh oh!

allroundexperts May 6, 2025

Choose a reason for hiding this comment

Uh oh!

Julesssss commented May 6, 2025

Uh oh!

github-actions bot commented May 7, 2025

Uh oh!

Uh oh!

allroundexperts commented Apr 10, 2025 •

edited

Loading