Skip to content

Attendees - Attendees field is absent on invoice confirmation page but present in invoice thread #59602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
8 tasks done
vincdargento opened this issue Apr 3, 2025 · 19 comments · Fixed by #60067
Closed
8 tasks done
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Reviewing Has a PR in review Weekly KSv2

Comments

@vincdargento
Copy link

vincdargento commented Apr 3, 2025

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.1.23-1
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Mac 15.3 / Chrome
App Component: Other

Action Performed:

Precondition:

  • Workspace has enabled invoicing.
  1. Go to staging.new.expensify.com
  2. Go to FAB > Send invoice.
  3. Enter amount > Next.
  4. Select a new user with no previous chat.
  5. Click Show more.
  6. Note that there is no Attendees field on the confirmation page.
  7. Submit the invoice.
  8. Go to invoice thread.
  9. Note that Attendees field is present in invoice thread.

Expected Result:

Attendees field should be present or absent on both invoice confirmation page and invoice thread.

Actual Result:

Attendees field is absent on invoice confirmation page but present in invoice thread.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

bug.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @allroundexperts
@vincdargento vincdargento added Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 DeployBlockerCash This issue or pull request should block deployment labels Apr 3, 2025
Copy link

melvin-bot bot commented Apr 3, 2025

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Apr 3, 2025

Triggered auto assignment to @MonilBhavsar (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Apr 3, 2025

💬 A slack conversation has been started in #expensify-open-source

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Apr 3, 2025
Copy link
Contributor

github-actions bot commented Apr 3, 2025

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@vincdargento
Copy link
Author

@zanyrenney FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

@MonilBhavsar
Copy link
Contributor

Found the bug. Commented on the PR https://github.com/Expensify/App/pull/58120/files#r2027515540

@MonilBhavsar
Copy link
Contributor

Discussed here https://expensify.slack.com/archives/C01GTK53T8Q/p1743699449593819
Have a PR up, but there are other blockers stemming from that PR and they all are going to be fixed in a single PR

@zanyrenney
Copy link
Contributor

Thanks @MonilBhavsar

@francoisl
Copy link
Contributor

We're CP'ing a PR to hide the attendee selector, I'm going to remove the blocker label and keep this open as an issue to fix later.

@francoisl francoisl removed the DeployBlockerCash This issue or pull request should block deployment label Apr 3, 2025
@MonilBhavsar MonilBhavsar added Daily KSv2 and removed Hourly KSv2 labels Apr 3, 2025
@MonilBhavsar
Copy link
Contributor

Thanks! Will make it daily then

@melvin-bot melvin-bot bot added the Overdue label Apr 7, 2025
Copy link

melvin-bot bot commented Apr 7, 2025

@allroundexperts, @MonilBhavsar, @zanyrenney Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

Copy link

melvin-bot bot commented Apr 9, 2025

@allroundexperts Huh... This is 4 days overdue. Who can take care of this?

@zanyrenney
Copy link
Contributor

@zanyrenney
Copy link
Contributor

This seems like a quality issue where the UI is not matching

@mallenexpensify
Copy link
Contributor

Starting at LOW cuz this seems like an edge case. Bump up status and/or tag me if you think it should be higher.

We're CP'ing a PR to hide the attendee selector, I'm going to remove the blocker label and keep this open as an issue to fix later.

Is attendees behind a beta? I don't see if my Expensify Inc. workspace and I thought we had them enabled in OldDot

Image

@allroundexperts
Copy link
Contributor

This is being handled here. Let's keep an eye on the PR and see when it gets merged. Currently it's waiting on backend changes from @francoisl

Copy link

melvin-bot bot commented Apr 17, 2025

@allroundexperts @MonilBhavsar @zanyrenney this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

Copy link

melvin-bot bot commented Apr 22, 2025

@allroundexperts Huh... This is 4 days overdue. Who can take care of this?

@melvin-bot melvin-bot bot added Overdue Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 Overdue labels Apr 22, 2025
@Julesssss Julesssss assigned Julesssss and unassigned MonilBhavsar Apr 30, 2025
@Julesssss
Copy link
Contributor

PR undergoing pre-merge testing by QA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Reviewing Has a PR in review Weekly KSv2
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

7 participants