Skip to content

[$250] Attendees - Selected attendee is cleared after creating Scan/Distance/Per diem expense #59631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
6 of 8 tasks
vincdargento opened this issue Apr 3, 2025 · 23 comments · Fixed by #60067
Closed
6 of 8 tasks
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Engineering External Added to denote the issue can be worked on by a contributor Reviewing Has a PR in review Weekly KSv2

Comments

@vincdargento
Copy link

vincdargento commented Apr 3, 2025

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.1.23-2
Reproducible in staging?: Yes
Reproducible in production?: Unable to check
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: No, reproducible on hybrid only
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Mac 15.3 / Chrome
App Component: Money Requests

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to workspace chat.
  3. Click + > Create expense > Distance.
  4. Enter waypoints > Next.
  5. On confirmation page, click Show more.
  6. Note that Attendees field has yourself selected.
  7. Create the expense.
  8. Go to transaction thread.

Expected Result:

Attendees field in the transaction thread will retain the selection on the confirmation page.

Actual Result:

Attendees field in the transaction thread is cleared.

This issue happens with Scan, Distance and Per diem expense.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

bug.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021907932172983504516
  • Upwork Job ID: 1907932172983504516
  • Last Price Increase: 2025-04-03
Issue OwnerCurrent Issue Owner: @allroundexperts
@vincdargento vincdargento added Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 DeployBlockerCash This issue or pull request should block deployment labels Apr 3, 2025
Copy link

melvin-bot bot commented Apr 3, 2025

Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Apr 3, 2025

Triggered auto assignment to @marcaaron (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Apr 3, 2025

💬 A slack conversation has been started in #expensify-open-source

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Apr 3, 2025
Copy link
Contributor

github-actions bot commented Apr 3, 2025

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@vincdargento
Copy link
Author

@lschurr FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Hourly KSv2 labels Apr 3, 2025
@francoisl
Copy link
Contributor

We're CP'ing a PR to hide the attendee selector, I'm going to remove the blocker label and keep this open as an issue to fix later.

@francoisl francoisl added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment labels Apr 3, 2025
@marcaaron marcaaron removed their assignment Apr 3, 2025
@marcaaron marcaaron added External Added to denote the issue can be worked on by a contributor and removed Reviewing Has a PR in review labels Apr 3, 2025
@melvin-bot melvin-bot bot changed the title Attendees - Selected attendee is cleared after creating Scan/Distance/Per diem expense [$250] Attendees - Selected attendee is cleared after creating Scan/Distance/Per diem expense Apr 3, 2025
Copy link

melvin-bot bot commented Apr 3, 2025

Job added to Upwork: https://www.upwork.com/jobs/~021907932172983504516

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Apr 3, 2025
Copy link

melvin-bot bot commented Apr 3, 2025

Triggered auto assignment to Contributor-plus team member for initial proposal review - @alitoshmatov (External)

@melvin-bot melvin-bot bot removed the Weekly KSv2 label Apr 3, 2025
@melvin-bot melvin-bot bot added Weekly KSv2 and removed Help Wanted Apply this label when an issue is open to proposals by contributors Weekly KSv2 labels Apr 8, 2025
@melvin-bot melvin-bot bot changed the title [Due for payment 2025-04-14] [$250] Attendees - Selected attendee is cleared after creating Scan/Distance/Per diem expense [Due for payment 2025-04-16] [Due for payment 2025-04-14] [$250] Attendees - Selected attendee is cleared after creating Scan/Distance/Per diem expense Apr 9, 2025
Copy link

melvin-bot bot commented Apr 9, 2025

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.24-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-04-16. 🎊

For reference, here are some details about the assignees on this issue:

Copy link

melvin-bot bot commented Apr 9, 2025

@allroundexperts / @alitoshmatov @lschurr @allroundexperts / @alitoshmatov The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

@lschurr lschurr changed the title [Due for payment 2025-04-16] [Due for payment 2025-04-14] [$250] Attendees - Selected attendee is cleared after creating Scan/Distance/Per diem expense [Due for payment 2025-04-16][$250] Attendees - Selected attendee is cleared after creating Scan/Distance/Per diem expense Apr 10, 2025
@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Apr 14, 2025
Copy link

melvin-bot bot commented Apr 16, 2025

### Payment Summary
Upwork Job
- Reviewer: @allroundexperts owed $250 via NewDot
- Reviewer: @alitoshmatov owed $250 via NewDot

BugZero Checklist (@lschurr)

  • I have verified the correct assignees and roles are listed above and updated the necessary manual offers
  • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1907932172983504516/hired)
  • I have paid out the Upwork contracts or cancelled the ones that are incorrect
  • I have verified the payment summary above is correct

@melvin-bot melvin-bot bot added the Overdue label Apr 16, 2025
@lschurr
Copy link
Contributor

lschurr commented Apr 16, 2025

Just confirming, the PR linked was only actioned by @fedirjh and @francoisl

That means no payment is due to the others tagged in this GH right? @alitoshmatov @alitoshmatov

@melvin-bot melvin-bot bot removed the Overdue label Apr 16, 2025
@alitoshmatov
Copy link
Contributor

Right

@lschurr
Copy link
Contributor

lschurr commented Apr 16, 2025

Corrected payment summary:

  • Contributor: $250 @fedirjh (please request via NewDot)

@lschurr lschurr closed this as completed Apr 16, 2025
@allroundexperts
Copy link
Contributor

@lschurr This is actually not completed yet. We're still fixing this in a follow up PR.

@lschurr
Copy link
Contributor

lschurr commented Apr 16, 2025

Alright, reopening.

@lschurr lschurr reopened this Apr 16, 2025
@lschurr lschurr changed the title [Due for payment 2025-04-16][$250] Attendees - Selected attendee is cleared after creating Scan/Distance/Per diem expense [$250] Attendees - Selected attendee is cleared after creating Scan/Distance/Per diem expense Apr 16, 2025
@allroundexperts
Copy link
Contributor

#60067 is fixing this.

Copy link

melvin-bot bot commented Apr 22, 2025

@allroundexperts Huh... This is 4 days overdue. Who can take care of this?

@melvin-bot melvin-bot bot added Overdue Reviewing Has a PR in review Weekly KSv2 and removed Overdue Daily KSv2 labels Apr 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Engineering External Added to denote the issue can be worked on by a contributor Reviewing Has a PR in review Weekly KSv2
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants