[$250] Expense - Manager McTest does not appear on the Attendees list

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: v9.1.40-0
Reproducible in staging?: Yes
Reproducible in production?: Unable to check
If this was caught during regression testing, add the test name, ID and link from TestRail: #60067
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team
Device used: Android 13 / Xiaomi Poco F5, iOS 15.8 / iPhone 7 Plus, Windows 11 / Chrome
App Component: Other

Action Performed:

1. Log in with a new Gmail account
2. Finish onboarding flow
3. Create a new workspace
4. Go to workspace chat
5. Click + > Create expense > Manual
6. Enter amount > Next
7. Click Show more
8. Click Attendees
9. Verify the Manager McTest does not appear on the Attendees list

Expected Result:

Manager McTest should be appear on the Attendees list

Actual Result:

The Manager McTest does not appear on the Attendees list

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021919806712025379309
• Upwork Job ID: 1919806712025379309
• Last Price Increase: 2025-05-06

Issue Owner

Current Issue Owner: @brunovjk

[melvin-bot]

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

McTest account doesn't show in attendees list.

What is the root cause of that problem?

By default canShowManagerMcTest is false, so McTest is added as an excluded account from the list.

App/src/libs/OptionsListUtils.ts

Lines 1712 to 1718 in eda8408

	// Exclude Manager McTest if selection is made from Create or Submit flow
	[CONST.EMAIL.MANAGER_MCTEST]:
	!canShowManagerMcTest ||
	(getIsUserSubmittedExpenseOrScannedReceipt() && !userHasReportWithManagerMcTest) ||
	!Permissions.canUseManagerMcTest(config.betas) ||
	isUserInvitedToWorkspace(),
	};

What changes do you think we should make in order to solve the problem?

If we want to show the McTest in the attendees list, then we can pass canShowManagerMcTest as true from getAttendeeOptions.

App/src/libs/OptionsListUtils.ts

Lines 1897 to 1911 in eda8408

	return getValidOptions(
	{reports, personalDetails},
	{
	betas,
	selectedOptions: attendees.map((attendee) => ({...attendee, login: attendee.email})),
	excludeLogins: CONST.EXPENSIFY_EMAILS_OBJECT,
	includeOwnedWorkspaceChats,
	includeRecentReports: false,
	includeP2P,
	includeSelectedOptions: false,
	includeSelfDM: false,
	includeInvoiceRooms,
	action,
	recentAttendees: filteredRecentAttendees,
	},

we can optionally disable the tooltip in attendees list if needed

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

We can create a test for getAttendeeOptions and verify the result contains the McTest account.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021919806712025379309

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @brunovjk (External)

[stephanieelliott]

Reapplying the Bug label to get another BZ member on this as I am OOO til May 19!

[DylanDylann]

I don't think this is a bug, why should Manager McTest display on the attendee list?

cc @grgia tag you because we already worked on this feature

[melvin-bot]

@brunovjk Eep! 4 days overdue now. Issues have feelings too...

[brunovjk]

Not overdue, waiting for @grgia to confirm whether this issue is really a bug or not.

[grgia]

Not a bug.

9. Verify the Manager McTest does not appear on the Attendees list

It says not