Skip to content

Expense - Error when editing Attendee field when attendees are added from OD #61436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
7 of 8 tasks
mitarachim opened this issue May 6, 2025 · 19 comments
Open
7 of 8 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering

Comments

@mitarachim
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.1.40-0
Reproducible in staging?: Yes
Reproducible in production?: Unable to check
If this was caught during regression testing, add the test name, ID and link from TestRail: #60067
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Mac 15.3 / Chrome
App Component: Money Requests

Action Performed:

Precondition:

  • Create workspace in ND , if there's nor workspace.
  1. Go to staging.expensify.com
  2. Go to Reports.
  3. Create a report and add an expense without adding new attendees.
  4. Click on the expense, add some attendees and save it.
  5. Log in to staging.new.expensify.com with the same account.
  6. Go to workspace chat.
  7. Go to transaction thread of the expense created from OD in Step 3.
  8. Click Attendees.
  9. Unselect any attendee which is added from OD.
  10. Click Save.

Expected Result:

The new changes will be saved without error.

Actual Result:

App throws error when removing attendees that are added from OD, but the changes are still saved.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6822684_1746502278070.20250506_112853.mp4

View all open jobs on GitHub

@mitarachim mitarachim added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. DeployBlocker Indicates it should block deploying the API labels May 6, 2025
Copy link

melvin-bot bot commented May 6, 2025

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented May 6, 2025

Triggered auto assignment to @madmax330 (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented May 6, 2025

💬 A slack conversation has been started in #expensify-open-source

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels May 6, 2025
Copy link
Contributor

github-actions bot commented May 6, 2025

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@madmax330
Copy link
Contributor

I'm not able to reproduce this on staging:

Screen.Recording.2025-05-06.at.4.50.21.PM.mov

@danieldoglas
Copy link
Contributor

Removing DelployBlocker, doesn't seem related to the backend.

@danieldoglas danieldoglas removed the DeployBlocker Indicates it should block deploying the API label May 6, 2025
@yuwenmemon
Copy link
Contributor

@madmax330 I think the difference between your reproduction steps and the OP is that the OP is using attendees without already existing accounts.

@madmax330
Copy link
Contributor

Remove the blocker label per this thread: https://expensify.slack.com/archives/C01GTK53T8Q/p1746504195754449

Will investigate more tomorrow

@madmax330 madmax330 added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels May 6, 2025
@melvin-bot melvin-bot bot added the Overdue label May 9, 2025
@CortneyOfstad
Copy link
Contributor

Hey @madmax330 just checking to see where we were at with the investigation. Thanks!

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels May 9, 2025
Copy link

melvin-bot bot commented May 13, 2025

@madmax330, @CortneyOfstad Whoops! This issue is 2 days overdue. Let's get this updated quick!

@CortneyOfstad
Copy link
Contributor

Bump @madmax330 on my comment here — thanks!

@melvin-bot melvin-bot bot removed the Overdue label May 13, 2025
@CortneyOfstad
Copy link
Contributor

Not overdue

Copy link

melvin-bot bot commented May 19, 2025

@madmax330, @CortneyOfstad Whoops! This issue is 2 days overdue. Let's get this updated quick!

@madmax330
Copy link
Contributor

Sorry just getting back to this, looking now

@melvin-bot melvin-bot bot removed the Overdue label May 19, 2025
Copy link

melvin-bot bot commented May 20, 2025

@madmax330 @CortneyOfstad this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

@melvin-bot melvin-bot bot added the Overdue label May 21, 2025
Copy link

melvin-bot bot commented May 23, 2025

@madmax330, @CortneyOfstad Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@CortneyOfstad
Copy link
Contributor

Hey @madmax330 Any update on this one?

@melvin-bot melvin-bot bot removed the Overdue label May 23, 2025
Copy link

melvin-bot bot commented May 27, 2025

@madmax330, @CortneyOfstad Whoops! This issue is 2 days overdue. Let's get this updated quick!

@melvin-bot melvin-bot bot added the Overdue label May 27, 2025
@CortneyOfstad
Copy link
Contributor

Hey @madmax330 — bump ^^^ thanks!

@melvin-bot melvin-bot bot removed the Overdue label May 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering
Projects
Status: No status
Development

No branches or pull requests

5 participants