Skip to content

[Due for payment 2025-04-16] Scan - In failed scan expense selecting an attendee after scanning is complete displays error #59621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
4 of 8 tasks
jponikarchuk opened this issue Apr 3, 2025 · 16 comments · Fixed by #60067
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Engineering Reviewing Has a PR in review Weekly KSv2

Comments

@jponikarchuk
Copy link

jponikarchuk commented Apr 3, 2025

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: V9 1.23-2
Reproducible in staging?: Yes
Reproducible in production?: Unable to check, new feature
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: N
Email or phone of affected tester (no customers): Slottwo1 [email protected]
Issue reported by: Applause Internal Team
Device used: Redminote 10s android 13
App Component: Money Requests

Action Performed:

  1. Launch app
  2. Open employee workspace chat
  3. Create a scan expense and wait till scanning failed and preview shows ₹0.00
  4. Open the scan expense
  5. Tap attendees - select a attendee

Expected Result:

In failed scan expense, selecting an attendee after scanning musnt display error.

Actual Result:

In failed scan expense, selecting an attendee after scanning is over displays error " unexpected error editing this expense.Please try again later.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @strepanier03
@jponikarchuk jponikarchuk added Bug Something is broken. Auto assigns a BugZero manager. DeployBlockerCash This issue or pull request should block deployment labels Apr 3, 2025
Copy link

melvin-bot bot commented Apr 3, 2025

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Apr 3, 2025

Triggered auto assignment to @chiragsalian (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Apr 3, 2025

💬 A slack conversation has been started in #expensify-open-source

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Apr 3, 2025
Copy link
Contributor

github-actions bot commented Apr 3, 2025

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Hourly KSv2 labels Apr 3, 2025
@francoisl
Copy link
Contributor

We're CP'ing a PR to hide the attendee selector, I'm going to remove the blocker label and keep this open as an issue to fix later.

@francoisl francoisl removed the DeployBlockerCash This issue or pull request should block deployment label Apr 3, 2025
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Apr 7, 2025
@melvin-bot melvin-bot bot changed the title Scan - In failed scan expense selecting an attendee after scanning is complete displays error [Due for payment 2025-04-14] Scan - In failed scan expense selecting an attendee after scanning is complete displays error Apr 7, 2025
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Apr 7, 2025
Copy link

melvin-bot bot commented Apr 7, 2025

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Apr 7, 2025

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.23-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-04-14. 🎊

Copy link

melvin-bot bot commented Apr 7, 2025

@chiragsalian @strepanier03 @chiragsalian The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Apr 9, 2025
@melvin-bot melvin-bot bot changed the title [Due for payment 2025-04-14] Scan - In failed scan expense selecting an attendee after scanning is complete displays error [Due for payment 2025-04-16] [Due for payment 2025-04-14] Scan - In failed scan expense selecting an attendee after scanning is complete displays error Apr 9, 2025
Copy link

melvin-bot bot commented Apr 9, 2025

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.24-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-04-16. 🎊

For reference, here are some details about the assignees on this issue:

Copy link

melvin-bot bot commented Apr 9, 2025

@allroundexperts @strepanier03 @allroundexperts The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Apr 14, 2025
@strepanier03 strepanier03 changed the title [Due for payment 2025-04-16] [Due for payment 2025-04-14] Scan - In failed scan expense selecting an attendee after scanning is complete displays error [Due for payment 2025-04-16] Scan - In failed scan expense selecting an attendee after scanning is complete displays error Apr 14, 2025
Copy link

melvin-bot bot commented Apr 16, 2025

Payment Summary

Upwork Job

BugZero Checklist (@strepanier03)

  • I have verified the correct assignees and roles are listed above and updated the necessary manual offers
  • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
  • I have paid out the Upwork contracts or cancelled the ones that are incorrect
  • I have verified the payment summary above is correct

@melvin-bot melvin-bot bot added the Overdue label Apr 16, 2025
@strepanier03
Copy link
Contributor

@allroundexperts - little bump on the checklist since we can't do any payment until that's complete.

@melvin-bot melvin-bot bot removed the Overdue label Apr 16, 2025
@allroundexperts
Copy link
Contributor

@strepanier03 This is still ongoing and is not complete yet. We are fixing it in #60067. We can keep this open till that PR is merged, and then re-test this.

@strepanier03
Copy link
Contributor

Sounds good, thanks for the update.

@melvin-bot melvin-bot bot added the Overdue label Apr 21, 2025
Copy link

melvin-bot bot commented Apr 21, 2025

@strepanier03 Whoops! This issue is 2 days overdue. Let's get this updated quick!

@strepanier03
Copy link
Contributor

All good Melvin.

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Overdue Daily KSv2 labels Apr 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Engineering Reviewing Has a PR in review Weekly KSv2
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants