[READY FOR PAYMENT][$250] [Manager McTest] Try it out button is unresponsive on Android

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: v9.1.23-7
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: #58902
Email or phone of affected tester (no customers): -
Issue reported by: Applause Internal Team
Device used: Android 12
App Component: Money Requests

Action Performed:

Precondition: better to use new gmail account.

1. Tap FAB > Create expense
2. On Scan tab > tap 'Try it out'

Expected Result:

User is navigated to 'Confirm details' tab.

Actual Result:

Nothing happens.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021920698329684762723
• Upwork Job ID: 1920698329684762723
• Last Price Increase: 2025-05-09

Issue Owner

Current Issue Owner: @

[melvin-bot]

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[grgia]

Android only bug preventing users from clicking this button. May be unrelated to our changes @JKobrynski

[jliexpensify]

@grgia do you want to make this one Internal for now?

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Nothing happens.

What is the root cause of that problem?

We navigate to the confirmation page immediately

App/src/pages/iou/request/step/IOURequestStepScan/index.native.tsx

Lines 455 to 458 in 689e60c

	const managerMcTestParticipant = getManagerMcTestParticipant() ?? {};
	setMoneyRequestParticipants(transactionID, [{...managerMcTestParticipant, selected: true}]);
	navigateToConfirmationPage(true);
	return;

If the participant isn't updated completely in Onyx when we go to confirmation page, the flow is reset.

App/src/pages/iou/request/step/IOURequestStepConfirmation.tsx

Line 215 in 689e60c

if (transaction?.transactionID && (!transaction?.isFromGlobalCreate || !isEmptyObject(transaction?.participants)) && (isCurrentReportID || isMovingTransactionFromTrackExpense)) {

What changes do you think we should make in order to solve the problem?

Return a promise here

return Onyx.merge(`${ONYXKEYS.COLLECTION.TRANSACTION_DRAFT}${transactionID}`, {participants})

App/src/libs/actions/IOU.ts

Lines 929 to 931 in 689e60c

	function setMoneyRequestParticipants(transactionID: string, participants: Participant[] = []) {
	Onyx.merge(`${ONYXKEYS.COLLECTION.TRANSACTION_DRAFT}${transactionID}`, {participants});
	}

And navigate to the confirmation page after the promise is resolved.

setMoneyRequestParticipants(transactionID, [{...managerMcTestParticipant, selected: true}]).then(() => {
    navigateToConfirmationPage(true);
});

App/src/pages/iou/request/step/IOURequestStepScan/index.native.tsx

Lines 455 to 458 in 689e60c

	const managerMcTestParticipant = getManagerMcTestParticipant() ?? {};
	setMoneyRequestParticipants(transactionID, [{...managerMcTestParticipant, selected: true}]);
	navigateToConfirmationPage(true);
	return;

Optional: We can do the same on web here

App/src/pages/iou/request/step/IOURequestStepScan/index.tsx

Lines 472 to 476 in 689e60c

	if (isTestTransaction) {
	const managerMcTestParticipant = getManagerMcTestParticipant() ?? {};
	setMoneyRequestParticipants(transactionID, [{...managerMcTestParticipant, selected: true}]);
	navigateToConfirmationPage(true);
	return;

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

UI bug

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[github-actions]

⚠️ @nkdengineer Thanks for your proposal. Please update it to follow the proposal template, as proposals are only reviewed if they follow that format (note the mandatory sections).

[grgia]

Assigning @DylanDylann as C+ for tracking the last few polish issues here

[DylanDylann]

@nkdengineer's proposal looks good to me

🎀 👀 🎀 C+ Reviewed

[melvin-bot]

Current assignee @grgia is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

[grgia]

all yours @nkdengineer

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[DylanDylann]

All done, waiting for payment

cc @jliexpensify

[jliexpensify]

Ah, thanks for the bump - hmm automation failed here. @DylanDylann do we need a checklist?

[jliexpensify]

Payment Summary:

• C: @nkdengineer $250 (to be paid via Upworks)
• C+: @DylanDylann $250 (to be paid via ND requests)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021920698329684762723

[melvin-bot]

Current assignee @DylanDylann is eligible for the External assigner, not assigning anyone new.

[DylanDylann]

It is not worth adding a regression test because this seems like an improvement in performance. Let's skip it in this issue

[jliexpensify]

@nkdengineer invited you via Upworks

[jliexpensify]

Paid, job closed. Payment summary here.