Skip to content

Expense - "Try it out" button reopens Create expense RHP and two tooltips appear #60736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
6 of 8 tasks
jponikarchuk opened this issue Apr 23, 2025 · 15 comments
Closed
6 of 8 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Reviewing Has a PR in review Weekly KSv2

Comments

@jponikarchuk
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.1.32-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: No, reproducible on hybrid only
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Mac 15.3 / Chrome
App Component: Money Requests

Action Performed:

  1. Go to staging.new.expensify.com
  2. Log in with a new Gmail account.
  3. Create a new workspace.
  4. Go to workspace chat.
  5. Click + > Create expense.
  6. Click Try it out on the tooltip.
  7. Click Try it out on the tooltip again.

Expected Result:

In Step 6, after clicking Try it out button on the tooltip for the first time, app will proceed to the confirmation page.

Actual Result:

In Step 6, after clicking Try it out button on the tooltip for the first time, app reopens Create expense RHP.
In Step 7, after clicking Try it out button on the tooltip for the second time, two tooltips appear.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

@jponikarchuk jponikarchuk added Bug Something is broken. Auto assigns a BugZero manager. DeployBlockerCash This issue or pull request should block deployment labels Apr 23, 2025
Copy link

melvin-bot bot commented Apr 23, 2025

Triggered auto assignment to @laurenreidexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added the Daily KSv2 label Apr 23, 2025
Copy link

melvin-bot bot commented Apr 23, 2025

Triggered auto assignment to @amyevans (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Apr 23, 2025

💬 A slack conversation has been started in #expensify-open-source

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Apr 23, 2025
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@amyevans
Copy link
Contributor

I believe this is coming from #60479. @nkdengineer @DylanDylann @grgia could you take a look please?

@nkdengineer
Copy link
Contributor

Created a fix here #60777. The problem is IOURequestStartPage change the reportID to the previous reportID again here after we changed this

useFocusEffect(
useCallback(() => {
if (transaction?.reportID === reportID || isLoadingSelectedTab) {
return;
}

Then the flow is reset because this condition is incorrect.

const isCurrentReportID = transaction?.isFromGlobalCreate

The solution is we will change the isFromGlobalCreate to true then we can compare with the correct reportID here

cc @DylanDylann @grgia

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Hourly KSv2 labels Apr 24, 2025
@nkdengineer
Copy link
Contributor

The PR is ready.

@amyevans
Copy link
Contributor

Thanks!

@amyevans amyevans removed the DeployBlockerCash This issue or pull request should block deployment label Apr 25, 2025
@amyevans
Copy link
Contributor

We CP'ed the PR, and I requested a retest here: https://expensify.slack.com/archives/C9YU7BX5M/p1745609411393339

@amyevans
Copy link
Contributor

@nkdengineer QA retested and said on a Samsung Galaxy s10/ Android 12 the tooltip is not responsive:

Screen_Recording_20250425_230108_Expensify.mp4

@nkdengineer
Copy link
Contributor

@amyevans It looks like this is a known bug with SamSung devices that onPress is never triggered. I created a draft with the same solution. Please help to trigger a build and ask QA to retest again with this device.

// On some Samsung devices, `onPress` is never triggered.
// So, we use `onPressIn` for Android to ensure the button is pressable.
onPressIn={
getPlatform() === CONST.PLATFORM.ANDROID
? () => {
hideTooltip(true);
}
: undefined
}
// For other platforms, we stick with `onPress`.
onPress={
getPlatform() !== CONST.PLATFORM.ANDROID
? () => {

@amyevans
Copy link
Contributor

#60936 (comment) - looks like it's still reproducible unfortunately

@laurenreidexpensify
Copy link
Contributor

@nkdengineer @DylanDylann @amyevans what's the latest here?

@nkdengineer
Copy link
Contributor

I believe the original bug was fixed, we're good to close

@amyevans
Copy link
Contributor

amyevans commented May 9, 2025

Yeah we're all set here, thank you!

@amyevans amyevans closed this as completed May 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Reviewing Has a PR in review Weekly KSv2
Projects
None yet
Development

No branches or pull requests

5 participants