[CP Staging] fix try it out button #60777

nkdengineer · 2025-04-24T02:51:08Z

Explanation of Change

fix try it out button

Fixed Issues

$ #60736
PROPOSAL:

Tests

Login a new account
Complete the onboarding
Create a new workspace
Open WS chat > Plus icon > Create expense
Click on Try it out button
Verify that the confirmation page appears

Verify that no errors appear in the JS console

Offline tests

Same

QA Steps

Login a new account
Complete the onboarding
Create a new workspace
Open WS chat > Plus icon > Create expense
Click on Try it out button
Verify that the confirmation page appears

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2025-04-24.at.09.49.55.mov

Android: mWeb Chrome

Screen.Recording.2025-04-24.at.09.37.56.mov

iOS: Native

Screen.Recording.2025-04-24.at.09.41.43.mov

iOS: mWeb Safari

Screen.Recording.2025-04-24.at.09.39.03.mov

MacOS: Chrome / Safari

Screen.Recording.2025-04-24.at.09.36.35.mov

MacOS: Desktop

Screen.Recording.2025-04-24.at.09.44.40.mov

melvin-bot · 2025-04-24T02:56:29Z

@dukenv0307 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

DylanDylann · 2025-04-24T05:22:37Z

@nkdengineer With your fix, the transaction.reportID still be wrong

src/libs/actions/IOU.ts

DylanDylann · 2025-04-24T05:25:32Z

I think the main problem is that the transaction reportID was reset with the wrong value. We need to fix that to prevent other bugs in the future. Updating isFromGlobalCreate looks fine but It can't fix the RCA of this bug

nkdengineer · 2025-04-24T05:26:48Z

@nkdengineer With your fix, the transaction.reportID still be wrong

@DylanDylann

It will not be a problem, you can check the flow

Gloal FAB > Create expense > Confirmation page

In this case the transaction.reportID is also the init random reportID.

Co-authored-by: DylanDylann <[email protected]>

DylanDylann · 2025-04-24T05:35:28Z

@nkdengineer In this case, could we also update it to random reportID to align with the normal global creating flow?

amyevans · 2025-04-24T17:27:47Z

@nkdengineer friendly bump on ^

nkdengineer · 2025-04-24T17:31:51Z

@nkdengineer In this case, could we also update it to random reportID to align with the normal global creating flow?

@DylanDylann I think this is unnecessary. All data is getting from reportID param so it doesn't have any problem. Also trying to change this can cause other unexpected bug.

DylanDylann · 2025-04-25T04:45:00Z

There are two reasons why I suggest updating the correct transaction.reportID:

We should not save the wrong value in Onyx. We can't blame that we don't use it so we don't matter if that value is wrong. It is really risky if we leave the wrong value on Onyx
In this PR, we are updating isFromGlobalCreate in the setMoneyRequestParticipants function. This makes sense logically, but it goes against its name. Ideally, the setMoneyRequestParticipants function should only update the participant.

nkdengineer · 2025-04-25T09:28:14Z

@DylanDylann Updated the reportID correctly.

amyevans · 2025-04-25T13:33:08Z

@DylanDylann please review 🙏 . Would like to get this merged and cherry picked if you are happy with it

DylanDylann · 2025-04-25T18:17:35Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

Screen.Recording.2025-04-26.at.01.20.51.mov

iOS: Native

iOS: mWeb Safari

Screen.Recording.2025-04-26.at.01.21.30.mov

MacOS: Chrome / Safari

Screen.Recording.2025-04-26.at.01.16.16.mov

MacOS: Desktop

Screen.Recording.2025-04-26.at.01.15.28.mov

DylanDylann · 2025-04-25T18:19:25Z

@nkdengineer Could you please help to retest on IOS, my simulator still be failed

nkdengineer · 2025-04-25T18:23:57Z

@DylanDylann Work well.

Screen.Recording.2025-04-26.at.01.23.25.mov

amyevans

Looks good, thank you!

fix try it out button (cherry picked from commit 2ff8b81) (CP triggered by AndrewGable)

OSBotify · 2025-04-25T18:47:09Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-04-25T19:27:01Z

🚀 Cherry-picked to staging by https://github.com/AndrewGable in version: 9.1.32-7 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

github-actions · 2025-04-28T19:53:26Z

🚀 Deployed to production by https://github.com/thienlnam in version: 9.1.32-8 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

trjExpensify · 2025-04-29T16:18:02Z

👋 @nkdengineer @DylanDylann (CC: @rushatgabhane @shubham1206agra from an instance of this before here)

We have a customer reporting the bug where they go to scan a picture of a receipt and the page just refreshes after clicking the camera button. Very similar to what this PR seemingly just fixed for Manager McTest. I'm wondering if they're related, and if this PR has fixed it?

The newest prod version available from the the app store to them currently is 9.1.31-3. So a little behind where this fix was deployed to prod on 9.1.32-8.
Testing in their account on Web via Supportal works fine to navigate to the confirmation screen.

CC: @laurenreidexpensify

fix try it out button

f323fef

nkdengineer mentioned this pull request Apr 24, 2025

Expense - "Try it out" button reopens Create expense RHP and two tooltips appear #60736

Closed

8 tasks

fix lint

6e46367

nkdengineer marked this pull request as ready for review April 24, 2025 02:56

nkdengineer requested a review from a team as a code owner April 24, 2025 02:56

melvin-bot bot requested review from dukenv0307 and removed request for a team April 24, 2025 02:56

DylanDylann reviewed Apr 24, 2025

View reviewed changes

src/libs/actions/IOU.ts Outdated Show resolved Hide resolved

src/libs/actions/IOU.ts Outdated Show resolved Hide resolved

nkdengineer and others added 2 commits April 24, 2025 12:27

Update src/libs/actions/IOU.ts

e7f62fe

Co-authored-by: DylanDylann <[email protected]>

Update src/libs/actions/IOU.ts

911044c

Co-authored-by: DylanDylann <[email protected]>

amyevans removed the request for review from dukenv0307 April 24, 2025 13:24

nkdengineer added 2 commits April 25, 2025 15:25

Merge branch 'main' into fix/60736

a28bb28

updated correct transaction reportID

f05f247

nkdengineer added 2 commits April 25, 2025 16:47

fix canBeMissing

a1691e6

fix lint

9236ed2

DylanDylann approved these changes Apr 25, 2025

View reviewed changes

melvin-bot bot requested a review from amyevans April 25, 2025 18:23

amyevans approved these changes Apr 25, 2025

View reviewed changes

amyevans merged commit 2ff8b81 into Expensify:main Apr 25, 2025
17 checks passed

amyevans changed the title ~~fix try it out button~~ [CP Staging] fix try it out button Apr 25, 2025

amyevans added the CP Staging marks PRs that have been CP'd to staging label Apr 25, 2025

OSBotify pushed a commit that referenced this pull request Apr 25, 2025

Merge pull request #60777 from nkdengineer/fix/60736

b329991

fix try it out button (cherry picked from commit 2ff8b81) (CP triggered by AndrewGable)

github-actions bot mentioned this pull request Apr 25, 2025

Deploy Checklist: New Expensify 2025-04-23 #60729

Closed

91 tasks

[CP Staging] fix try it out button #60777

[CP Staging] fix try it out button #60777

Uh oh!

Conversation

nkdengineer commented Apr 24, 2025

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Apr 24, 2025

Uh oh!

DylanDylann commented Apr 24, 2025

Uh oh!

Uh oh!

Uh oh!

DylanDylann commented Apr 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nkdengineer commented Apr 24, 2025

Uh oh!

DylanDylann commented Apr 24, 2025

Uh oh!

amyevans commented Apr 24, 2025

Uh oh!

nkdengineer commented Apr 24, 2025

Uh oh!

DylanDylann commented Apr 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nkdengineer commented Apr 25, 2025

Uh oh!

amyevans commented Apr 25, 2025

Uh oh!

DylanDylann commented Apr 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

DylanDylann commented Apr 25, 2025

Uh oh!

nkdengineer commented Apr 25, 2025

Uh oh!

amyevans left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Apr 25, 2025

Uh oh!

github-actions bot commented Apr 25, 2025

Uh oh!

github-actions bot commented Apr 28, 2025

Uh oh!

trjExpensify commented Apr 29, 2025

Uh oh!

Uh oh!

DylanDylann commented Apr 24, 2025 •

edited

Loading

DylanDylann commented Apr 25, 2025 •

edited

Loading

DylanDylann commented Apr 25, 2025 •

edited

Loading