Fix/optimistic data for manager mctest scans #58902

kubabutkiewicz · 2025-03-21T12:08:30Z

Explanation of Change

Fixed Issues

$ #58644
PROPOSAL:

Tests

Make sure you are added to manager mctest beta
Make sure you are using account which didnt send any expenses previously
Go to Money Request flow
Use 'Try it out' button on Scan tab
Switch to offline mode
Send an expense
Verify that expense is in Scanning... state instead of Paid

Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."
Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

ios.mp4

iOS: mWeb Safari

MacOS: Chrome / Safari

web.mp4

MacOS: Desktop

…to fix/optimistic-data-for-manager-mctest-scans

melvin-bot · 2025-03-26T09:16:10Z

@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

DylanDylann · 2025-03-27T08:19:05Z

The change looks fine

DylanDylann · 2025-03-27T08:22:30Z

@kubabutkiewicz when creating the test scan request offline we display the wrong last actor on LHN

In this case, It should be "You" or "Dylan" like when we go back to online

Screen.Recording.2025-03-27.at.15.18.23.mov

DylanDylann · 2025-03-27T08:30:14Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2025-03-27.at.15.34.49.mov

Android: mWeb Chrome

Screen.Recording.2025-03-27.at.15.29.28.mov

iOS: Native

Screen.Recording.2025-03-27.at.15.33.38.mov

iOS: mWeb Safari

Screen.Recording.2025-03-27.at.15.27.43.mov

MacOS: Chrome / Safari

Screen.Recording.2025-03-27.at.15.18.23.mov

MacOS: Desktop

Screen.Recording.2025-03-27.at.15.32.59.mov

DylanDylann · 2025-03-27T08:40:39Z

On the manual request, I also noticed a problem related to the last actor on LHN

When offline: It displays "Manager MCTest: Manger: paid ...."
When online: It displays "You: Manger: paid ...."

IMO, on both situations, it should display: "Manager MCTest: paid ...."

Screen.Recording.2025-03-27.at.15.37.15.mov

cc @kubabutkiewicz Also pleas help to verify again with Distance request if we apply the above fix

…to fix/optimistic-data-for-manager-mctest-scans

kubabutkiewicz · 2025-03-28T09:49:21Z

@DylanDylann Pushed fix for that, also added one more fix for doubled message after going back to online
I verified also the Distance request, works well

kubabutkiewicz · 2025-03-28T09:51:58Z

On the manual request, I also noticed a problem related to the last actor on LHN
When offline: It displays "Manager MCTest: Manger: paid ...."
When online: It displays "You: Manger: paid ...."
IMO, on both situations, it should display: "Manager MCTest: paid ...."

Lets ask @grgia because if thats true we should also adjust response from the backend
For now I aligned with what is sent from BE

grgia · 2025-03-31T08:30:04Z

IMO, on both situations, it should display: "Manager MCTest: paid ...."

Yes, I agree. Let's have both use Manager McTest: paid ....

cc @aldo-expensify as you worked on the BE response here

DylanDylann · 2025-04-01T04:43:06Z

So now, we will wait for the BE update before moving forward here

cc @kubabutkiewicz @grgia

aldo-expensify · 2025-04-02T02:18:32Z

IMO, on both situations, it should display: "Manager MCTest: paid ...."

Yes, I agree. Let's have both use Manager McTest: paid ....

Is this the backend change you are waiting on? the message of the paid reportAction?

Update: yes, here it is more clear #58902 (comment) :)

aldo-expensify · 2025-04-02T02:24:29Z

I don't see the backend getting the message wrong:

It looks correct to me, like it came from "Manager McTest" (I tested in staging)

LHN:

aldo-expensify · 2025-04-02T02:25:45Z

Are you sure this is not an optimistic data issue? I logged out and in to take those screenshot, making sure there was no optimistic data anymore

kubabutkiewicz · 2025-04-02T07:07:14Z

@aldo-expensify We were talking about situation when user enter into report preview, so like on your first screenshot but we don't see LHN there 🤔

DylanDylann · 2025-04-02T07:51:54Z

@kubabutkiewicz Could you please merge the latest main? We have a new UI update that makes this bug unable to be reproduced anymore

…to fix/optimistic-data-for-manager-mctest-scans

grgia

Thank you for this!

OSBotify · 2025-04-02T12:36:59Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

aldo-expensify · 2025-04-02T17:01:35Z

@aldo-expensify We were talking about situation when user enter into report preview, so like on your first screenshot but we don't see LHN there 🤔

The LHN looks fine in that case too:

kavimuru · 2025-04-03T15:57:20Z

@kubabutkiewicz @grgia

Make sure you are added to manager mctest beta

Are applause.expensifail.com domain is beta enabled?

github-actions · 2025-04-03T16:10:54Z

🚀 Deployed to staging by https://github.com/grgia in version: 9.1.23-1 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

grgia · 2025-04-07T13:58:12Z

@kavimuru yes, beta is enabled for all accounts now

github-actions · 2025-04-07T20:31:43Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.1.23-7 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

kubabutkiewicz added 6 commits March 20, 2025 10:37

fix optimistic data for scan receipts to manager mctest

73a64f2

Merge branch 'main' of github.com:callstack-internal/Expensify-App in…

0efd21d

…to fix/optimistic-data-for-manager-mctest-scans

Merge branch 'main' of github.com:callstack-internal/Expensify-App in…

3378241

…to fix/optimistic-data-for-manager-mctest-scans

fix lint

7d2be64

Merge branch 'main' of github.com:callstack-internal/Expensify-App in…

c07d33a

…to fix/optimistic-data-for-manager-mctest-scans

fix lint

d60f499

kubabutkiewicz marked this pull request as ready for review March 26, 2025 09:16

kubabutkiewicz requested a review from a team as a code owner March 26, 2025 09:16

melvin-bot bot requested review from DylanDylann and removed request for a team March 26, 2025 09:16

kubabutkiewicz mentioned this pull request Mar 26, 2025

[Due for payment 2025-04-14] [Manager McTest] Scanning a Receipt flashes paid optimistic data instead of scan #58644

Closed

kubabutkiewicz added 3 commits March 27, 2025 10:51

Merge branch 'main' of github.com:callstack-internal/Expensify-App in…

314f71c

…to fix/optimistic-data-for-manager-mctest-scans

fix alternate text in row option

1fbc64b

Merge branch 'main' of github.com:callstack-internal/Expensify-App in…

3e75ba7

…to fix/optimistic-data-for-manager-mctest-scans

kubabutkiewicz added 2 commits April 2, 2025 09:54

removed unnecessary changes

bed460f

Merge branch 'main' of github.com:callstack-internal/Expensify-App in…

a1e278d

…to fix/optimistic-data-for-manager-mctest-scans

DylanDylann approved these changes Apr 2, 2025

View reviewed changes

melvin-bot bot requested a review from grgia April 2, 2025 10:37

grgia approved these changes Apr 2, 2025

View reviewed changes

grgia merged commit 35ab29b into Expensify:main Apr 2, 2025
17 checks passed

github-actions bot mentioned this pull request Apr 3, 2025

Deploy Checklist: New Expensify 2025-04-03 #59590

Closed

86 tasks

jponikarchuk mentioned this pull request Apr 7, 2025

[READY FOR PAYMENT][$250] [Manager McTest] Try it out button is unresponsive on Android #59742

Closed

8 tasks

Fix/optimistic data for manager mctest scans #58902

Fix/optimistic data for manager mctest scans #58902

Uh oh!

Conversation

kubabutkiewicz commented Mar 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Mar 26, 2025

Uh oh!

DylanDylann commented Mar 27, 2025

Uh oh!

DylanDylann commented Mar 27, 2025

Uh oh!

DylanDylann commented Mar 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

DylanDylann commented Mar 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kubabutkiewicz commented Mar 28, 2025

Uh oh!

kubabutkiewicz commented Mar 28, 2025

Uh oh!

grgia commented Mar 31, 2025

Uh oh!

DylanDylann commented Apr 1, 2025

Uh oh!

aldo-expensify commented Apr 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

aldo-expensify commented Apr 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

aldo-expensify commented Apr 2, 2025

Uh oh!

kubabutkiewicz commented Apr 2, 2025

Uh oh!

DylanDylann commented Apr 2, 2025

Uh oh!

grgia left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Apr 2, 2025

Uh oh!

aldo-expensify commented Apr 2, 2025

Uh oh!

kavimuru commented Apr 3, 2025

Uh oh!

github-actions bot commented Apr 3, 2025

Uh oh!

grgia commented Apr 7, 2025

Uh oh!

github-actions bot commented Apr 7, 2025

Uh oh!

Uh oh!

kubabutkiewicz commented Mar 21, 2025 •

edited

Loading

DylanDylann commented Mar 27, 2025 •

edited

Loading

DylanDylann commented Mar 27, 2025 •

edited

Loading

aldo-expensify commented Apr 2, 2025 •

edited

Loading

aldo-expensify commented Apr 2, 2025 •

edited

Loading