Fix Reports back and refresh behavior #58495

rezkiy37 · 2025-03-14T15:22:07Z

Explanation of Change

The PR fixes the "Nothing to show" bug when opening a message and returning it. Also, it changes the refresh behavior and the app does not scroll the list to the very top. Once the user reaches the very top of the list it automatically fetches updates. It prevents the list jumps when some updates have been fetched.

Fixed Issues

$ #56969
PROPOSAL: N/A

Tests

Verify that no errors appear in the JS console

Fix "Nothing to show" shown on chats

Switch to the Reports page tab (Exepnses or Chats).
Scroll down to the bottom to load all the messages.
Scroll up a bit and open any message.
Return using the device back button.
Try to keep scrolling through the list.
Verify that the user should be able to keep scrolling through the list after returning from any opened message.

Highlight newly added expense

Switch to the Reports page tab (Exepnses).
Click on FAB > Submit expense > Submit an expense.
Verify that the newly added expense appears in the table and the row is briefly highlighted to draw attention to it.
Submit an expense to the main account from another browser or device.
Verify that the newly added expense appears in the table and the row is briefly highlighted to draw attention to it.
If you’ve scrolled down, the app doesn’t automatically refresh. It only fetches updates once you’ve reached the very top.

Highlight newly added message

Switch to the Reports page tab (Chats).
Send a message to the main account from another browser or device.
Verify that the newly added message appears in the table and the row is briefly highlighted to draw attention to it.
If you’ve scrolled down, the app doesn’t automatically refresh. It only fetches updates once you’ve reached the very top.

Offline tests

Fix "Nothing to show" shown on chats

Go offline.
Switch to the Reports page tab (Exepnses or Chats).
Scroll down to the bottom to load all the messages.
Scroll up a bit and open any message.
Return using the device back button.
Try to keep scrolling through the list.
Verify that the user should be able to keep scrolling through the list after returning from any opened message.

Highlight newly added expense

Go offline.
Switch to the Reports page tab (Exepnses).
Click on FAB > Submit expense > Submit an expense.
Verify that the newly added expense appears in the table and the row is briefly highlighted to draw attention to it.
Submit an expense to the main account from another browser or device.
Go online.
Verify that the newly added expense appears in the table and the row is briefly highlighted to draw attention to it.
If you’ve scrolled down, the app doesn’t automatically refresh. It only fetches updates once you’ve reached the very top.

Highlight newly added message

Go offline.
Switch to the Reports page tab (Chats).
Send a message to the main account from another browser or device.
Go online.
Verify that the newly added message appears in the table and the row is briefly highlighted to draw attention to it.
If you’ve scrolled down, the app doesn’t automatically refresh. It only fetches updates once you’ve reached the very top.

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Verify that no errors appear in the JS console

Same as tests.

PR Author Checklist

Screenshots/Videos

Android: Native

Android.mp4

Android: mWeb Chrome

Android.Chrome.mp4

iOS: Native

IOS.mp4

iOS: mWeb Safari

IOS.Safari.mp4

MacOS: Chrome / Safari

Chrome.mp4

Chrome.Chats.mp4

Chrome.Expenses.mp4

MacOS: Desktop

Desktop.mp4

…/56969-reports-back-behavior

…on scroll to top

melvin-bot · 2025-03-17T15:44:56Z

@hungvu193 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

…croll tests

hungvu193

Looking good. I have a concern about useSearchHightlightAndScroll hook

hungvu193 · 2025-03-18T06:23:51Z

src/components/Search/index.tsx

+            return;
+        }
+
+        setOffset(0);


Would you mind adding a comment to explain this here?

Done - c51078f.

hungvu193 · 2025-03-18T06:41:50Z

src/hooks/useSearchHighlightAndScroll.ts

@@ -53,7 +55,7 @@ function useSearchHighlightAndScroll({searchResults, transactions, previousTrans
        const hasReportActionsIDsChange = !isEqual(reportActionsIDs, previousReportActionsIDs);

        // Check if there is a change in the transactions or report actions list
-        if ((!isChat && hasTransactionsIDsChange) || (isChat && hasReportActionsIDsChange)) {
+        if (isFocused && ((!isChat && hasTransactionsIDsChange) || (isChat && hasReportActionsIDsChange))) {


I believe isFocused was added here to avoid unnecessary search API calls. However, if we open a report and another person submits an expense while the report is opening, we won't receive that expense because the Search screen is not focused and search API was ignored.

Screen.Recording.2025-03-18.at.13.38.34.mov

Done - 68faf84, 66ba66b.

…ightAndScroll tests" This reverts commit 00286c1.

This reverts commit 5074e9b.

…/56969-reports-back-behavior

rezkiy37 · 2025-03-19T10:11:03Z

I've synced it up.

hungvu193 · 2025-03-19T15:22:27Z

Thanks. Reviewing shortly 👀

hungvu193 · 2025-03-19T15:31:08Z

I got crashed on Safari while trying to over scroll to the bottom, also I can still reproduce the bug 🤔

Screen.Recording.2025-03-19.at.22.29.26.mov

Screen.Recording.2025-03-19.at.22.30.33.mov

rezkiy37 · 2025-03-19T17:44:53Z

Working on the fix.

rezkiy37 · 2025-03-20T15:02:19Z

I am actively working on the fix and have a couple of ideas. Currently checking which one is better. Going to push them tomorrow.

…king

hungvu193 · 2025-03-26T03:19:07Z

Oops we have conflicts @rezkiy37

…/56969-reports-back-behavior

…r improved row visibility tracking.

…ity tracking" This reverts commit 0606ac3.

rezkiy37 · 2025-03-26T09:50:04Z

@hungvu193 They have changed the scroll component. So, I needed to reintegrate it for the newly implemented one. I think we need to do a retest round. I will do it as well.

hungvu193 · 2025-03-26T09:51:22Z

Cool. Thanks for the update!

…allback for improved row visibility tracking.

rezkiy37 · 2025-03-26T11:35:45Z

I works properly now.

hungvu193 · 2025-03-27T15:15:50Z

I'll retest again later today

…/56969-reports-back-behavior

rezkiy37 · 2025-03-27T16:47:46Z

I've synced it up and fixed conflicts.

hungvu193 · 2025-03-28T10:09:22Z

I'm again struggling with my ios build, asking for help in #expert-contributor group.

hungvu193 · 2025-03-29T08:58:11Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2025-03-24.at.10.38.27.mov

Android: mWeb Chrome

Screen.Recording.2025-03-24.at.10.47.09.mov

iOS: Native

Screen.Recording.2025-03-29.at.15.56.23.mov

iOS: mWeb Safari

safari.mov

MacOS: Chrome / Safari

Screen.Recording.2025-03-18.at.13.21.12.mov

Screen.Recording.2025-03-18.at.13.17.29.mov

MacOS: Desktop

hungvu193

LGTM

…/56969-reports-back-behavior

rezkiy37 · 2025-03-31T10:37:31Z

I've synced it up.

tgolen

Is there any possible unit test that can be added to show the bug exists and that this PR fixes it?

src/components/Search/index.tsx

…/56969-reports-back-behavior

rezkiy37 · 2025-04-01T12:28:30Z

I've synced it up.

tgolen

Thank you!

OSBotify · 2025-04-01T18:06:10Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-04-03T16:10:27Z

🚀 Deployed to staging by https://github.com/tgolen in version: 9.1.23-1 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

github-actions · 2025-04-07T20:31:16Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.1.23-7 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

rezkiy37 added 4 commits March 14, 2025 16:02

update offset handling in Search component to use dynamic value

1e050fb

incorporate focus state in search highlighting logic

e38e010

refactor: update search action import to use named import

04493a6

Merge branch 'main' of https://github.com/rezkiy37/Expensify into fix…

cb99796

…/56969-reports-back-behavior

rezkiy37 mentioned this pull request Mar 17, 2025

[Due for payment 2025-04-14] [$250] Reports - "Nothing to show" shown on chats, when opening a message and returning. #56969

Closed

8 tasks

Implement custom scroll handling in Search component to reset offset …

93ace81

…on scroll to top

rezkiy37 changed the title ~~[WIP] Fix Reports back behavior~~ Fix Reports back and refresh behavior Mar 17, 2025

rezkiy37 marked this pull request as ready for review March 17, 2025 15:44

rezkiy37 requested a review from a team as a code owner March 17, 2025 15:44

melvin-bot bot requested review from hungvu193 and removed request for a team March 17, 2025 15:44

rezkiy37 added 2 commits March 17, 2025 16:48

Mock navigation functions in unit tests for useSearchHighlightAndScroll

81f7083

Refactor import statement for search action in useSearchHighlightAndS…

00286c1

…croll tests

hungvu193 reviewed Mar 18, 2025

View reviewed changes

rezkiy37 added 3 commits March 18, 2025 11:15

added documentation for clarify

c51078f

Remove isFocused in useSearchHighlightAndScroll hook

68faf84

Remove unused mock for navigation in useSearchHighlightAndScroll tests

66ba66b

rezkiy37 requested a review from hungvu193 March 18, 2025 12:03

rezkiy37 added 5 commits March 18, 2025 13:04

Revert "Refactor import statement for search action in useSearchHighl…

cfbf596

…ightAndScroll tests" This reverts commit 00286c1.

revert import

5074e9b

Revert "revert import"

dd0baac

This reverts commit 5074e9b.

revert import

643a2ce

Merge branch 'main' of https://github.com/rezkiy37/Expensify into fix…

3f6cfd7

…/56969-reports-back-behavior

Add onViewableItemsChanged prop to SelectionList for viewability trac…

0606ac3

…king

rezkiy37 added 3 commits March 26, 2025 10:47

Merge branch 'main' of https://github.com/rezkiy37/Expensify into fix…

d4dd11e

…/56969-reports-back-behavior

Enhance SearchList component by adding onViewableItemsChanged prop fo…

51bea63

…r improved row visibility tracking.

Revert "Add onViewableItemsChanged prop to SelectionList for viewabil…

96107a8

…ity tracking" This reverts commit 0606ac3.

Refactor Search component to use a dedicated onViewableItemsChanged c…

23f32af

…allback for improved row visibility tracking.

Merge branch 'main' of https://github.com/rezkiy37/Expensify into fix…

e272354

…/56969-reports-back-behavior

hungvu193 approved these changes Mar 29, 2025

View reviewed changes

melvin-bot bot requested a review from tgolen March 29, 2025 08:58

Merge branch 'main' of https://github.com/rezkiy37/Expensify into fix…

02d9e95

…/56969-reports-back-behavior

tgolen requested changes Mar 31, 2025

View reviewed changes

src/components/Search/index.tsx Show resolved Hide resolved

src/components/Search/index.tsx Outdated Show resolved Hide resolved

rezkiy37 added 2 commits April 1, 2025 14:24

Merge branch 'main' of https://github.com/rezkiy37/Expensify into fix…

30cbd8d

…/56969-reports-back-behavior

update comment

e51b080

rezkiy37 requested a review from tgolen April 1, 2025 12:28

Enhance comment

1412d43

tgolen approved these changes Apr 1, 2025

View reviewed changes

tgolen merged commit c9387ae into Expensify:main Apr 1, 2025
18 checks passed

github-actions bot mentioned this pull request Apr 3, 2025

Deploy Checklist: New Expensify 2025-04-03 #59590

Closed

86 tasks

lanitochka17 mentioned this pull request Apr 3, 2025

[Hold for #61053][$250] Reports - New expense is not briefly highlighted in the list after expense is submitted #59449

Open

8 tasks

Fix Reports back and refresh behavior #58495

Fix Reports back and refresh behavior #58495

Uh oh!

Conversation

rezkiy37 commented Mar 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Fix "Nothing to show" shown on chats

Highlight newly added expense

Highlight newly added message

Offline tests

Fix "Nothing to show" shown on chats

Highlight newly added expense

Highlight newly added message

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Mar 17, 2025

Uh oh!

hungvu193 left a comment

Choose a reason for hiding this comment

Uh oh!

hungvu193 Mar 18, 2025

Choose a reason for hiding this comment

Uh oh!

rezkiy37 Mar 18, 2025

Choose a reason for hiding this comment

Uh oh!

hungvu193 Mar 18, 2025

Choose a reason for hiding this comment

Uh oh!

rezkiy37 Mar 18, 2025

Choose a reason for hiding this comment

Uh oh!

rezkiy37 commented Mar 19, 2025

Uh oh!

hungvu193 commented Mar 19, 2025

Uh oh!

hungvu193 commented Mar 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rezkiy37 commented Mar 19, 2025

Uh oh!

rezkiy37 commented Mar 20, 2025

Uh oh!

hungvu193 commented Mar 26, 2025

Uh oh!

rezkiy37 commented Mar 26, 2025

Uh oh!

hungvu193 commented Mar 26, 2025

Uh oh!

rezkiy37 commented Mar 26, 2025

Uh oh!

hungvu193 commented Mar 27, 2025

Uh oh!

rezkiy37 commented Mar 27, 2025

Uh oh!

hungvu193 commented Mar 28, 2025

Uh oh!

hungvu193 commented Mar 29, 2025

Reviewer Checklist

Screenshots/Videos

Uh oh!

hungvu193 left a comment

Choose a reason for hiding this comment

Uh oh!

rezkiy37 commented Mar 31, 2025

Uh oh!

tgolen left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

rezkiy37 commented Apr 1, 2025

Uh oh!

tgolen left a comment

Choose a reason for hiding this comment

rezkiy37 commented Mar 14, 2025 •

edited

Loading

hungvu193 commented Mar 19, 2025 •

edited

Loading