Add ach cancelled action #58674

heekinho · 2025-03-19T01:59:00Z

Explanation of Change

Fixed Issues

https://github.com/Expensify/Expensify/issues/408738

PROPOSAL: https://github.com/Expensify/Expensify/issues/408738#issuecomment-2733992891

Include support for the cancellation update messages when cancelling payments using the "Pay $x with Expensify".
Right now no messages are being delivered when cancelling payments originated from that option.
We should add support so it works the same way as when paying with "Pay $x elsewhere"

The following video show how it is main (cancellation messages for Pay with Expensify are not delivered)

Screen.Recording.2025-03-19.at.19.33.09.mov

The following video show the alternate path (Pay elsewhere), where the message gets delivered. Then we try the "Pay with Expensify" one more time to confirm it.

Screen.Recording.2025-03-19.at.19.34.23.mov

Technical Explanation

When cancelling a payment made with "Pay elsewhere" it generates an ACTION_REIMBURSEMENT_DEQUEUED.
When cancelling a payment made with "Pay with expensify", it generates an ACTION_REIMBURSEMENT_ACH_CANCELED.

Right now only ACTION_REIMBURSEMENT_DEQUEUED is supported in App.
We need to add support to ACTION_REIMBURSEMENT_ACH_CANCELED in App so that it can be properly recognized.
This PR mainly adds support for that action type as a possible report action, and just renames a bunch of variables so context is clear for future readers.

The following video show the fixed version after applying this PR, with the messages being properly delivered.

Screen.Recording.2025-03-19.at.19.53.55.mov

Tests

Verify that no errors appear in the JS console

Offline tests

QA Steps

Given an user A with created bank accounts and a created workspace
Given an user B as a member of that workspace
User B should submit an expense ($10 for this test)
The expense will show in the workspace and User A should aprove it
Select "Pay $10 with Expensify" in the green pay button
Click on the header of the expense report and click on "Cancel Payment". Confirm it.
User B should see updates in real time of that action in their expense report

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

cancel-payment-android-web.mov

Android: mWeb Chrome

cancel-payment-android-web.mov

iOS: Native

cancel-payment-ios.mov

iOS: mWeb Safari

cancel-payment-ios-safari.mov

MacOS: Chrome / Safari

cancel-payment-safari.mov

MacOS: Desktop

cancel-payment-desktop.mov

src/CONST.ts

yuwenmemon · 2025-03-28T06:24:48Z

Trying to get a better gauge on moving forward with this in the Slack thread here: https://expensify.slack.com/archives/C05CBC62HGW/p1743143065626269?thread_ts=1742847300.129289&cid=C05CBC62HGW

melvin-bot · 2025-03-28T15:16:29Z

@ Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

src/CONST.ts

src/libs/OptionsListUtils.ts

src/libs/ReportActionsUtils.ts

yuwenmemon · 2025-04-02T00:03:25Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

OSBotify · 2025-04-02T00:13:20Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-04-03T16:10:39Z

🚀 Deployed to staging by https://github.com/yuwenmemon in version: 9.1.23-1 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

nlemma · 2025-04-04T11:30:32Z

@heekinho There was an issue raised here which is related to the steps in the current PR, does this PR also fix the issue raised there or is there another issue linked to it for a fix?

heekinho · 2025-04-04T11:57:42Z

Hey, @nlemma. Yes, part of the fix is here, since it will properly handle both cancel options (Paid elsewhere, paid with expensify). The second part is in this PR. I created an issue to track it: https://github.com/Expensify/Expensify/issues/487761.

vincdargento · 2025-04-04T17:31:13Z

@heekinho Testers are seeing an error when trying to cancel the payment: Auth CancelReimbursement returned an error

I found this old issue where it is stated that this is the expected behavior when using test bank account for this. Is this still the expected behavior?

bug.mp4

heekinho · 2025-04-04T17:52:22Z

Hnm, not sure if the process in staging environment is different. I assume this is expected and that still holds, since we might not have some dev tooling/bypasses (clitools bank accounts configuration and so), but I'm really not sure. Perhaps @Gonals can confirm it?

I think this is hardly a problem in the PR, though, since I'm not touching anything related to the request, only the responses.

github-actions · 2025-04-07T20:31:28Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.1.23-7 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

heekinho added 4 commits March 18, 2025 22:54

Adjust spelling so it matches Auth and Web-E

9b8f855

Add user cancel payment reason entry

a684ba4

Add helper function to check if action is a cancelled reimbursement

cf122e5

Add support for ach cancelled action when cancelling payment

97be7b1

heekinho commented Mar 19, 2025

View reviewed changes

src/CONST.ts Outdated Show resolved Hide resolved

Merge branch 'main' into add-ach-cancelled-action

10dd2cf

flodnv requested a review from yuwenmemon March 24, 2025 15:52

heekinho added 3 commits March 26, 2025 16:50

Merge branch 'main' into add-ach-cancelled-action

89362c0

Lint code

d35d29c

Adjust import issue in ReportActionItem to fix lint errors

b2106d5

heekinho marked this pull request as ready for review March 28, 2025 15:16

heekinho requested a review from a team as a code owner March 28, 2025 15:16

melvin-bot bot removed the request for review from a team March 28, 2025 15:16

yuwenmemon requested changes Mar 31, 2025

View reviewed changes

heekinho added 2 commits April 1, 2025 09:18

Merge branch 'main' into add-ach-cancelled-action

1a33e22

Adjust spelling

c5c47f2

yuwenmemon approved these changes Apr 2, 2025

View reviewed changes

yuwenmemon merged commit 256cb44 into Expensify:main Apr 2, 2025
16 checks passed

github-actions bot mentioned this pull request Apr 3, 2025

Deploy Checklist: New Expensify 2025-04-03 #59590

Closed

86 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add ach cancelled action #58674

Add ach cancelled action #58674

Uh oh!

heekinho commented Mar 19, 2025 •

edited by yuwenmemon

Loading

Uh oh!

Uh oh!

yuwenmemon commented Mar 28, 2025

Uh oh!

melvin-bot bot commented Mar 28, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

yuwenmemon commented Apr 2, 2025 •

edited

Loading

Uh oh!

Uh oh!

OSBotify commented Apr 2, 2025

Uh oh!

github-actions bot commented Apr 3, 2025

Uh oh!

nlemma commented Apr 4, 2025

Uh oh!

heekinho commented Apr 4, 2025

Uh oh!

vincdargento commented Apr 4, 2025

Uh oh!

heekinho commented Apr 4, 2025

Uh oh!

github-actions bot commented Apr 7, 2025

Uh oh!

Uh oh!

Add ach cancelled action #58674

Add ach cancelled action #58674

Uh oh!

Conversation

heekinho commented Mar 19, 2025 • edited by yuwenmemon Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Technical Explanation

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

Uh oh!

yuwenmemon commented Mar 28, 2025

Uh oh!

melvin-bot bot commented Mar 28, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

yuwenmemon commented Apr 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

Uh oh!

OSBotify commented Apr 2, 2025

Uh oh!

github-actions bot commented Apr 3, 2025

Uh oh!

nlemma commented Apr 4, 2025

Uh oh!

heekinho commented Apr 4, 2025

Uh oh!

vincdargento commented Apr 4, 2025

Uh oh!

heekinho commented Apr 4, 2025

Uh oh!

github-actions bot commented Apr 7, 2025

Uh oh!

Uh oh!

heekinho commented Mar 19, 2025 •

edited by yuwenmemon

Loading

yuwenmemon commented Apr 2, 2025 •

edited

Loading