Fix - Hybrid - Android - After downloading receipt and tapping on receipt, receipt disappears #59540

FitseTLT · 2025-04-02T14:26:03Z

Details

We normally unlink RNFetchBlob.fs.unlink after download on android native but for local receipts in expense creation flow we still need the local file to show and also create the expense with it so this PR avoids unlinking in this case.

Fixed Issues

$ #59521
PROPOSAL:

Tests

Go to workspace chat.
Tap + > Create expense > Manual.
Enter amount > Next.
On confirmation page, tap add receipt modal and add a receipt.
Tap on the receipt.
Tap 3-dot menu > Download. (On download if you are prompted whether to replace it on desktop make sure to not replace but enter a different name 👍 )
Dismiss the modal and tap app back button.
Tap on the receipt again.
Verify Receipt view will open.
Go on an create the expense and verify an expense with the appropriate receipt is created

Verify that no errors appear in the JS console

Offline tests

Same as above

QA Steps

Same as above

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

2025-04-02.17-23-22.mp4

Android: mWeb Chrome

2025-04-02.17-28-58.mp4

iOS: Native

2025-04-02.17-45-30.mp4

iOS: mWeb Safari

2025-04-02.17-32-11.mp4

MacOS: Chrome / Safari

2025-04-02.17-31-23.mp4

MacOS: Desktop

2025-04-02.17-33-10.mp4

melvin-bot · 2025-04-02T14:26:09Z

@getusha Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

FitseTLT · 2025-04-02T14:26:18Z

cc @brunovjk @cristipaval

brunovjk · 2025-04-02T16:01:36Z

@FitseTLT on android and web_chrome is looking good:

Android: Native

59540_android_native.mov

MacOS: Chrome / Safari

59540_web_chrome.mov

But on desktop it's not right, when downloading the receipt > going back to the confirmation page > clicking on the receipt again, instead of opening the receipt modal we go to the page to replace it. Can you reproduce it? Am I doing something wrong? I have to leave now, when I get there I'll come back here.

MacOS: Desktop

59540_web_desktop.mov

brunovjk · 2025-04-02T16:35:20Z

@FitseTLT I'm finding this issue a bit strange, I don't think it was introduced exclusively by our PR, because we would have caught it in our tests. Anyway, let's fix it hehe

FitseTLT · 2025-04-02T17:01:23Z

@brunovjk This is expected behavior BTW. When you choose to replace the file the current receipt will be deleted that is why it is prompting you to re-add the receipt. cc @cristipaval

2025-04-02.20-00-03.mp4

brunovjk · 2025-04-02T21:41:00Z

I see, I'm not trying to replace the receipt in the app, just on my PC, this shouldn't happen, I think, since this doesn't happen on other platforms, only on desktop. However, I tested it in the last main, and I was also able to reproduce as well, I'll continue with the checklist. Should we open a discussion on Slack, what do you think? I saw that you updated the PR test steps, very good Thanks.

MacOS: Desktop - This PR

59540.mov

MacOS: Desktop - main v9.1.22-5

main.mov

FitseTLT · 2025-04-02T21:57:29Z

I see, I'm not trying to replace the receipt in the app, just on my PC, this shouldn't happen, I think, since this doesn't happen on other platforms, only on desktop. However, I tested it in the last main, and I was also able to reproduce as well, I'll continue with the checklist. Should we open a discussion on Slack, what do you think? I saw that you updated the PR test steps, very good Thanks.

MacOS: Desktop - This PR
59540.mov
MacOS: Desktop - main v9.1.22-5
main.mov

@brunovjk Other platforms by default save the file with other name like adding (1) and so on and the file doesn't get replaced but in this case when you press replace it means that the previous file will be deleted and the app doesn't hold its own copy of the file so it can no more read the file and I have added a code that takes you to the creation flow if this happens here

App/src/pages/TransactionReceiptPage.tsx

Lines 71 to 90 in 3f7933f

    
           navigateToStartStepIfScanFileCannotBeRead( 
        
               receiptFilename, 
        
               receiptPath, 
        
               () => {}, 
        
               requestType, 
        
               iouType, 
        
               transactionID, 
        
               reportID, 
        
               receiptType, 
        
               () => 
        
                   Navigation.goBack( 
        
                       ROUTES.MONEY_REQUEST_STEP_SCAN.getRoute( 
        
                           CONST.IOU.ACTION.CREATE, 
        
                           iouType, 
        
                           transactionID, 
        
                           reportID, 
        
                           ROUTES.MONEY_REQUEST_STEP_CONFIRMATION.getRoute(action, iouType, transactionID, reportID), 
        
                       ), 
        
                   ), 
        
           );

Even if you comment out this code the app will crash trying to confirm the expense here it is

2025-04-03.00-56-01.mp4

If the user wants to save it then it has to be as a new file but if they replace the first one it is expected that we should restart the flow. 👍

brunovjk · 2025-04-02T22:01:29Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

59540_android_native.mov

Android: mWeb Chrome

59540_android_web.mov

iOS: Native

59540_ios_native.mov

iOS: mWeb Safari

59540_ios_web.mov

MacOS: Chrome / Safari

59540_web_chrome.mov

MacOS: Desktop

59540_web_desktop.mov

brunovjk · 2025-04-02T22:02:56Z

Great @FitseTLT Thank you very much for clarifying!!! 🚀

brunovjk

LGTM

OSBotify · 2025-04-03T07:43:58Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-04-03T16:12:33Z

🚀 Deployed to staging by https://github.com/cristipaval in version: 9.1.23-1 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

github-actions · 2025-04-07T20:33:34Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.1.23-7 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

avoid unlinking for local receipt file download

a832ba4

FitseTLT requested a review from a team as a code owner April 2, 2025 14:26

melvin-bot bot requested review from getusha and removed request for a team April 2, 2025 14:26

cristipaval requested review from brunovjk and removed request for getusha April 2, 2025 14:27

lint fix

3f7933f

brunovjk approved these changes Apr 2, 2025

View reviewed changes

melvin-bot bot requested a review from cristipaval April 2, 2025 22:55

cristipaval approved these changes Apr 3, 2025

View reviewed changes

cristipaval merged commit eb4e249 into Expensify:main Apr 3, 2025
19 checks passed

github-actions bot mentioned this pull request Apr 3, 2025

Deploy Checklist: New Expensify 2025-04-03 #59590

Closed

86 tasks

melvin-bot bot mentioned this pull request Apr 7, 2025

[Due for payment 2025-04-14] Hybrid - Android - After downloading receipt and tapping on receipt, receipt disappears #59521

Closed

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix - Hybrid - Android - After downloading receipt and tapping on receipt, receipt disappears #59540

Fix - Hybrid - Android - After downloading receipt and tapping on receipt, receipt disappears #59540

Uh oh!

FitseTLT commented Apr 2, 2025 •

edited

Loading

Uh oh!

melvin-bot bot commented Apr 2, 2025

Uh oh!

FitseTLT commented Apr 2, 2025

Uh oh!

brunovjk commented Apr 2, 2025 •

edited

Loading

Uh oh!

brunovjk commented Apr 2, 2025

Uh oh!

FitseTLT commented Apr 2, 2025

Uh oh!

brunovjk commented Apr 2, 2025 •

edited

Loading

Uh oh!

FitseTLT commented Apr 2, 2025

Uh oh!

brunovjk commented Apr 2, 2025 •

edited

Loading

Uh oh!

brunovjk commented Apr 2, 2025

Uh oh!

brunovjk left a comment

Uh oh!

Uh oh!

OSBotify commented Apr 3, 2025

Uh oh!

github-actions bot commented Apr 3, 2025

Uh oh!

github-actions bot commented Apr 7, 2025

Uh oh!

Uh oh!

Fix - Hybrid - Android - After downloading receipt and tapping on receipt, receipt disappears #59540

Fix - Hybrid - Android - After downloading receipt and tapping on receipt, receipt disappears #59540

Uh oh!

Conversation

FitseTLT commented Apr 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Apr 2, 2025

Uh oh!

FitseTLT commented Apr 2, 2025

Uh oh!

brunovjk commented Apr 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

brunovjk commented Apr 2, 2025

Uh oh!

FitseTLT commented Apr 2, 2025

Uh oh!

brunovjk commented Apr 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

FitseTLT commented Apr 2, 2025

Uh oh!

brunovjk commented Apr 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

brunovjk commented Apr 2, 2025

Uh oh!

brunovjk left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Apr 3, 2025

Uh oh!

github-actions bot commented Apr 3, 2025

Uh oh!

github-actions bot commented Apr 7, 2025

Uh oh!

Uh oh!

FitseTLT commented Apr 2, 2025 •

edited

Loading

brunovjk commented Apr 2, 2025 •

edited

Loading

brunovjk commented Apr 2, 2025 •

edited

Loading

brunovjk commented Apr 2, 2025 •

edited

Loading