Fix - Enable "Add approvals" by default on new Workspaces #56479

FitseTLT · 2025-02-06T20:09:45Z

Details

Fixed Issues

$ #55612
PROPOSAL: #55612 (comment)

Tests

Situation 1: introSelected value is newDotManageTeam

Sign up as a new user
Choose "Manage my team's expenses" (This create a new Workspace)
Open workspace settings
Open the Workflow tab
Verify that add approvals is enabled

Situation 2: introSelected value is empty

Sign up as a new user
Dismiss the onboarding modal
Create a workspace
Open workspace settings
Open the Workflow tab
Verify that add approvals is enabled

Situation 3: Bottom Up

As account A, send an expense to account B (Brand new account with no workspaces)
As Account B go to pay the expense with a business bank account
Verify that add approvals is enabled

Verify that no errors appear in the JS console

Offline tests

Same as above

QA Steps

Same as above

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

app.a.mp4

Android: mWeb Chrome

app.aw.mp4

iOS: Native

app.i.mp4

iOS: mWeb Safari

appr.iw.mp4

MacOS: Chrome / Safari

app.w.mp4

MacOS: Desktop

app.d.mp4

melvin-bot · 2025-02-07T18:33:56Z

@paultsimura Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

src/libs/actions/Policy/Policy.ts

tests/actions/PolicyTest.ts

tests/actions/IOUTest.ts

paultsimura · 2025-02-08T10:02:11Z

@dangrous do we want to enable workflows for every new policy, even if it won't have the "Add approvals" enabled?
Or should we enable workflows by default only when enabling "Add approvals"? And what is the BE logic for this?

paultsimura · 2025-02-10T17:09:32Z

Also @dangrous should we enable "Delay submissions" optimistically, considering it gets enabled on the BE?
If the BE logic for this switch is conditional, could you please share what we should imitate on the FE?

Screen.Recording.2025-02-10.at.18.07.38.mov

dangrous · 2025-02-10T20:28:08Z

hey @paultsimura!

@dangrous do we want to enable workflows for every new policy, even if it won't have the "Add approvals" enabled?
Or should we enable workflows by default only when enabling "Add approvals"? And what is the BE logic for this?

Workflows should only be enabled in the same cases as approvals. That is, when introSelected is newDotManageTeam, newDotLookingAround, or empty - and then in the bottom up flows. (The BE does something different now, but we're fixing it).

Also @dangrous should we enable "Delay submissions" optimistically, considering it gets enabled on the BE?
If the BE logic for this switch is conditional, could you please share what we should imitate on the FE?

Delayed submission is being handled elsewhere so no need to update it here.

Let me know if that makes sense, and if you need any other info!

paultsimura · 2025-02-10T21:30:04Z

@FitseTLT Please update the workflows logic accordingly.

FitseTLT · 2025-02-11T22:02:18Z

@FitseTLT Please update the workflows logic accordingly.

I have updated @paultsimura

dangrous · 2025-02-13T19:18:02Z

@paultsimura are you able to take another look at this one? Thanks!

paultsimura · 2025-02-13T19:19:20Z

Yes, I will review soon, thanks for the bump

src/libs/actions/Policy/Policy.ts

paultsimura · 2025-02-14T08:47:07Z

@dangrous the reason I asked about the submission is this:

Go offline
Create WS
Create an expense in this WS chat
Approve this expense
Pay the expense elsewhere
Go online
You'll get an error because on the BE, the "Delayed submission" is active for this WS, so the "Approve" shouldn't have happened without a submit (this is my understanding of the cause, at least).

Screen.Recording.2025-02-14.at.09.27.55.mov

It would be nice to be able to fully test this PR, including going back online and verifying that the offline approval flow remains in sync with the BE.

Should we hold for the other GH, or can I proceed with just offline testing as is?

dangrous · 2025-02-14T18:05:34Z

yeah let's wait for a bit - it'll be good to test fully. the backend PR that fixes everything is merged, so we're just waiting on deploy (I think we won't deploy until Monday though)

paultsimura · 2025-02-22T08:39:05Z

@dangrous I see the BE is already in Prod, but the issue is still reproducible. We should probably wait for #56367 to have the correct optimistic FE changes 🤔

dangrous · 2025-02-24T22:12:13Z

Ah, blah, there are so many related PRs here I was getting confused. Yeah I think that makes sense. Just pinged on that other issue to try to get it moving.

dangrous · 2025-03-31T14:40:30Z

@paultsimura are you able to take a look at this one today? thanks!

paultsimura · 2025-03-31T15:15:03Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android.webm

Android: mWeb Chrome

iOS: Native

Simulator.Screen.Recording.-.iPhone.16.-.2025-03-31.at.17.49.46.mp4

iOS: mWeb Safari

Simulator.Screen.Recording.-.iPhone.16.-.2025-03-31.at.17.24.35.mp4

MacOS: Chrome / Safari

Screen.Recording.2025-03-31.at.17.08.52.mov

Screen.Recording.2025-03-31.at.17.13.26.mov

MacOS: Desktop

Screen.Recording.2025-03-31.at.17.11.58.mov

paultsimura

LGTM ✔️

dangrous

This looks good! Can we just add one test to make sure these settings are set when you pick MANAGE_TEAM or LOOKING_AROUND?

dangrous

Great, thank you!

OSBotify · 2025-04-01T17:09:06Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-04-03T16:10:06Z

🚀 Deployed to staging by https://github.com/dangrous in version: 9.1.23-1 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

github-actions · 2025-04-07T20:30:49Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.1.23-7 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

enable add approvals

dba8c99

FitseTLT mentioned this pull request Feb 6, 2025

[Due for payment 2025-04-14] [$250] Enable "Add approvals" by default on new Workspaces #55612

Closed

8 tasks

enable add approvals for createWorkspaceFromIOU

0be9dab

FitseTLT marked this pull request as ready for review February 7, 2025 18:33

FitseTLT requested a review from a team as a code owner February 7, 2025 18:33

melvin-bot bot requested review from paultsimura and removed request for a team February 7, 2025 18:33

FitseTLT added 2 commits February 7, 2025 21:41

update test

ea547e2

update test

8888eea

paultsimura reviewed Feb 7, 2025

View reviewed changes

src/libs/actions/Policy/Policy.ts Outdated Show resolved Hide resolved

minor fix

1db4b91

FitseTLT requested a review from paultsimura February 7, 2025 22:29

paultsimura reviewed Feb 8, 2025

View reviewed changes

src/libs/actions/Policy/Policy.ts Outdated Show resolved Hide resolved

paultsimura reviewed Feb 8, 2025

View reviewed changes

tests/actions/PolicyTest.ts Outdated Show resolved Hide resolved

tests/actions/IOUTest.ts Outdated Show resolved Hide resolved

added test

254c408

update approval setting logic

0210ad0

paultsimura reviewed Feb 14, 2025

View reviewed changes

src/libs/actions/Policy/Policy.ts Outdated Show resolved Hide resolved

thelullabyy mentioned this pull request Feb 15, 2025

[$250] Workflows option is not enabled if workspace is created from onboarding flow #56717

Closed

8 tasks

This comment was marked as outdated.

Sign in to view

twilight2294 mentioned this pull request Feb 25, 2025

[Due for payment 2025-04-16] [Due for payment 2025-04-07] Set "Delayed submission" to "Manually" by default on new Workspaces #56367

Closed

8 tasks

FitseTLT mentioned this pull request Mar 5, 2025

[$250] Workspace - Workflows are disabled for second WS, if first one is created via track expense #57708

Closed

8 tasks

FitseTLT added 3 commits March 27, 2025 16:55

Merge branch 'main' into fix-to-enable-add-approvals-by-default

d84e66d

minor fix

12d981a

update auto reporting frequency

830056c

FitseTLT requested a review from paultsimura March 27, 2025 15:00

FitseTLT added 3 commits March 27, 2025 18:42

fix test

eafb578

minor fix

e377acb

lint fix

01c3dff

paultsimura approved these changes Mar 31, 2025

View reviewed changes

dangrous requested changes Mar 31, 2025

View reviewed changes

added test

147babe

FitseTLT requested a review from dangrous April 1, 2025 11:56

dangrous approved these changes Apr 1, 2025

View reviewed changes

dangrous merged commit 01febae into Expensify:main Apr 1, 2025
16 checks passed

github-actions bot mentioned this pull request Apr 3, 2025

Deploy Checklist: New Expensify 2025-04-03 #59590

Closed

86 tasks

Fix - Enable "Add approvals" by default on new Workspaces #56479

Fix - Enable "Add approvals" by default on new Workspaces #56479

Uh oh!

Conversation

FitseTLT commented Feb 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Feb 7, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

paultsimura commented Feb 8, 2025

Uh oh!

paultsimura commented Feb 10, 2025

Uh oh!

dangrous commented Feb 10, 2025

Uh oh!

paultsimura commented Feb 10, 2025

Uh oh!

FitseTLT commented Feb 11, 2025

Uh oh!

dangrous commented Feb 13, 2025

Uh oh!

paultsimura commented Feb 13, 2025

Uh oh!

Uh oh!

paultsimura commented Feb 14, 2025

Uh oh!

dangrous commented Feb 14, 2025

Uh oh!

paultsimura commented Feb 22, 2025

Uh oh!

dangrous commented Feb 24, 2025

Uh oh!

This comment was marked as outdated.

dangrous commented Mar 31, 2025

Uh oh!

paultsimura commented Mar 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

paultsimura left a comment

Choose a reason for hiding this comment

Uh oh!

dangrous left a comment

Choose a reason for hiding this comment

Uh oh!

dangrous left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Apr 1, 2025

Uh oh!

github-actions bot commented Apr 3, 2025

Uh oh!

github-actions bot commented Apr 7, 2025

Uh oh!

Uh oh!

FitseTLT commented Feb 6, 2025 •

edited

Loading

paultsimura commented Mar 31, 2025 •

edited

Loading