-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Fix - Enable "Add approvals" by default on new Workspaces #56479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix - Enable "Add approvals" by default on new Workspaces #56479
Conversation
@paultsimura Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
@dangrous do we want to enable workflows for every new policy, even if it won't have the "Add approvals" enabled? |
Also @dangrous should we enable "Delay submissions" optimistically, considering it gets enabled on the BE? Screen.Recording.2025-02-10.at.18.07.38.mov |
hey @paultsimura!
Workflows should only be enabled in the same cases as approvals. That is, when introSelected is
Delayed submission is being handled elsewhere so no need to update it here. Let me know if that makes sense, and if you need any other info! |
@FitseTLT Please update the workflows logic accordingly. |
I have updated @paultsimura |
@paultsimura are you able to take another look at this one? Thanks! |
Yes, I will review soon, thanks for the bump |
@dangrous the reason I asked about the submission is this:
Screen.Recording.2025-02-14.at.09.27.55.movIt would be nice to be able to fully test this PR, including going back online and verifying that the offline approval flow remains in sync with the BE. Should we hold for the other GH, or can I proceed with just offline testing as is? |
yeah let's wait for a bit - it'll be good to test fully. the backend PR that fixes everything is merged, so we're just waiting on deploy (I think we won't deploy until Monday though) |
Ah, blah, there are so many related PRs here I was getting confused. Yeah I think that makes sense. Just pinged on that other issue to try to get it moving. |
This comment was marked as outdated.
This comment was marked as outdated.
@paultsimura are you able to take a look at this one today? thanks! |
Reviewer Checklist
Screenshots/VideosAndroid: NativeAndroid.webmAndroid: mWeb ChromeiOS: NativeSimulator.Screen.Recording.-.iPhone.16.-.2025-03-31.at.17.49.46.mp4iOS: mWeb SafariSimulator.Screen.Recording.-.iPhone.16.-.2025-03-31.at.17.24.35.mp4MacOS: Chrome / SafariScreen.Recording.2025-03-31.at.17.08.52.movScreen.Recording.2025-03-31.at.17.13.26.movMacOS: DesktopScreen.Recording.2025-03-31.at.17.11.58.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ✔️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good! Can we just add one test to make sure these settings are set when you pick MANAGE_TEAM or LOOKING_AROUND?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thank you!
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/dangrous in version: 9.1.23-1 🚀
|
🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.1.23-7 🚀
|
Details
Fixed Issues
$ #55612
PROPOSAL: #55612 (comment)
Tests
Situation 1: introSelected value is newDotManageTeam
Situation 2: introSelected value is empty
Situation 3: Bottom Up
Offline tests
Same as above
QA Steps
Same as above
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
app.a.mp4
Android: mWeb Chrome
app.aw.mp4
iOS: Native
app.i.mp4
iOS: mWeb Safari
appr.iw.mp4
MacOS: Chrome / Safari
app.w.mp4
MacOS: Desktop
app.d.mp4