Add close button to product training tooltips and track dismissal method #58666 #59008

ishpaul777 · 2025-03-24T19:27:23Z

Explanation of Change

Fixed Issues

$ #58663
PROPOSAL:

Tests

Verify that no errors appear in the JS console
Same as QA

Offline tests

QA Steps

Verify that no errors appear in the JS console

Sign in with new account on ND.
Verify you see a tooltip on FAB button, verify there is 'x' to dismiss the tooltip.
verify clicking on tooltip will dismiss tooltip.
Verify all other tooltips has 'x' to dismiss the tooltip

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Screen.Recording.2025-03-21.at.2.12.33.AM.mov

Android: mWeb Chrome

Screen.Recording.2025-03-21.at.3.39.11.AM.mov

iOS: Native

Screen.Recording.2025-03-21.at.3.39.11.AM.mov

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

…ishpaul777/add-x-in-tooltip""

github-actions · 2025-03-27T20:56:41Z

🚧 @francoisl has triggered a test app build. You can view the workflow run here.

src/components/ProductTrainingContext/index.tsx

melvin-bot · 2025-03-27T23:38:26Z

@allroundexperts Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ishpaul777 · 2025-03-27T23:41:56Z

@parasharrajat i still can not reproduce the issue but I have noticed that "x" is so small that sometime it does not capture the clicks properly so I added the fix for that, I just hope that it should fix that problem as well, can you please start reviewing , and then we can ask qa to confirm that if issue is still reproducable with new ad-hoc build. Thank you!

parasharrajat · 2025-03-28T14:01:21Z

Trying to get this tested on a Samsung device.

parasharrajat · 2025-03-28T14:47:01Z

@ishpaul777 Can you please request a hybird ad-hoc build here?

github-actions · 2025-03-28T15:53:22Z

🚧 @Julesssss has triggered a test app build. You can view the workflow run here.

github-actions · 2025-03-28T16:33:55Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
Android 🤖🔄	iOS 🍎🔄
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/59008-hybrid/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/59008-hybrid/index.html

Desktop 💻	Web 🕸️
N/A	N/A
N/A	N/A

👀 View the workflow run that generated this build 👀

parasharrajat · 2025-03-31T10:35:18Z

I was able to test this on Android 14 Samsung A52s which is similar to the tester model. It works great for me.

31.03.2025_15.09.40_REC.mp4

31.03.2025_15.08.25_REC.mp4

parasharrajat · 2025-03-31T11:48:23Z

@ishpaul777 I noticed that design is changed. There is more gap towards the right of close mark.

Expected	Current

ishpaul777 · 2025-03-31T12:01:32Z

@parasharrajat yes this is becuase there was no room to really touch the "x" most times I experienced the touch are not captured by the 'x' in my testing, I used the standard touchable styles of the icon button which gives pressable sizing of 40*40, @Expensify/design any thoughts on this ?

shawnborton · 2025-03-31T12:04:55Z

You should be able to extend the touchable area by using the hitSlop prop, without actually needing to change the size/dimensions of our mockups. https://reactnative.dev/docs/touchablewithoutfeedback#hitslop

Can you see if something like that will work for us?

parasharrajat · 2025-03-31T12:09:45Z

We can now remove the padding from the sides so that design looks similar if we want to keep 40px icon.

ishpaul777 · 2025-03-31T12:26:53Z

hitslop fix worked like a charm, Thanks @shawnborton

parasharrajat · 2025-03-31T12:55:57Z

I will retest this on the real Samsung device in sometime.

parasharrajat · 2025-03-31T14:14:48Z

Requested Adhoc build so that I can test on the device.

shawnborton · 2025-03-31T14:20:23Z

I can run the build quickly, hang tight...

github-actions · 2025-03-31T14:21:09Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
Android 🤖🔄	iOS 🍎🔄
❌ FAILED ❌	❌ FAILED ❌
The QR code can't be generated, because the Android build failed	The QR code can't be generated, because the iOS build failed
Desktop 💻	Web 🕸️
❌ FAILED ❌	❌ FAILED ❌
The QR code can't be generated, because the Desktop build failed	The QR code can't be generated, because the Web build failed

👀 View the workflow run that generated this build 👀

github-actions · 2025-03-31T14:21:13Z

🚧 @shawnborton has triggered a test app build. You can view the workflow run here.

github-actions · 2025-03-31T14:55:20Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
Android 🤖🔄	iOS 🍎🔄
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/59008-hybrid/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/59008-hybrid/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/59008/NewExpensify.dmg	https://59008.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

parasharrajat · 2025-03-31T16:16:13Z

Looks good on the Samsung device.

31.03.2025_21.38.17_REC.mp4

shawnborton · 2025-03-31T16:29:52Z

NAB: Is there a reason why we have two containers with different paddings? I understand that it adds up to 12px, but why not just have one container with 12px padding to make things cleaner?

CleanShot.2025-03-31.at.18.28.50.mp4

ishpaul777 · 2025-03-31T16:50:03Z

Is there a reason why we have two containers with different paddings? I understand that it adds up to 12px, but why not just have one container with 12px padding to make things cleaner?

the uppermost container has the base styles for all the tooltip across the app and the inner container has the style only the educational tooltips, I did not touched the styles for base container just added additional padding required in the inner container to minimize the code changes

shawnborton · 2025-03-31T16:54:20Z

Okay cool, that makes sense. All good on my end, let's get it into final review?

ishpaul777 · 2025-03-31T16:55:59Z

@parasharrajat Can you please do checklist

parasharrajat · 2025-03-31T16:57:19Z

I am doing it.

parasharrajat · 2025-03-31T17:20:54Z

Screenshots

🔲 iOS / native

31.03.2025_23.18.55_REC.mp4

🔲 iOS / Safari

31.03.2025_22.44.16_REC.mp4

🔲 MacOS / Desktop

31.03.2025_22.39.39_REC.mp4

🔲 MacOS / Chrome

31.03.2025_22.23.44_REC.mp4

🔲 Android / Chrome

21.03.2025_03.16.00_REC.mp4

🔲 Android / native

31.03.2025_22.47.08_REC.mp4

parasharrajat

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

🎀 👀 🎀 C+ reviewed

OSBotify · 2025-03-31T18:02:36Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-04-01T15:38:58Z

🚀 Deployed to staging by https://github.com/puneetlath in version: 9.1.22-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

…-PR58666" This reverts commit 4c4d5a5, reversing changes made to 721ef83.

[CP Staging] Revert "Merge pull request #59008 from ishpaul777/revert-59004-revert…

…ishpaul777/revert-59004-revert…"

[CP Staging] Revert "Merge pull request #59008 from ishpaul777/revert-59004-revert… (cherry picked from commit 3f97d5e) (CP triggered by cristipaval)

github-actions · 2025-04-03T11:40:20Z

🚀 Deployed to production by https://github.com/grgia in version: 9.1.22-10 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

github-actions · 2025-04-03T16:11:06Z

🚀 Deployed to staging by https://github.com/puneetlath in version: 9.1.23-1 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

github-actions · 2025-04-07T20:31:55Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.1.23-7 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

github-actions · 2025-04-10T01:19:59Z

🚀 Deployed to staging by https://github.com/puneetlath in version: 9.1.26-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

github-actions · 2025-04-11T00:04:51Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.1.26-10 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

Revert "[CP Staging] Revert "Merge pull request Expensify#58666 from …

66697bd

…ishpaul777/add-x-in-tooltip""

ishpaul777 changed the title ~~Revert "[CP Staging] Revert "Merge pull request #58666 from ishpaul777/add-x-in-tooltip""~~ Revert "Merge pull request #58666 from ishpaul777/add-x-in-tooltip"" Mar 27, 2025

ishpaul777 changed the title ~~Revert "Merge pull request #58666 from ishpaul777/add-x-in-tooltip""~~ Add close button to product training tooltips and track dismissal method #58666 Mar 27, 2025

Merge branch 'Expensify:main' into revert-59004-revert-PR58666

40658ad

This comment has been minimized.

Sign in to view

ishpaul777 added 2 commits March 28, 2025 05:04

add spacing to touch the x

fac1ec5

prettier

75bbc59

ishpaul777 commented Mar 27, 2025

View reviewed changes

src/components/ProductTrainingContext/index.tsx Outdated Show resolved Hide resolved

ishpaul777 marked this pull request as ready for review March 27, 2025 23:38

ishpaul777 requested a review from a team as a code owner March 27, 2025 23:38

melvin-bot bot requested a review from allroundexperts March 27, 2025 23:38

melvin-bot bot removed the request for review from a team March 27, 2025 23:38

add auto hit slope

093794e

puneetlath approved these changes Mar 31, 2025

View reviewed changes

parasharrajat approved these changes Mar 31, 2025

View reviewed changes

melvin-bot bot requested a review from puneetlath March 31, 2025 17:50

puneetlath approved these changes Mar 31, 2025

View reviewed changes

puneetlath merged commit 4c4d5a5 into Expensify:main Mar 31, 2025
17 of 18 checks passed

github-actions bot mentioned this pull request Apr 1, 2025

Deploy Checklist: New Expensify 2025-04-01 #59448

Closed

60 tasks

grgia added a commit that referenced this pull request Apr 3, 2025

Revert "Merge pull request #59008 from ishpaul777/revert-59004-revert…

cdc21a8

…-PR58666" This reverts commit 4c4d5a5, reversing changes made to 721ef83.

grgia added a commit that referenced this pull request Apr 3, 2025

Merge pull request #59576 from Expensify/georgia-revert-59008

3f97d5e

[CP Staging] Revert "Merge pull request #59008 from ishpaul777/revert-59004-revert…

ishpaul777 added a commit to ishpaul777/App that referenced this pull request Apr 3, 2025

Revert "[CP Staging] Revert "Merge pull request Expensify#59008 from …

5c79fcf

…ishpaul777/revert-59004-revert…"

melvin-bot bot mentioned this pull request Apr 3, 2025

[Due for payment 2025-04-18] Make tooltips dismissible #58663

Closed

github-actions bot mentioned this pull request Apr 3, 2025

Deploy Checklist: New Expensify 2025-04-03 #59590

Closed

86 tasks

github-actions bot mentioned this pull request Apr 10, 2025

Deploy Checklist: New Expensify 2025-04-10 #59968

Closed

65 tasks

Add close button to product training tooltips and track dismissal method #58666 #59008

Add close button to product training tooltips and track dismissal method #58666 #59008

Uh oh!

Conversation

ishpaul777 commented Mar 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

github-actions bot commented Mar 27, 2025

Uh oh!

This comment has been minimized.

Uh oh!

melvin-bot bot commented Mar 27, 2025

Uh oh!

ishpaul777 commented Mar 27, 2025

Uh oh!

parasharrajat commented Mar 28, 2025

Uh oh!

parasharrajat commented Mar 28, 2025

Uh oh!

github-actions bot commented Mar 28, 2025

Uh oh!

github-actions bot commented Mar 28, 2025

Uh oh!

parasharrajat commented Mar 31, 2025

Uh oh!

parasharrajat commented Mar 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ishpaul777 commented Mar 31, 2025

Uh oh!

shawnborton commented Mar 31, 2025

Uh oh!

parasharrajat commented Mar 31, 2025

Uh oh!

ishpaul777 commented Mar 31, 2025

Uh oh!

parasharrajat commented Mar 31, 2025

Uh oh!

parasharrajat commented Mar 31, 2025

Uh oh!

shawnborton commented Mar 31, 2025

Uh oh!

github-actions bot commented Mar 31, 2025

Uh oh!

github-actions bot commented Mar 31, 2025

Uh oh!

github-actions bot commented Mar 31, 2025

Uh oh!

parasharrajat commented Mar 31, 2025

Uh oh!

shawnborton commented Mar 31, 2025

Uh oh!

ishpaul777 commented Mar 31, 2025

Uh oh!

shawnborton commented Mar 31, 2025

Uh oh!

ishpaul777 commented Mar 31, 2025

Uh oh!

parasharrajat commented Mar 31, 2025

Uh oh!

parasharrajat commented Mar 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Screenshots

🔲 iOS / native

🔲 iOS / Safari

🔲 MacOS / Desktop

🔲 MacOS / Chrome

🔲 Android / Chrome

🔲 Android / native

Uh oh!

parasharrajat left a comment

Choose a reason for hiding this comment

Reviewer Checklist

ishpaul777 commented Mar 24, 2025 •

edited

Loading

parasharrajat commented Mar 31, 2025 •

edited

Loading

parasharrajat commented Mar 31, 2025 •

edited

Loading