[Due for payment 2025-04-18] Make tooltips dismissible

[puneetlath]

Part of the Tooltips for new paid plan signups project

Main issue: #55872
Doc section: https://docs.google.com/document/d/1q5m1qGAmM_9CeT-y-EpPxJKZeNC6RAjrwzc13wq3X74/edit?tab=t.0#heading=h.44waz0wo5etg

Feature Description

Add an "x" for dismissing tooltips in product.

Manual Test Steps

1. Make sure x's show on all tooltips
2. Make sure clicking the x dismisses the tooltip without opening the UI element the tooltip is pointing to
3. Make sure clicking on the UI element the tooltip is pointing to dismisses the tooltip
4. Make sure clicking the tooltip body opens the UI element the tooltip is pointing to and dismisses the tooltip
5. Make sure the tooltip stays dismissed in all scenarios when logging out and logging back in

Automated Tests

Frontend:

• Update Tests in tests/ui/components/ProductTrainingContextProvider.tsx so it passes the updated structure for nvp_dismissProductTraining
• Add a new test to check if the onyx value is populated correctly when clicking ‘x’ icon
• Add a new test for admin tooltips to verify that it only shows for admin of at least one workspace
• Add a new test to check these tooltips does not show for a migrated user.

Backend:

• Update DismissProductTrainingTest to take into account the new data structure.
• Verify storing the dismissal time separately, and the dismissedMethod.

Issue Owner

Current Issue Owner: @garrettmknight

[puneetlath]

Both BE PRs are in review.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.17-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Add close button to product training tooltips and track dismissal method #58666

If no regressions arise, payment will be issued on 2025-03-31. 🎊

For reference, here are some details about the assignees on this issue:

• @ishpaul777 requires payment through NewDot Manual Requests

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.18-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Add close button to product training tooltips and track dismissal method #58666

If no regressions arise, payment will be issued on 2025-04-02. 🎊

For reference, here are some details about the assignees on this issue:

• @ishpaul777 requires payment through NewDot Manual Requests

[parasharrajat]

I am C+ on the linked PR. Please assign @puneetlath

[melvin-bot]

Issue is ready for payment but no BZ is assigned. @garrettmknight you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

[melvin-bot]

Payment Summary

Upwork Job

• Reviewer: @parasharrajat owed $250 via NewDot
• Reviewer: @ishpaul777 owed $250 via NewDot

BugZero Checklist (@garrettmknight)

• I have verified the correct assignees and roles are listed above and updated the necessary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.22-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Add close button to product training tooltips and track dismissal method #58666
• Add close button to product training tooltips and track dismissal method #58666 #59008

If no regressions arise, payment will be issued on 2025-04-10. 🎊

For reference, here are some details about the assignees on this issue:

• @parasharrajat requires payment through NewDot Manual Requests
• @ishpaul777 requires payment through NewDot Manual Requests

[garrettmknight]

@parasharrajat please fill out the checklist and I'll pay this next week.

[parasharrajat]

New implementation. No checklist needed.

---

Regression Test Proposal

Test:

1. Sign in with new account on ND.
2. Verify you see a tooltip on FAB button, verify there is 'x' to dismiss the tooltip.
3. verify clicking on tooltip will dismiss tooltip.
4. Verify all other tooltips has 'x' to dismiss the tooltip

Do we agree 👍 or 👎

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.23-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Add close button to product training tooltips and track dismissal method #58666 #59008

If no regressions arise, payment will be issued on 2025-04-14. 🎊

For reference, here are some details about the assignees on this issue:

• @parasharrajat requires payment through NewDot Manual Requests
• @ishpaul777 requires payment through NewDot Manual Requests

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.26-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Add close button to product training tooltips and track dismissal method #58666 #59008
• Make tooltips dismissible with 'X' #59577

If no regressions arise, payment will be issued on 2025-04-18. 🎊

For reference, here are some details about the assignees on this issue:

• @parasharrajat requires payment through NewDot Manual Requests
• @ishpaul777 requires payment through NewDot Manual Requests

[melvin-bot]

Payment Summary

Upwork Job

• Reviewer: @parasharrajat owed $125 via NewDot
• Reviewer: @ishpaul777 owed $125 via NewDot

BugZero Checklist (@garrettmknight)

• I have verified the correct assignees and roles are listed above and updated the necessary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[garrettmknight]

@parasharrajat @ishpaul777 request when you're ready.

[trjExpensify]

Seems like we had a regression from the first PR which had it reverted, and then the second PR was shipped. As such, payment summary as follows:

• $250 to @parasharrajat for the C+ review
• $250 to @ishpaul777 for the PR

[ishpaul777]

@trjExpensify the regression was not from our PR but a upstream react-native bug, its still a issue that need investigation we have a issue here #59953

cc @puneetlath @parasharrajat

[puneetlath]

Yeah I agree with that. It's an upstream bug that only affects a small subset of Android devices, so I think we can pay out the full amount here.

[trjExpensify]

Fair enough, modified above accordingly.

[parasharrajat]

Payment requested as per #58663 (comment)