Deploy Checklist: New Expensify 2025-05-21

[github-actions]

Release Version: 9.1.50-0
Compare Changes: production...staging

This release contains changes from the following pull requests:

• fix: not here page when clicking attachment from email #56908
• Fix: Category and Tag "Required" switch is enabled and locked evenif all tags are disable #58052
• feat: add reimbursable toggle to create expense flow #59209
• Adjust copy for various report actions #60171
• Feat: isEmptyReport derived value #60697
• fix: error message overlaps video player when re connect #60893
• Chat - Not auto scroll to see full error message #60938
• Display scheduled call popup #60986
• fix - Do not use credentials for sending OTP on private domain onboarding flow #60990
• Fix color of top status bar when opening modals #61372
• perf: use requiresAttentionFromCurrentUser from a derived value #61586
• [No QA] Update Node to 20.19.1 for QSP #61607
• fix: pay button appears in invoice preview for sender #61659
• Update prohibited expense categories to be lowercase #61785
• Fix - The app log out the Gmail account after enter MC when adding copilot #61830
• [NoQA] Add CSpell for spelling checks [Part 5] #61835
• [No QA] Remove unused 'shouldUseNewModal' prop, clean after bottom modal migration #61838
• Add Per diem option in Expense type filter #61849
• fix: no sound when paying via QAB #61887
• add domain condition #61889
• Fix first transaction is highlighted when deleting a transaction #61893
• [NO QA] Update and rename Tax-exempt.md to Tax-Exemption.md #61922
• Fix back tooltip flickers when closing the page #62005
• perf: Refactor SearchTypeMenuPopover to improve bottom tabs switching #62030
• Fix concierge categorize message styling #62085
• Fix app opens expense report after creating unreported expense from main workspace chat #62088
• Reuse the Sidebar view on different Reports pages #62108
• [Internal QA]: Plaid bank feature #62117
• fix: room name form validation waits for Onyx reset #62130
• [No QA] Update Create-an-expense.md #62163
• fix: to field shows Unavailable workspace when sharing expense with accountant #62178
• Tooltip - Workspaces tooltip appears above Workspaces row and overlaps with Workspaces header #62195
• fix: 58957 Preserve SearchFullscreenNavigator state #62211
• fix: incorrect border color on workspace avatar in reports page #62259
• Add move option to search selected menu #62270
• [No QA][Test] OnyxDerivedTest not working as expected #62271
• fix: blinking empty state for transaction reports #62276
• Optimize useAnimatedHighlightStyle to reduce unnecessary recalculations #62285
• Use new transaction component inside reports in search #62286
• Perf: Optimize SearchStatusBar translations #62287
• fix: hide To recipient when From and To recipient are the same #62288
• Fix last payment option is not updated #62302
• Global Create - removing body text from product tour/test drive option #62321
• [No QA] Clarajones expensify card updates #62336
• Save the last visited path for the Accounts pages #62344
• fix: Refreshing Help page briefly displays we couldn't find content #62349
• Revert "fix - Chat- Next step changes when changing category" #62373
• fix: Filter Undefined options from picklists in Step 3 #62377
• Disable avatar pressable in report list item header #62382
• [No QA] Fix that current date can be missing in onyx #62398
• [NoQA] Use correct variable name after renaming #62416
• fix - Chat- Next step changes when changing category  #62426
• Fix can't use esc after completing manage team onboarding #62449
• Remove redundant employees selection #62463
• [NO QA] Add react import to tax cell #62481
• [No QA] Remove noisy log line #62492
• [CP Staging] Fix moving expenses from Search #62515
• [CP Staging] revert: add reimbursable toggle to create expense flow #62524
• [CP Staging] fix: Incorrect view button on the paid expense #62526
• [CP Staging] Close modal when we transition to move expense page from selected menu #62528
• [CP Staging] Fix blinking old type of report #62562
• [CP Staging] Fix: Not here page opens when admin clicks Move expense in member's report #62611
• [CP Staging] Revert breaking changes #62617
• [CP Staging] Revert #60171 "Adjust copy for various report actions" #62622
• 🍒 Cherry pick PR #62622 to staging 🍒 #62626
• Update submodule to latest staging #62639
• 🍒 Cherry pick PR #62639 to staging 🍒 #62644
• Bump staging to 9.1.50-0 #62654

Deploy Blockers:

• [Due for payment 2025-05-30] Expense - Expense is duplicated in the expense report after moving expense to same report #62500
• Expense - p2p expense changes to "spent", error when trying to delete expense, unable to pay #62501
• [Due for payment 2025-05-30] Reports - Bottom modal does not close after tapping Move expenses #62502
• [Due for payment 2025-05-30] [$250] Reports - Incorrect view button on the paid expense #62504
• [Due for payment 2025-05-30] [$250][$25 for offending PR link] Expense - Reimbursable is enabled in transaction thread when it is disabled on confirmation page #62506
• [$250] Reports - After moving expense and deleting all expenses, table header remains in blank page #62507
• [Due for payment 2025-05-30] Expense - "Waiting for you to pay expense" still seen after disabling "Reimbursable" option #62508
• [Due for payment 2025-05-30] Expense - No toggle for reimbursement when sharing expense with accountant #62510
• [Due for payment 2025-05-30] Invoice - Reimbursable toggle is enabled in invoice thread when it is disabled on confirm page #62511
• [Due for payment 2025-05-30] [$250] Reports - Expenses preview shown briefly when opening expenses report from header subtitle #62514
• [Due for payment 2025-05-30] Expense-Reimbursable toggle is shown for p2p expense when creating expense from iou report #62517
• [Due for payment 2025-05-30] Expense - Reimbursable toggle is disabled for member by default #62519
• [Due for payment 2025-05-30] Expense - Pay button does not disappear after disabling Reimbursable in offline mode #62521
• [Due for payment 2025-05-30] Reimbursable toggle is disabled when it is enabled on confirm page when categorizing expense #62525
• Reports - Chat bubble only appears on expense preview after opening the report #62529
• Expense-View button is displayed on expense preview instead of Pay after clearing cache #62530
• Reports - "Saved' label does not disappear after deleting saved search offline & return online #62531
• [$250] iOS - Categories - Categories icon is broken #62534
• Reports - After unholding all the expenses, "Hold" label still remains on one of the expenses #62541
• [$250] Expense Reports - Arrow is shown next to submitter on the empty report when receiver is empty #62551
• [$250] Move expense - Expense can be moved to report of deleted workspace #62552
• [$250] Reports - On removing expense, "to" field briefly appears and disappears in reports page. #62558
• [Better Expense Report View] [$250] Only the header & bottom padding of preview are highlighted after submitting expense #62560
• [Due for payment 2025-05-30] [Report Creation UI] [$250] Expense - Not here page opens when admin clicks Move expense in member's report #62575
• [Better Expense Report View] [$250] Chat bubble is always green in the expense preview when hold messages are read #62579
• [$250] Expense - The selected report is not highlighted with a checkmark on confirmation page #62601
• [$250] Expense Reports - Chat bubble only shows up on small screen and is missing on wide screen #62605
• [Due for payment 2025-05-30] Incorrecty system message for approved reports #62616
• Copy of the paying automatically report is wrong #62635

Deployer verifications:

• I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
• I checked Firebase Crashlytics for this release version and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
• I checked Firebase Crashlytics for the previous release version and verified that the release did not introduce any new crashes. More detailed instructions on this verification can be found here.
• I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

[marcaaron]

No deploy blockers!? 😓

[mvtglobally]

@marcaaron #62500

They are not adding to checklist for some reason. We already have quite a few

[mvtglobally]

Regression is at 50% completed

Blockers
#62500
#62501
#62502
#62504
#62506
#62508
#62510
#62511
#62514
#62517
#62519
#62521
#62525
#62529
#62530
#62531
#62534
#62541

[lakchote]

Demoted #62552 for this reason.

[izarutskaya]

Regression is at 87% completed

Unchecked PRs:
#56908 - pending validation on Web
#59209 - Pending validation on Desktop
#60171 - pending validation on all
#60986 - pending validation on all
#60990 - pending validation on mWeb and iOs
#61586 - pending validation on all
#61659 - failing with original bug id #61315
#61830 - pending validation on Desktop
#61887 - pending validation on all
#61889 - pending validation on all
#62085 - pending validation on Desktop
#62108 - pending validation on Desktop and ioS
#62270 - pending validation on Desktop
#62286 - pending validation on Desktop
#62288 - pending validation on Desktop
#62344 - pending validation on Desktop
#62349 - found issue #62548 Repro in Prod. Checking off
#62377 - pending validation on Desktop
#62449 - pending validation on Desktop
#62526 - pending validation on iOS
#62528 - pending on Desktop
Checking CP

[MonilBhavsar]

Checking off #60986
Reason: #60986 (comment)

[arosiclair]

#62514 fixed
#62579 demoted

[mountiny]

Demoted #62502

[arosiclair]

Demoted #62502

Wrong one I think 😅. That's still pending QA

[arosiclair]

#62530 demoted
#62501 not reproducible
#62605 demoted

[Valforte]

#62601 demoted

[mvtglobally]

Regression is completed

Blockers
#62575

Unchecked PRs:
#59209 - Multiple issues observed when running this PR. #62510, #62511, #62517, #62519 pls double check if ok to check it off
#60171 - is Failing and pending validation on Native apps
#60986 - We are blocked with this PR. Are you able to verify it internally? #60986 (comment)
#61586 - pending validation on all
#61659 - failing with original bug id #61315. Repro in PROD, checking off
#62117 - Internal QA

[arosiclair]

#59209 was reverted
#60171 NAB
#62117 is behind beta

[arosiclair]

@mvtglobally any update on those remaining items?

[francoisl]

#62616 reverted with #62622 - tested on staging, checking off

[mvtglobally]

Regression is completed

Unchecked PRs:
#60171 - is Failing with #62606 and still pending validation on Native apps
#61586 - We've not be able to consistently repro, but seems like PR is failing. Can you pls double check

[arosiclair]

We're just waiting on #60171 and #61586

[IuliiaHerets]

Regression is completed

PR #60171 - is failing with #62606, #62546 and #62635

Blockers
#62635

[mountiny]

demoted #62635

[mountiny]

checking #60171 off

[arosiclair]

Checking #62639 #62644 and #62654. iOS upload issue is fixed!

[arosiclair]