Display scheduled call popup

[parasharrajat]

Explanation of Change

Design doc

https://docs.google.com/document/d/1Q_FsNMTX9vKx_pWD75011atzJNV6kGUCBItqyHWVvaw/edit?tab=t.0#bookmark=kix.gbv1cxd24t1i

Fixed Issues

$ #59748
PROPOSAL: https://docs.google.com/document/d/1Q_FsNMTX9vKx_pWD75011atzJNV6kGUCBItqyHWVvaw/edit?tab=t.0#bookmark=kix.gbv1cxd24t1i

Tests

Prerequisites

1. Have a guide assigned account.

Steps

1. Go to #admins room of guide assigned workspace.
2. Click the Schedule Call button.
3. Check that while data is loading, a loader is shown.
4. Verify that the first available date is selected by default.
5. Select any date from the available dates.
6. Verify that slots are updated for that date.
7. Select any slot.
8. Verify that user is taken to confirmation screen.
9. Verify that selected date&time is shown in date&time row.
10. Verify clicking it takes you back to date and time selection page.
11. Click confirm on the confirmation screen, verify that it takes you to the Calendly scheduling page.
12. Verify that date and time match with the user selection, and the name and email is prefilled.
13. Book the call.
14. Go Back to app, notice that schedule call button is changed to call scheduled.
15. Clicking this button now shows the scheduled call information.
16. There are options to reschedule and cancel the call.
17. Clicking any of these buttons takes you to the Calendly page for the respective action.
18. Click Reschedule, verify that it takes you to the calendly page.
19. Reschedule the call, go back to app. Verify the call is updated.
20. Click cancel, verify that it takes you to the calendly cancel page.
21. Cancel the call, go back to the app. Verify the call is canceled and Schedule Call is visible again.

• Verify that the design matches the design doc.
• Verify that no errors appear in the JS console

Offline tests

User can not take this action while offline so we will show FullScreenOfflineLoader.

QA Steps

Prerequisites

1. Have a guide assigned account.

Steps

1. Go to #admins room of guide assigned workspace.
2. Click the Schedule Call button.
3. Check that while data is loading, a loader is shown.
4. Verify that the first available date is selected by default.
5. Select any date from the available dates.
6. Verify that slots are updated for that date.
7. Select any slot.
8. Verify that user is taken to confirmation screen.
9. Verify that selected date&time is shown in date&time row.
10. Verify clicking it takes you back to date and time selection page.
11. Click confirm on the confirmation screen, verify that it takes you to the Calendly scheduling page.
12. Verify that date and time match with the user selection, and the name and email is prefilled.
13. Book the call.
14. Go Back to app, notice that schedule call button is changed to call scheduled.
15. Clicking this button now shows the scheduled call information.
16. There are options to reschedule and cancel the call.
17. Clicking any of these buttons takes you to the Calendly page for the respective action.
18. Click Reschedule, verify that it takes you to the calendly page.
19. Reschedule the call, go back to app. Verify the call is updated.
20. Click cancel, verify that it takes you to the calendly cancel page.
21. Cancel the call, go back to the app. Verify the call is canceled and Schedule Call is visible again.

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

[melvin-bot]

Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!

[melvin-bot]

@allroundexperts Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[parasharrajat]

Any idea on how to fix this test issue?

[parasharrajat]

@MonilBhavsar Should we assign @jjcoffee here for tests given that they reviewed the first PR?

[MonilBhavsar]

Yes, sounds good to me. They also have access to the doc and probably reviewed it

[shawnborton]

Are there any screenshots or videos ready for design review?

[parasharrajat]

@shawnborton I will let you know when they are ready.

[MonilBhavsar]

A note to test this PR for all possible timezones as there is a discrepancy in timezone names returned by Calendly versus the library we use at server to convert UTC time to local time cc @parasharrajat @jjcoffee

[MonilBhavsar]

Let's 🚢 it

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[github-actions]

🚀 Deployed to staging by https://github.com/MonilBhavsar in version: 9.1.48-0 🚀

platform	result
🖥 desktop 🖥	failure ❌
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	failure ❌

[github-actions]

🚀 Deployed to staging by https://github.com/MonilBhavsar in version: 9.1.48-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	failure ❌

[izarutskaya]

Hi @parasharrajat I think we can't complete this PR as we don't have accounts with a guide assigned. I tried with Expensifail and gmail account. Let me know if I something missed.

Have a guide assigned account

[parasharrajat]

@MonilBhavsar can you please help here?

[MonilBhavsar]

@izarutskaya if you can share the email, I can assign the QA guide.
Also, if you can try appending schedule-call/book to the URL, as schedule call button is not visible consistently because of known bug

[izarutskaya]

@MonilBhavsar Thank you, I added schedule-call/book to the URL and I see Schedule call

[MonilBhavsar]

Nice! 👍
That's known, steps 3 and onwards can be verified now

[github-actions]

🚀 Deployed to staging by https://github.com/MonilBhavsar in version: 9.1.49-5 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

[izarutskaya]

@MonilBhavsar We can't verify Step 14 onwards because there is no schedule call button is changed to call scheduled

I created account for team [email protected]. Can you please assign the QA guide? We will try check PR this way

bandicam.2025-05-22.18-40-54-942.mp4

[MonilBhavsar]

[email protected] is assigned to QA guide

[MonilBhavsar]

Looks like the account in video is in newDotTalkToAISales beta and the button is overlapping with the Guide call button. That's NAB.
update: I would suggest using a gmail account that would not be on AI sales beta.

[izarutskaya]

Yes, all Expensifail account is in beta, as I remember. I don't see guide in [email protected]

Recording.3080.mp4

maybe need to try with gmail?

[MonilBhavsar]

Yes, a gmail account should work. I can help to assign QA guide to it

[izarutskaya]

@MonilBhavsar Created gmail account [email protected]
Thank you

[izarutskaya]

And this one please [email protected]

[MonilBhavsar]

@izarutskaya done

[izarutskaya]

@MonilBhavsar Seems we can't check this PR. Unfortunately we don't see guide in our accounts

Recording.3081.mp4

[MonilBhavsar]

you should be able to append schedule-call/book to the URL, and get the availability.
We do not display guides in UI in newDot

the guide is assigned as seen in oldDot

[izarutskaya]

If we add schedule-call/book to the URL, we can't verify Step 14 onwards
Check please my video and let me know if I something missed

Recording.3082.mp4

[MonilBhavsar]

I can check

[parasharrajat]

@izarutskaya Can you please make that workspace which has guide as default and try again.?

[MonilBhavsar]

Okay, I was able to QA this with a bit of workaround.

The schedule call button is being displayed only for the active workspaces, and since we can't set workspace as active in newDot, we are not being see it always.
The workaround is to logout, login in oldDot, set the workspace as active and then click on "Chat with admins" that will take you to newDot. I'll fix this bug, but NAB. Going to check this off

Screen.Recording.2025-05-22.at.9.17.04.PM.mov

[github-actions]

🚀 Deployed to production by https://github.com/arosiclair in version: 9.1.50-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅