Use new transaction component inside reports in search #62286

sumo-slonik · 2025-05-19T12:24:03Z

Explanation of Change

I added the transaction component — the same one used in the report — to the "group by report" view in the search, and refactored it to make it more flexible for potential reuse elsewhere.

Fixed Issues

$ #61512
PROPOSAL:

Tests

Go to the Search tab, then to Group by Reports, and check if the transactions are displayed correctly.

Verify that no errors appear in the JS console

Offline tests

Unnecessary

QA Steps

Same as test
// TODO: These must be filled out, or the issue title must include "[No QA]."

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

Screen.Recording.2025-05-19.at.17.05.20.mov

iOS: Native

Screen.Recording.2025-05-19.at.16.55.36.mov

iOS: mWeb Safari

Screen.Recording.2025-05-19.at.17.00.20.mov

MacOS: Chrome / Safari

Screen.Recording.2025-05-19.at.16.26.17.mov

MacOS: Desktop

Screen.Recording.2025-05-19.at.16.36.47.mov

sumo-slonik · 2025-05-19T15:13:42Z

@trjExpensify
PR is already open 💥

melvin-bot · 2025-05-19T15:13:47Z

@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

trjExpensify · 2025-05-19T15:38:02Z

Nice! If we're now using the same component, should the logic for the columns to include not be the same (apart from "Action" of course)? I noticed they're different:

Search Result:

Report:

shawnborton · 2025-05-19T15:44:45Z

That makes sense to me.

Can we double check our spacing here? It looks like these new rows have too much space between them when you view a report from Reports > Expense Reports.

Are we close to a test build? I can grab more specific feedback once we fire one up.

sumo-slonik · 2025-05-19T18:45:13Z

I prepared this component in a way that allows us to pass a list of columns we want to include depending on the context, and I’ve set it up so that the columns are the same as before. If we want to have the same columns as in the report, that’s also possible. In that case, do we also want to change the columns for the regular "Expense" tab?

shawnborton · 2025-05-19T20:00:55Z

I don't think we want to change anything about how the columns were previously working on the Reports page, do we? If anything, we want this new component to mirror what we previously had on the Reports page. There are some optimizations we want to make with columns in the future (custom columns, conditionally showing/hiding them if they are populated or not, etc) but I think we can focus on that after this.

sumo-slonik · 2025-05-20T09:39:18Z

The spacing has been fixed, and from what I understand, I kept the same column layout in the search as it was before. If you have any feedback, I’m happy to make adjustments. I think we can trigger an ad-hoc build so @shawnborton can take a look.

shawnborton · 2025-05-20T09:40:26Z

Sounds good, will trigger the build now 🚀

github-actions · 2025-05-20T09:41:04Z

🚧 @shawnborton has triggered a test app build. You can view the workflow run here.

…ent_in_search

SzymczakJ · 2025-05-20T09:38:17Z

src/components/SelectionList/Search/ReportListItem.tsx

+                                    transactionItem={transaction}
+                                    isSelected={!!transaction.isSelected}
+                                    dateColumnSize={dateColumnSize}
+                                    shouldShowTooltip


Previously TransactionListItemRow showTooltip prop was based on showTooltip. Why do we set it to always true here?

Suggested change

shouldShowTooltip

shouldShowTooltip={showTooltip}

SzymczakJ · 2025-05-20T09:41:02Z

src/components/MoneyRequestReportView/MoneyRequestReportTransactionList.tsx

@@ -260,6 +275,16 @@ function MoneyRequestReportTransactionList({report, transactions, reportActions,
                                shouldUseNarrowLayout={shouldUseNarrowLayout || isMediumScreenWidth}
                                shouldShowCheckbox={!!selectionMode?.isEnabled || isMediumScreenWidth}
                                onCheckboxPress={toggleTransaction}
+                                columns={[
+                                    CONST.REPORT.TRANSACTION_LIST.COLUMNS.RECEIPT,


Can we define this array as a const and put it at the top of the file?

SzymczakJ · 2025-05-20T09:41:53Z

src/components/SelectionList/Search/ReportListItem.tsx

+                                    shouldShowCheckbox={!!canSelectMultiple}
+                                    onCheckboxPress={() => onCheckboxPress?.(transaction as unknown as TItem)}
+                                    columns={[
+                                        CONST.REPORT.TRANSACTION_LIST.COLUMNS.RECEIPT,


Same here ☝️

shawnborton · 2025-05-20T10:45:16Z

Looks like the column headers don't line up with the report table content:

shawnborton · 2025-05-20T10:45:31Z

When selected, we don't want rounded corners:

github-actions · 2025-05-20T14:57:51Z

🚧 @shawnborton has triggered a test app build. You can view the workflow run here.

github-actions · 2025-05-20T15:38:30Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
Android 🤖🔄	iOS 🍎🔄
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/62286-hybrid/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/62286-hybrid/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/62286/NewExpensify.dmg	https://62286.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

shawnborton · 2025-05-20T16:14:37Z

Nice, that seems to have fixed it for me. Let's get this into final review then?

sumo-slonik · 2025-05-20T16:18:21Z

@DylanDylann Hi, could you take a look at this PR? It seems that all the related bugs have been resolved

DylanDylann · 2025-05-21T05:25:53Z

src/components/MoneyRequestReportView/MoneyRequestReportTransactionList.tsx

@@ -59,6 +60,23 @@ type TransactionWithOptionalHighlight = OnyxTypes.Transaction & {
    shouldBeHighlighted?: boolean;
 };

+type TransactionWithOptionalSearchFields = TransactionWithOptionalHighlight & {


This type isn't used in this file. Please move this type of definition to src/components/TransactionItemRow/index.tsx

DylanDylann · 2025-05-21T05:41:01Z

@sumo-slonik Could you also resolve conflict?

DylanDylann · 2025-05-21T05:41:31Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2025-05-21.at.12.49.00.mov

Android: mWeb Chrome

Screen.Recording.2025-05-21.at.12.45.18.mov

iOS: HybridApp

Screen.Recording.2025-05-21.at.14.15.04.mov

iOS: mWeb Safari

Screen.Recording.2025-05-21.at.12.44.28.mov

MacOS: Chrome / Safari

Screen.Recording.2025-05-21.at.12.43.06.mov

MacOS: Desktop

Screen.Recording.2025-05-21.at.12.48.02.mov

…ent_in_search # Conflicts: # src/components/SelectionList/Search/ReportListItem.tsx

sumo-slonik · 2025-05-21T09:37:15Z

@DylanDylann done 💥

mountiny

One nab comment

src/components/TransactionItemRow/DataCells/TaxCell.tsx

shawnborton · 2025-05-21T10:22:16Z

I think we also need to use this new row style for the Reports > Expenses page on mobile too. We can do that as a follow up.

But once we do that, then we really only have one row style to maintain.

sumo-slonik · 2025-05-21T10:42:05Z

I agree and I’m happy to take care of it. However, I’ll be away from tomorrow until Tuesday, so I can either handle it when I’m back or ask someone else to follow up in the meantime."

mountiny

Thanks!

OSBotify · 2025-05-21T11:52:32Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

shawnborton · 2025-05-21T12:11:56Z

Created a follow up issue here: #62474

github-actions · 2025-05-21T18:31:10Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.1.48-0 🚀

platform	result
🖥 desktop 🖥	failure ❌
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	failure ❌

github-actions · 2025-05-21T21:01:50Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.1.48-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	failure ❌

aldo-expensify · 2025-05-22T01:46:02Z

src/components/TransactionItemRow/index.tsx

+    const columnComponent: ColumnComponents = useMemo(
+        () => ({


NAB: did we pull these column rendering here inside a useMemo for performance reasons?

yup, it should stop react from remounting components

github-actions · 2025-05-22T10:53:50Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.1.49-5 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

github-actions · 2025-05-23T19:06:01Z

🚀 Deployed to production by https://github.com/arosiclair in version: 9.1.50-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

sumo-slonik added 6 commits May 16, 2025 16:07

mae transaction component a little bit mor elastic

605dd88

working mapping columns with correct spacing

ca4bc3c

working highlighting and fixed types problems

851862f

update storybook

928ca30

wrap in useMemo

3965648

remove unused import

488c586

sumo-slonik mentioned this pull request May 19, 2025

[Due for payment 2025-05-30] [Better Expense Report View] Use the same component for Transaction row in Search / Reports / Inbox #61512

Open

sumo-slonik marked this pull request as ready for review May 19, 2025 15:13

sumo-slonik requested a review from a team as a code owner May 19, 2025 15:13

melvin-bot bot requested review from DylanDylann and removed request for a team May 19, 2025 15:13

add comment

a82a5e6

trjExpensify requested a review from a team May 19, 2025 15:28

fix spacing

7b42154

Merge branch 'main' into feature/kuba-nowakowski/reuse_new_row_compon…

6a20433

…ent_in_search

SzymczakJ reviewed May 20, 2025

View reviewed changes

This comment has been minimized.

Sign in to view

sumo-slonik added 2 commits May 20, 2025 13:57

add custom configuration of columns

24d0497

move column to const

52bcf51

DylanDylann reviewed May 21, 2025

View reviewed changes

sumo-slonik added 3 commits May 21, 2025 10:54

move type

4cfbfe1

Merge branch 'main' into feature/kuba-nowakowski/reuse_new_row_compon…

44fba09

…ent_in_search # Conflicts: # src/components/SelectionList/Search/ReportListItem.tsx

fix eslint

81b9e8a

mountiny previously approved these changes May 21, 2025

View reviewed changes

src/components/TransactionItemRow/DataCells/TaxCell.tsx Show resolved Hide resolved

add display name

cf9c95f

sumo-slonik dismissed mountiny’s stale review via cf9c95f May 21, 2025 09:46

DylanDylann approved these changes May 21, 2025

View reviewed changes

melvin-bot bot requested a review from mountiny May 21, 2025 10:10

mountiny approved these changes May 21, 2025

View reviewed changes

mountiny merged commit 758b1d7 into Expensify:main May 21, 2025
18 checks passed

github-actions bot mentioned this pull request May 21, 2025

Deploy Checklist: New Expensify 2025-05-21 #62497

Closed

aldo-expensify reviewed May 22, 2025

View reviewed changes

nkdengineer mentioned this pull request May 22, 2025

[Better Expense Report View] [$250] Only the header & bottom padding of preview are highlighted after submitting expense #62560

Open

8 tasks

arosiclair mentioned this pull request May 22, 2025

[Better Expense Report View] [$250] Chat bubble is always green in the expense preview when hold messages are read #62579

Open

8 tasks

Use new transaction component inside reports in search #62286

Use new transaction component inside reports in search #62286

Uh oh!

Conversation

sumo-slonik commented May 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

sumo-slonik commented May 19, 2025

Uh oh!

melvin-bot bot commented May 19, 2025

Uh oh!

trjExpensify commented May 19, 2025

Uh oh!

shawnborton commented May 19, 2025

Uh oh!

sumo-slonik commented May 19, 2025

Uh oh!

shawnborton commented May 19, 2025

Uh oh!

sumo-slonik commented May 20, 2025

Uh oh!

shawnborton commented May 20, 2025

Uh oh!

github-actions bot commented May 20, 2025

Uh oh!

SzymczakJ May 20, 2025

Choose a reason for hiding this comment

Uh oh!

SzymczakJ May 20, 2025

Choose a reason for hiding this comment

Uh oh!

SzymczakJ May 20, 2025

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

shawnborton commented May 20, 2025

Uh oh!

shawnborton commented May 20, 2025

Uh oh!

github-actions bot commented May 20, 2025

Uh oh!

github-actions bot commented May 20, 2025

Uh oh!

shawnborton commented May 20, 2025

Uh oh!

sumo-slonik commented May 20, 2025

Uh oh!

DylanDylann May 21, 2025

Choose a reason for hiding this comment

Uh oh!

DylanDylann commented May 21, 2025

Uh oh!

DylanDylann commented May 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

sumo-slonik commented May 21, 2025

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

shawnborton commented May 21, 2025

Uh oh!

sumo-slonik commented May 21, 2025

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented May 21, 2025

Uh oh!

sumo-slonik commented May 19, 2025 •

edited

Loading

DylanDylann commented May 21, 2025 •

edited

Loading