-
Notifications
You must be signed in to change notification settings - Fork 3.2k
[Better Expense Report View] [$250] Chat bubble is always green in the expense preview when hold messages are read #62579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Triggered auto assignment to @lydiabarclay ( |
Triggered auto assignment to @youssef-lr ( |
💬 A slack conversation has been started in #expensify-open-source |
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
@lydiabarclay FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors. |
Any progress on this @youssef-lr? I think this might be caused by #62286 |
Yeah, IMO this is minor and shouldn't block the deploy. What do you think about demoting this? |
@sumo-slonik can you take a look please? |
Yeah let's demote 👍 |
Job added to Upwork: https://www.upwork.com/jobs/~021925588134633455429 |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @ahmedGaber93 ( |
@youssef-lr just checking - will @sumo-slonik be the Contributor for this issue? If so I'll assign |
🚨 Edited by proposal-police: This proposal was edited at 2025-05-22 16:57:24 UTC. ProposalPlease re-state the problem that we are trying to solve in this issue.Chat bubble is always green when the hold messages are already read in Step 6. What is the root cause of that problem?n case the expense report has only 1 transaction, we will not have App/src/components/TransactionItemRow/DataCells/ChatBubbleCell.tsx Lines 35 to 41 in 38dd1ad
App/src/components/TransactionItemRow/DataCells/ChatBubbleCell.tsx Lines 19 to 21 in 38dd1ad
What changes do you think we should make in order to solve the problem?We should use
App/src/components/TransactionItemRow/DataCells/ChatBubbleCell.tsx Lines 19 to 21 in 38dd1ad
App/src/components/TransactionItemRow/DataCells/ChatBubbleCell.tsx Lines 35 to 41 in 38dd1ad
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?None What alternative solutions did you explore? (Optional)Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job. |
Assigned the PR author. @youssef-lr feel free to ressign the issue to me if you want but also feel free to keep it if you prefer. |
Yes, I'm already working on it. Sorry for the delayed response — I was on vacation. |
Uh oh!
There was an error while loading. Please reload this page.
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: 9.1.49-5
Reproducible in staging?: Yes
Reproducible in production?: Unable to check - New feature testing (Chat bubble is not on prod yet)
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: iPhone 15 Pro Max / iOS 18.4
App Component: Search
Action Performed:
Expected Result:
Chat bubble will turn grey because the hold messages are already read in Step 6.
Actual Result:
Chat bubble is always green when the hold messages are already read in Step 6.
Workaround:
Unknown
Platforms:
Screenshots/Videos
Bug6839160_1747916098197.ScreenRecording_05-22-2025_20-07-42_1.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @ahmedGaber93The text was updated successfully, but these errors were encountered: