[Better Expense Report View] [$250] Chat bubble is always green in the expense preview when hold messages are read

[nlemma]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.1.49-5
Reproducible in staging?: Yes
Reproducible in production?: Unable to check - New feature testing (Chat bubble is not on prod yet)
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: iPhone 15 Pro Max / iOS 18.4
App Component: Search

Action Performed:

1. Launch Expensify app.
2. Go to workspace chat.
3. Submit an expense to the workspace chat.
4. Long press on the expense preview > Hold.
5. Enter reason and save it.
6. Tap on the expense preview to mark the hold messages as read.
7. Go to Reports.
8. Tap bookmark button.
9. Tap Expense Reports.
10. Tap on the report.
11. Tap app back button.

Expected Result:

Chat bubble will turn grey because the hold messages are already read in Step 6.

Actual Result:

Chat bubble is always green when the hold messages are already read in Step 6.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6839160_1747916098197.ScreenRecording_05-22-2025_20-07-42_1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021925588134633455429
• Upwork Job ID: 1925588134633455429
• Last Price Increase: 2025-05-22

Issue Owner

Current Issue Owner: @ahmedGaber93

[melvin-bot]

Triggered auto assignment to @lydiabarclay (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @youssef-lr (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[nlemma]

@lydiabarclay FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[arosiclair]

Any progress on this @youssef-lr? I think this might be caused by #62286

[youssef-lr]

Yeah, IMO this is minor and shouldn't block the deploy. What do you think about demoting this?

[youssef-lr]

@sumo-slonik can you take a look please?

[arosiclair]

Yeah let's demote 👍

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021925588134633455429

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ahmedGaber93 (External)

[lydiabarclay]

@youssef-lr just checking - will @sumo-slonik be the Contributor for this issue? If so I'll assign

[nkdengineer]

🚨 Edited by proposal-police: This proposal was edited at 2025-05-22 16:57:24 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Chat bubble is always green when the hold messages are already read in Step 6.

What is the root cause of that problem?

n case the expense report has only 1 transaction, we will not have lastReadTime field in transactionReport => isReportUnread will be true here

App/src/components/TransactionItemRow/DataCells/ChatBubbleCell.tsx

Lines 35 to 41 in 38dd1ad

	const threadMessages = useMemo(
	() => ({
	count: (iouReportAction && iouReportAction?.childVisibleActionCount) ?? 0,
	isUnread: isChatThread(transactionReport) && isReportUnread(transactionReport),
	}),
	[iouReportAction, transactionReport],
	);

App/src/components/TransactionItemRow/DataCells/ChatBubbleCell.tsx

Lines 19 to 21 in 38dd1ad

	const isReportUnread = ({lastReadTime = '', lastVisibleActionCreated = '', lastMentionedTime = ''}: Report): boolean =>
	lastReadTime < lastVisibleActionCreated || lastReadTime < (lastMentionedTime ?? '');

What changes do you think we should make in order to solve the problem?

We should use lastReadTime from parent report instead

1. Get parent report from transactionReport

    const [parentReport] = useOnyx(`${ONYXKEYS.COLLECTION.REPORT}${transactionReport?.parentReportID}`, {
        canBeMissing: false,
    });

2. Update isReportUnread function

   const isReportUnread = (lastReadTime = '', lastVisibleActionCreated = '', lastMentionedTime = ''): boolean =>
    {
        return lastReadTime < lastVisibleActionCreated || lastReadTime < (lastMentionedTime ?? '');
    };

App/src/components/TransactionItemRow/DataCells/ChatBubbleCell.tsx

Lines 19 to 21 in 38dd1ad

	const isReportUnread = ({lastReadTime = '', lastVisibleActionCreated = '', lastMentionedTime = ''}: Report): boolean =>
	lastReadTime < lastVisibleActionCreated || lastReadTime < (lastMentionedTime ?? '');

3. Add parentReport?.lastReadTime as fallback if we don't have transactionReport.lastReadTime

    isUnread: isChatThread(transactionReport) && isReportUnread(transactionReport.lastReadTime ?? parentReport?.lastReadTime, transactionReport.lastVisibleActionCreated, transactionReport.lastMentionedTime ?? ''),

App/src/components/TransactionItemRow/DataCells/ChatBubbleCell.tsx

Lines 35 to 41 in 38dd1ad

	const threadMessages = useMemo(
	() => ({
	count: (iouReportAction && iouReportAction?.childVisibleActionCount) ?? 0,
	isUnread: isChatThread(transactionReport) && isReportUnread(transactionReport),
	}),
	[iouReportAction, transactionReport],
	);

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[mountiny]

Assigned the PR author. @youssef-lr feel free to ressign the issue to me if you want but also feel free to keep it if you prefer.

[sumo-slonik]

@youssef-lr just checking - will @sumo-slonik be the Contributor for this issue? If so I'll assign

Yes, I'm already working on it. Sorry for the delayed response — I was on vacation.