[Internal QA]: Plaid bank feature #62117

narefyev91 · 2025-05-15T16:15:00Z

Explanation of Change

Part of Plaid import card feeds: https://github.com/Expensify/Expensify/issues/474149

Design doc section: https://docs.google.com/document/d/1v_iaIiLwNqSvtSeJFejKjL9mYz7UH_6Ik5VmySY8XZs/edit?tab=t.0#bookmark=kix.51oh26xsj534

Fixed Issues

$ #61715
PROPOSAL:

Tests

Be sure that company cards is available on WS and plaidCompanyCards is on.
Set In WS US currency
Click on Company Cards -> Add Cards
Select US
Click next - Choose Direct feed -> next.
Verify that bank selector is shown
Select Other
Verify that mock Plaid screen is shown
Go back and select Stripe
Verify Enable your Stripe feed page opens
Go back and select any other bank
Verify bank authentication page/window opens

For EU contries (Which supports Direct feed)

Be sure that company cards is available on WS and plaidCompanyCards is on.
Set In WS EUR currency
Click on Company Cards -> Add Cards
Select UK
Click next - Choose Direct feed. -> next
Verify mock Plaid screen is shown

Verify that no errors appear in the JS console

Offline tests

No changes

QA Steps

Be sure that company cards is available on WS and plaidCompanyCards is on.
Set In WS US currency
Click on Company Cards -> Add Cards
Select US
Click next - Choose Direct feed -> next.
Verify that bank selector is shown
Select Other
Verify that mock Plaid screen is shown
Go back and select Stripe
Verify Enable your Stripe feed page opens
Go back and select any other bank
Verify bank authentication page/window opens

For EU contries (Which supports Direct feed)

Be sure that company cards is available on WS and plaidCompanyCards is on.
Set In WS EUR currency
Click on Company Cards -> Add Cards
Select UK
Click next - Choose Direct feed. -> next
Verify mock Plaid screen is shown

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

android-web.mov

iOS: Native

ios.mov

iOS: mWeb Safari

ios-web.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

melvin-bot · 2025-05-16T06:13:56Z

@dominictb Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

src/libs/CardUtils.ts

src/pages/workspace/companyCards/addNew/PlaidConnectionStep.tsx

src/pages/workspace/companyCards/addNew/SelectFeedType.tsx

dominictb · 2025-05-18T18:04:10Z

BUG: Going back from card type selector opens bank selector (should open feed type selector)

Screen.Recording.2025-05-19.at.00.56.49.mov

narefyev91 · 2025-05-19T06:48:32Z

BUG: Going back from card type selector opens bank selector (should open feed type selector)

Screen.Recording.2025-05-19.at.00.56.49.mov

Commercial feed will be done in a separate github issue (#61717)

Co-authored-by: Dominic <[email protected]>

…ernal/Expensify-App into plaid-bank-feature updates

dominictb · 2025-05-19T17:03:21Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2025-05-20.at.00.23.58-compressed.mov

Screen.Recording.2025-05-20.at.00.25.30-compressed.mov

Android: mWeb Chrome

Screen.Recording.2025-05-20.at.00.29.40.mov

iOS: HybridApp

Screen.Recording.2025-05-20.at.00.16.12-compressed.mov

iOS: mWeb Safari

Screen.Recording.2025-05-20.at.00.20.34.mov

MacOS: Chrome / Safari

Screen.Recording.2025-05-20.at.00.09.54-compressed.mov

Screen.Recording.2025-05-20.at.00.06.17-compressed.mov

MacOS: Desktop

Screen.Recording.2025-05-20.at.00.11.17.mov

dominictb · 2025-05-19T17:20:23Z

Go back and select any other bank

Verify that already existing bank connection flow is started

@narefyev91 All good! Just please update your tests steps to:

9. Go back and select Stripe
10. Verify `Enable your Stripe feed` page opens
11. Go back and select any other bank
12. Verify bank authentication page/window opens

And merge main because we just had a major change with Onyx there.

updates

narefyev91 · 2025-05-20T09:09:13Z

Go back and select any other bank

Verify that already existing bank connection flow is started

@narefyev91 All good! Just please update your tests steps to:
9. Go back and select Stripe
10. Verify `Enable your Stripe feed` page opens
11. Go back and select any other bank
12. Verify bank authentication page/window opens
And merge main because we just had a major change with Onyx there.

done

dominictb · 2025-05-20T10:53:21Z

Flaky test

merge main.

OSBotify · 2025-05-21T07:54:31Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-05-21T18:30:37Z

🚀 Deployed to staging by https://github.com/nkuoch in version: 9.1.48-0 🚀

platform	result
🖥 desktop 🖥	failure ❌
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	failure ❌

github-actions · 2025-05-21T21:01:17Z

🚀 Deployed to staging by https://github.com/nkuoch in version: 9.1.48-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	failure ❌

github-actions · 2025-05-22T10:53:17Z

🚀 Deployed to staging by https://github.com/nkuoch in version: 9.1.49-5 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

github-actions · 2025-05-23T19:05:28Z

🚀 Deployed to production by https://github.com/arosiclair in version: 9.1.50-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

narefyev91 added 3 commits May 15, 2025 19:07

Plaid bank feature

e527845

revert beta

9622880

prettier

efce627

narefyev91 marked this pull request as ready for review May 16, 2025 06:13

narefyev91 requested a review from a team as a code owner May 16, 2025 06:13

melvin-bot bot requested review from dominictb and removed request for a team May 16, 2025 06:13

dominictb suggested changes May 18, 2025

View reviewed changes

narefyev91 and others added 3 commits May 19, 2025 09:50

Update src/pages/workspace/companyCards/addNew/PlaidConnectionStep.tsx

cd0b0fe

Co-authored-by: Dominic <[email protected]>

updates after review

987d856

Merge branch 'plaid-bank-feature' of https://github.com/callstack-int…

3fe7785

…ernal/Expensify-App into plaid-bank-feature updates

narefyev91 requested a review from dominictb May 19, 2025 07:02

MariaHCD mentioned this pull request May 19, 2025

Company Cards - The list of banks is not displayed when adding a company card #62246

Closed

8 tasks

Merge remote-tracking branch 'origin/main' into plaid-bank-feature

7c3f495

updates

dominictb approved these changes May 20, 2025

View reviewed changes

melvin-bot bot requested a review from nkuoch May 20, 2025 10:53

nkuoch approved these changes May 20, 2025

View reviewed changes

Merge remote-tracking branch 'origin/main' into plaid-bank-feature

2493def

merge main.

nkuoch merged commit 6869b04 into Expensify:main May 21, 2025
15 checks passed

github-actions bot mentioned this pull request May 21, 2025

Deploy Checklist: New Expensify 2025-05-21 #62497

Closed

melvin-bot bot mentioned this pull request May 23, 2025

[Due for payment 2025-05-30] [$250] [PlaidImportCardFeeds][NewDot] Implement the bank selector #61715

Open

[Internal QA]: Plaid bank feature #62117

[Internal QA]: Plaid bank feature #62117

Uh oh!

Conversation

narefyev91 commented May 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented May 16, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dominictb commented May 18, 2025

Uh oh!

narefyev91 commented May 19, 2025

Uh oh!

dominictb commented May 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

dominictb commented May 19, 2025

Uh oh!

narefyev91 commented May 20, 2025

Uh oh!

dominictb commented May 20, 2025

Uh oh!

Uh oh!

OSBotify commented May 21, 2025

Uh oh!

github-actions bot commented May 21, 2025

Uh oh!

github-actions bot commented May 21, 2025

Uh oh!

github-actions bot commented May 22, 2025

Uh oh!

github-actions bot commented May 23, 2025

Uh oh!

Uh oh!

narefyev91 commented May 15, 2025 •

edited

Loading

dominictb commented May 19, 2025 •

edited

Loading