Skip to content

[NO QA] Add react import to tax cell #62481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 21, 2025
Merged

[NO QA] Add react import to tax cell #62481

merged 1 commit into from
May 21, 2025
+1 −0

Conversation

sumo-slonik
Copy link
Contributor

Explanation of Change

Fixed Issues

$ #61512
PROPOSAL:

Tests

Unnecessary

  • Verify that no errors appear in the JS console

Offline tests

Unnecessary

QA Steps

Unnecessary
// TODO: These must be filled out, or the issue title must include "[No QA]."

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop

@sumo-slonik sumo-slonik requested a review from a team as a code owner May 21, 2025 13:41
@melvin-bot melvin-bot bot requested review from DylanDylann and removed request for a team May 21, 2025 13:41
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented May 21, 2025

@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@mountiny
Copy link
Contributor

mountiny commented May 21, 2025 •
edited
Loading

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Android: mWeb Chrome
iOS: HybridApp
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop

@mountiny mountiny merged commit 2d4e958 into Expensify:main May 21, 2025
16 checks passed
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions github-actions bot added the DeployBlockerCash This issue or pull request should block deployment label May 21, 2025
@github-actions GitHub Actions
Copy link
Contributor

Performance Comparison Report 📊 (1/3)

⚠️ Some tests did not pass successfully, so some results are omitted from final report: Open search router TTI, Linking, Money request

Significant Changes To Duration

Name Duration
App start time contentAppeared_To_screenTTI 788.045 ms → 981.083 ms (+193.038 ms, +24.5%) 🔴
App start time TTI 1478.995 ms → 1636.283 ms (+157.288 ms, +10.6%) 🔴
Show details
Name Duration
App start time contentAppeared_To_screenTTI Baseline
Mean: 788.045 ms
Stdev: 241.105 ms (30.6%)
Runs: 516.3149250000715 521.1277049998753 530.4074280001223 535.9073600000702 540.599237000104 547.4745419998653 550.7718750000931 558.6122420001775 562.31597100012 563.4164829999208 564.5459599997848 566.0857750000432 568.7402530000545 576.6825669999234 580.9815030000173 586.5174380000681 588.7990149999969 591.6237429999746 593.3980530002154 600.0039539998397 600.727363999933 601.707407000009 601.8502230001613 604.105064000003 614.3009469998069 617.9255400002003 622.8495280002244 630.5592149998993 634.5243680002168 640.5925449999049 642.5910930000246 657.4711810001172 657.7497780001722 663.0118740000762 695.8695849999785 711.5149599998258 939.46566300001 1018.236093999818 1023.936652999837 1027.2640030002221 1030.2577700000256 1033.8808109997772 1043.4089449997991 1043.8250870001502 1045.9970459998585 1046.9845389998518 1051.1221070000902 1058.4783979998901 1076.875521000009 1079.5235950001515 1089.1072959997691 1100.264727999922 1102.000636999961 1105.5492909997702 1127.722763999831 1140.4294909997843 1151.1714150002226 1159.7142880000174 1161.113514999859 1184.70529899979

Current
Mean: 981.083 ms
Stdev: 245.331 ms (25.0%)
Runs: 544.34336599987 566.0719989999197 581.690702999942 596.9571360000409 611.3193230000325 612.512451000046 614.5526499999687 614.8523110002279 629.625413000118 632.7280629999004 642.1640559998341 644.9631059998646 669.9206070001237 678.5596449999139 678.7801660001278 687.4728810000233 688.3692129999399 691.3614050000906 693.1593140000477 723.6622350001708 1032.2519780001603 1054.1677330001257 1072.8649189998396 1081.6585200000554 1092.7445749999024 1099.101158999838 1101.0411840002052 1114.4102630000561 1121.0516869998537 1129.1289490000345 1130.8589659999125 1133.4637649999931 1136.1214410001412 1140.2922450001352 1140.392190999817 1143.3474799999967 1143.3526969999075 1146.679091999773 1152.8334340001456 1154.0518280002289 1160.296606999822 1161.5115040000528 1165.177922999952 1169.9386040000245 1170.4499659999274 1171.8751429999247 1175.5683630001731 1175.5734179997817 1181.155697000213 1184.0153399999253 1184.5673850001767 1186.6126680001616 1187.3298249999061 1190.0095640001819 1202.8998309997842 1207.660482000094 1208.9676580000669 1214.6457349997945 1220.2180619998835 1223.6549559999257
App start time TTI Baseline
Mean: 1478.995 ms
Stdev: 235.762 ms (15.9%)
Runs: 1208.3149250000715 1212.0039539998397 1212.9815030000173 1221.1277049998753 1223.517438000068 1224.300946999807 1235.4074280001223 1235.727363999933 1239.5243680002168 1240.6122420001775 1244.4745419998653 1248.9073600000702 1261.7402530000545 1267.4164829999208 1269.6825669999234 1274.3980530002154 1288.6237429999746 1290.7497780001722 1293.592544999905 1302.31597100012 1302.707407000009 1303.599237000104 1305.0857750000432 1311.5910930000246 1318.8502230001613 1319.5149599998258 1329.105064000003 1331.4711810001172 1339.8695849999785 1345.7718750000931 1354.5459599997848 1374.5592149998993 1375.9255400002003 1380.0118740000762 1397.7990149999969 1459.8495280002244 1623.4089449997991 1628.8250870001502 1641.46566300001 1707.936652999837 1708.8808109997772 1709.5492909997702 1718.236093999818 1735.2577700000256 1747.9970459998585 1752.2640030002221 1765.9845389998518 1780.4783979998901 1783.1221070000902 1784.875521000009 1786.722763999831 1793.1714150002226 1797.70529899979 1805.7142880000174 1806.5235950001515 1807.4294909997843 1808.000636999961 1812.1072959997691 1821.113514999859 1867.264727999922

Current
Mean: 1636.283 ms
Stdev: 249.253 ms (15.2%)
Runs: 1161.0719989999197 1196.957136000041 1203.5526499999687 1239.3193230000325 1241.852311000228 1251.9631059998646 1268.7280629999004 1282.625413000118 1298.7801660001278 1306.34336599987 1306.690702999942 1317.5596449999139 1327.3614050000906 1327.9206070001237 1333.36921299994 1341.6622350001708 1342.1593140000477 1347.4728810000233 1357.512451000046 1376.164055999834 1685.8649189998396 1722.1214410001412 1736.4102630000561 1740.1677330001257 1742.4637649999931 1748.0516869998537 1752.3526969999075 1753.392190999817 1762.8589659999125 1766.679091999773 1782.6585200000554 1785.3474799999967 1791.2922450001352 1792.0518280002289 1796.5683630001731 1798.1289490000345 1803.296606999822 1806.5673850001767 1809.8334340001456 1811.0153399999253 1811.9386040000245 1817.155697000213 1822.8751429999247 1829.4499659999274 1829.5734179997817 1832.3298249999061 1837.0411840002052 1837.2519780001603 1839.7445749999024 1841.0095640001819 1844.8998309997842 1846.9676580000669 1857.5115040000528 1859.660482000094 1861.177922999952 1862.2180619998835 1870.6126680001616 1874.101158999838 1878.6549559999257 1906.6457349997945

@github-actions GitHub Actions
Copy link
Contributor

Performance Comparison Report 📊 (2/3)

Meaningless Changes To Duration (1/2)

Show entries
Name Duration
App start time nativeLaunch 24.983 ms → 26.474 ms (+1.491 ms, +6.0%)
App start time nativeLaunchEnd_To_appCreationStart 80.729 ms → 84.633 ms (+3.905 ms, +4.8%)
App start time appCreation 73.690 ms → 71.567 ms (-2.123 ms, -2.9%)
App start time appCreationEnd_To_contentAppeared 509.133 ms → 465.474 ms (-43.660 ms, -8.6%)
App start time runJsBundle 326.881 ms → 328.983 ms (+2.102 ms, +0.6%)
App start time regularAppStart 0.021 ms → 0.021 ms (-0.000 ms, ±0.0%)
App start time (CPU) 153.691 % → 149.509 % (-4.182 %, -2.7%)
App start time (FPS) 60.000 FPS → 60.000 FPS
App start time (RAM) 368.640 MB → 370.387 MB (+1.747 MB, ±0.0%)
App start time (CPU/JS) 0.000 % → 0.000 %
App start time (CPU/UI) 26.798 % → 26.400 % (-0.398 %, -1.5%)
Report typing Composer typing rerender count 1.000 renders → 1.000 renders
Report typing Message sent 368.534 ms → 359.053 ms (-9.481 ms, -2.6%)
Report typing (CPU) 87.990 % → 88.196 % (+0.206 %, ±0.0%)
Report typing (FPS) 60.000 FPS → 60.000 FPS
Report typing (RAM) 447.808 MB → 447.745 MB (-0.063 MB, ±0.0%)
Report typing (CPU/JS) 0.000 % → 0.000 %
Report typing (CPU/UI) 19.731 % → 19.571 % (-0.161 %, -0.8%)
Chat opening Chat TTI 737.894 ms → 746.256 ms (+8.361 ms, +1.1%)
Chat opening (CPU) 162.831 % → 161.271 % (-1.561 %, -1.0%)
Chat opening (FPS) 60.000 FPS → 60.000 FPS
Chat opening (RAM) 389.540 MB → 389.724 MB (+0.185 MB, ±0.0%)
Chat opening (CPU/JS) 0.000 % → 0.000 %
Chat opening (CPU/UI) 31.629 % → 31.655 % (+0.026 %, ±0.0%)
Show details
Name Duration
App start time nativeLaunch Baseline
Mean: 24.983 ms
Stdev: 2.880 ms (11.5%)
Runs: 22 22 22 22 22 22 22 22 22 22 22 23 23 23 23 23 23 23 23 23 23 23 23 23 23 23 24 24 24 24 24 25 25 25 25 25 25 26 26 26 26 26 26 26 26 27 28 28 29 29 29 29 29 29 30 31 32 34

Current
Mean: 26.474 ms
Stdev: 3.844 ms (14.5%)
Runs: 21 22 22 22 22 22 22 22 22 23 23 23 23 23 23 23 23 24 24 24 24 24 24 24 25 25 26 26 26 26 26 26 27 27 27 27 28 28 28 28 29 29 29 29 30 30 30 30 31 31 32 32 33 34 34 35 36
App start time nativeLaunchEnd_To_appCreationStart Baseline
Mean: 80.729 ms
Stdev: 10.658 ms (13.2%)
Runs: 62 63 65 65 68 68 69 69 70 70 70 71 71 71 73 73 74 74 74 75 75 76 76 76 78 78 79 79 79 79 79 80 81 81 81 82 82 83 85 85 85 86 86 86 89 89 89 90 90 91 92 97 97 97 98 99 100 104 109

Current
Mean: 84.633 ms
Stdev: 12.164 ms (14.4%)
Runs: 59 66 66 69 70 71 72 72 73 73 73 74 75 75 76 77 77 77 77 77 78 78 79 79 79 79 79 79 81 81 82 83 83 85 85 86 86 87 88 88 90 91 91 93 94 95 95 96 96 97 97 97 100 104 106 106 106 106 110 114
App start time appCreation Baseline
Mean: 73.690 ms
Stdev: 9.719 ms (13.2%)
Runs: 57 58 59 59 59 61 61 62 63 63 63 66 66 66 66 67 68 69 69 70 70 70 70 70 70 71 71 72 73 73 73 75 75 75 76 76 76 77 77 77 78 78 78 79 83 84 84 84 84 84 86 86 86 86 87 94 95 99

Current
Mean: 71.567 ms
Stdev: 8.622 ms (12.0%)
Runs: 56 57 59 59 60 61 61 63 63 63 63 63 63 64 65 65 65 65 65 66 66 66 67 67 68 68 69 69 69 70 70 71 73 73 73 75 75 75 75 76 76 77 78 78 78 79 80 80 80 81 81 81 82 82 82 82 88 89 89 90
App start time appCreationEnd_To_contentAppeared Baseline
Mean: 509.133 ms
Stdev: 50.961 ms (10.0%)
Runs: 407 409 422 427 431 435 439 446 451 452 456 458 462 462 464 468 470 470 471 471 490 495 502 503 507 516 517 518 518 521 523 523 523 524 527 527 530 532 534 535 535 535 537 537 538 539 539 541 542 543 544 545 561 571 582 585 601 601 610 626

Current
Mean: 465.474 ms
Stdev: 38.154 ms (8.2%)
Runs: 415 418 418 418 422 424 424 425 426 430 433 434 438 438 439 439 440 443 444 445 446 448 448 453 454 454 456 457 459 460 461 461 462 464 464 464 468 469 470 473 473 474 476 479 481 487 488 514 520 521 522 543 543 545 554 554 554
App start time runJsBundle Baseline
Mean: 326.881 ms
Stdev: 19.583 ms (6.0%)
Runs: 291 291 293 293 295 295 297 297 297 297 297 297 301 301 301 301 302 302 305 305 308 308 308 308 308 308 312 312 313 313 315 315 316 316 316 316 317 317 318 318 318 318 319 319 320 320 320 320 323 323 323 323 323 323 324 324 325 325 326 326 326 326 327 327 328 328 330 330 331 331 331 331 332 332 334 334 337 337 337 337 337 337 339 339 339 339 340 340 341 341 343 343 346 346 346 346 346 346 349 349 349 349 350 350 350 350 351 351 358 358 361 361 365 365 366 366 366 366

Current
Mean: 328.983 ms
Stdev: 20.935 ms (6.4%)
Runs: 280 280 293 293 296 296 296 296 301 301 301 301 303 303 303 303 304 304 304 304 306 306 308 308 312 312 312 312 312 312 313 313 313 313 314 314 316 316 318 318 318 318 320 320 321 321 323 323 323 323 324 324 325 325 326 326 326 326 328 328 328 328 331 331 331 331 335 335 336 336 336 336 337 337 337 337 337 337 338 338 341 341 342 342 343 343 344 344 345 345 345 345 349 349 350 350 350 350 350 350 351 351 351 351 356 356 359 359 359 359 360 360 362 362 362 362 366 366 369 369
App start time regularAppStart Baseline
Mean: 0.021 ms
Stdev: 0.003 ms (12.1%)
Runs: 0.016114000231027603 0.01688600005581975 0.017374999821186066 0.01749700028449297 0.018352000042796135 0.018636000342667103 0.018716999795287848 0.018962000031024218 0.019001999869942665 0.019002999644726515 0.019084000028669834 0.01912499964237213 0.01920600002631545 0.019328000023961067 0.019328000023961067 0.019491000100970268 0.0195720000192523 0.019612000323832035 0.01993800001218915 0.0201409999281168 0.020142000168561935 0.020263999700546265 0.020264000166207552 0.02038600016385317 0.020426000002771616 0.02046799985691905 0.020792999770492315 0.020913999993354082 0.020955000072717667 0.020955000072717667 0.021077999845147133 0.021118000149726868 0.021240000147372484 0.021525000222027302 0.021890999749302864 0.0219310000538826 0.02201299974694848 0.022054000291973352 0.022379000205546618 0.022379999980330467 0.022379999980330467 0.022419999819248915 0.022704999893903732 0.02278600027784705 0.0231929998844862 0.023559000343084335 0.023680999875068665 0.024373000022023916 0.024942999705672264 0.025065000168979168 0.025350000243633986 0.0255129998549819 0.025919000152498484 0.026326999999582767 0.026570999994874 0.0281980000436306

Current
Mean: 0.021 ms
Stdev: 0.002 ms (9.7%)
Runs: 0.017130999825894833 0.01733399974182248 0.017903999891132116 0.018146999645978212 0.018920999951660633 0.018962000031024218 0.018962000031024218 0.019002999644726515 0.01904299994930625 0.01912399986758828 0.019164999946951866 0.019286999944597483 0.01936900010332465 0.019694000016897917 0.019897999707609415 0.02001999970525503 0.020304000005126 0.020304000005126 0.020427000243216753 0.020548999775201082 0.020589000079780817 0.0206300001591444 0.02066999999806285 0.020711000077426434 0.020711999852210283 0.020791999995708466 0.02091500023379922 0.021077000070363283 0.021077999845147133 0.02119999984279275 0.021239999681711197 0.021239999681711197 0.02132099959999323 0.021321000065654516 0.021402999758720398 0.021484000142663717 0.021566000301390886 0.02164699975401163 0.021687999833375216 0.021769000217318535 0.02209499990567565 0.022338000126183033 0.022419999819248915 0.022500999737530947 0.022582999896258116 0.022704999893903732 0.02270500035956502 0.023031000047922134 0.02343699987977743 0.0235190000385046 0.023843999952077866 0.024740000255405903 0.025187999941408634 0.0256759999319911 0.026366999838501215 0.026366999838501215
App start time (CPU) Baseline
Mean: 153.691 %
Stdev: 7.278 % (4.7%)
Runs: 135.63630199785806 138.4131429321784 140.26104417670686 141.20889908841716 141.6511175962798 144.0536830129435 144.73705179282868 144.76241824071485 145.7456492637216 145.98208593650392 146.74700547651318 147.98529092156858 148.9390545797477 148.9600263655887 149.12841556128137 149.23429937613884 149.5675247114508 149.74430552904496 150.19868394306917 150.56428378764005 150.61927260921087 151.60841385343358 151.74209207641715 151.97727055373142 152.9173885619845 153.05388515505248 153.16205533596838 153.21298328754048 153.8548882276337 154.1129628079993 154.50307642959206 154.7528456515417 155.6914822266934 155.99795976919893 156.03342275877492 156.07449298095838 156.18187480535659 156.34481760262287 156.77058854248267 156.9840415994263 157.05159137236814 157.6787528575057 158.1940322661425 158.31413210445476 158.68924302788847 158.78476635178907 159.11253164756025 159.62369364425535 159.70707070707073 160.14943861891578 160.8696691528017 161.86880416701405 161.91500806885423 162.17229885545433 163.92009389446457 166.13760430945342 167.16206041973845 167.9038909808141 169.41962270679159

Current
Mean: 149.509 %
Stdev: 6.724 % (4.5%)
Runs: 136.9490516180035 137.67753078006518 138.1343504255578 138.90286161412925 140.363989504787 140.47767822344647 140.49402390438246 141.06025265728468 141.11560516559854 142.4732123846767 143.0087716807423 143.74073050138017 143.99887121266653 144.80848243870122 145.12188281202364 145.12840984697274 145.9603753251474 146.74241888461935 147.2725200329752 147.59998691697703 147.74881578145164 147.81305729606854 147.83690074422955 147.97839029596068 148.02256680296648 148.14611672712763 148.7338223018855 148.76549143587494 148.77026669552464 149.09270505206615 149.1216079041126 149.1616766467066 149.42632713973063 149.70059880239526 150.08203901284116 150.41277395063196 150.44589009946014 150.47858761779793 150.90996843757932 151.4465779143199 151.7385633390596 151.8710952441668 151.9273329499032 153.61474481732955 153.79803573918764 153.91340449823952 154.99336058158627 155.04662018648082 155.51764176204352 155.8615414037101 156.0486241944968 157.20992622401064 158.8542914171657 158.86053290244908 160.9906072041987 161.64507742991003 162.7768459383977 163.43833430878146 167.80057462266225
App start time (FPS) Baseline
Mean: 60.000 FPS
Stdev: 0.000 FPS (0.0%)
Runs: 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60

Current
Mean: 60.000 FPS
Stdev: 0.000 FPS (0.0%)
Runs: 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60
App start time (RAM) Baseline
Mean: 368.640 MB
Stdev: 9.271 MB (2.5%)
Runs: 346.203125 346.3359375 354.158203125 355.37890625 355.892578125 358.734375 359.361328125 359.671875 359.826171875 360.322265625 360.599609375 360.734375 360.81640625 360.927734375 361.41015625 361.7890625 361.865234375 362.205078125 362.39453125 362.998046875 363.259765625 364.44140625 364.89453125 365.267578125 365.58203125 365.779296875 366.37109375 366.49609375 368.193359375 369.2135416666667 370.09375 370.142578125 370.2981770833333 370.9166666666667 371.3059895833333 371.70703125 372.8151041666667 372.8372395833333 373.0052083333333 373.0403645833333 373.8346354166667 373.9361979166667 374.5377604166667 374.61328125 375.5520833333333 375.7526041666667 376.9140625 377.4739583333333 378.6223958333333 378.7747395833333 378.8190104166667 379.4973958333333 379.9205729166667 380.38671875 380.68359375 383.4361979166667 384.4401041666667 385.6015625 389.68359375

Current
Mean: 370.387 MB
Stdev: 6.045 MB (1.6%)
Runs: 352.3515625 357.12109375 359.517578125 361.2578125 361.634765625 362.359375 362.720703125 363.19921875 363.4505208333333 363.755859375 364.013671875 364.390625 365.0703125 365.2291666666667 365.568359375 365.95703125 366.71875 367.0520833333333 367.8671875 368.25 369.0078125 369.3411458333333 370.0286458333333 370.5390625 370.58984375 370.62109375 370.6497395833333 370.9752604166667 371.1536458333333 371.1979166666667 371.31640625 371.4361979166667 371.68359375 372.1223958333333 372.58984375 372.5963541666667 372.8958333333333 372.9153645833333 373.7213541666667 374.02734375 374.56640625 374.9036458333333 375.0546875 375.140625 375.208984375 375.21484375 375.7161458333333 375.7330729166667 375.7369791666667 375.9270833333333 376.1888020833333 376.2421875 376.9518229166667 377.0846354166667 377.1015625 377.1315104166667 377.1731770833333 379.7578125 385.08203125
App start time (CPU/JS) Baseline
Mean: 0.000 %
Stdev: 0.000 % (NaN%)
Runs: 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0

Current
Mean: 0.000 %
Stdev: 0.000 % (NaN%)
Runs: 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0
App start time (CPU/UI) Baseline
Mean: 26.798 %
Stdev: 2.710 % (10.1%)
Runs: 21 21 22.2 22.7 23 23 23.1 23.1 23.1 23.9 24 24.1 24.2 24.6 24.7 24.9 25.1 25.3 25.3 25.5 25.6 25.8 26 26 26.1 26.2 26.7 26.8 27 27 27 27.1 27.4 27.8 27.9 28 28 28.1 28.1 28.7 28.8 28.8 28.8 28.8 28.9 28.9 29 29 29.1 29.1 29.6 30 30.6 31 31 31.1 31.1 31.1 31.3

Current
Mean: 26.400 %
Stdev: 2.068 % (7.8%)
Runs: 22.7 22.7 23.3 23.3 23.8 23.9 24 24 24.1 24.6 24.6 24.6 24.6 24.7 24.7 24.9 25 25.3 25.3 25.3 25.3 25.3 25.4 25.6 25.8 25.9 25.9 26 26 26 26.1 26.1 26.5 26.6 26.7 26.7 26.7 27 27.1 27.1 27.3 27.3 27.3 27.4 27.9 28 28.1 28.6 29 29 29.1 29.1 29.2 29.4 29.7 30 30 30 32
Report typing Composer typing rerender count Baseline
Mean: 1.000 renders
Stdev: 0.000 renders (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1

Current
Mean: 1.000 renders
Stdev: 0.000 renders (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1

@github-actions GitHub Actions
Copy link
Contributor

Performance Comparison Report 📊 (3/3)

Meaningless Changes To Duration (2/2)

Show entries
Name Duration
App start time nativeLaunch 24.983 ms → 26.474 ms (+1.491 ms, +6.0%)
App start time nativeLaunchEnd_To_appCreationStart 80.729 ms → 84.633 ms (+3.905 ms, +4.8%)
App start time appCreation 73.690 ms → 71.567 ms (-2.123 ms, -2.9%)
App start time appCreationEnd_To_contentAppeared 509.133 ms → 465.474 ms (-43.660 ms, -8.6%)
App start time runJsBundle 326.881 ms → 328.983 ms (+2.102 ms, +0.6%)
App start time regularAppStart 0.021 ms → 0.021 ms (-0.000 ms, ±0.0%)
App start time (CPU) 153.691 % → 149.509 % (-4.182 %, -2.7%)
App start time (FPS) 60.000 FPS → 60.000 FPS
App start time (RAM) 368.640 MB → 370.387 MB (+1.747 MB, ±0.0%)
App start time (CPU/JS) 0.000 % → 0.000 %
App start time (CPU/UI) 26.798 % → 26.400 % (-0.398 %, -1.5%)
Report typing Composer typing rerender count 1.000 renders → 1.000 renders
Report typing Message sent 368.534 ms → 359.053 ms (-9.481 ms, -2.6%)
Report typing (CPU) 87.990 % → 88.196 % (+0.206 %, ±0.0%)
Report typing (FPS) 60.000 FPS → 60.000 FPS
Report typing (RAM) 447.808 MB → 447.745 MB (-0.063 MB, ±0.0%)
Report typing (CPU/JS) 0.000 % → 0.000 %
Report typing (CPU/UI) 19.731 % → 19.571 % (-0.161 %, -0.8%)
Chat opening Chat TTI 737.894 ms → 746.256 ms (+8.361 ms, +1.1%)
Chat opening (CPU) 162.831 % → 161.271 % (-1.561 %, -1.0%)
Chat opening (FPS) 60.000 FPS → 60.000 FPS
Chat opening (RAM) 389.540 MB → 389.724 MB (+0.185 MB, ±0.0%)
Chat opening (CPU/JS) 0.000 % → 0.000 %
Chat opening (CPU/UI) 31.629 % → 31.655 % (+0.026 %, ±0.0%)
Show details
Name Duration
Report typing Message sent Baseline
Mean: 368.534 ms
Stdev: 54.793 ms (14.9%)
Runs: 183.7384440000169 292.21394899953157 294.16337099997327 296.1592210000381 297.3409830001183 297.7251389999874 300.2095539998263 303.17264800006524 303.2176919998601 305.5746250003576 306.12207099981606 306.7359620006755 306.9477539998479 308.40189599990845 309.2891440000385 312.44038899987936 313.67504899948835 315.71655299980193 317.8264569994062 317.8538419995457 320.61934399977326 322.6378579996526 386.32267200015485 389.18058299971744 391.58581499988213 392.1492510000244 392.94966699928045 393.7456060005352 393.99454799992964 394.0373129998334 394.4922289997339 394.7717690002173 395.38578299991786 397.0562340002507 397.3206780003384 399.0197749999352 400.2876379992813 400.90726700006053 401.046753000468 401.73701999988407 402.4855549996719 406.12203000020236 406.22159800026566 406.6489260001108 407.7056480003521 407.71167100034654 410.80981400003657 413.0342210000381 414.4615070000291 415.4994299998507 416.32157400017604 420.45088700018823 420.5773520004004 421.7204999998212 427.2684329999611 427.4604899995029 430.000163000077 430.5228679999709 435.97501699998975 443.2899580001831

Current
Mean: 359.053 ms
Stdev: 60.669 ms (16.9%)
Runs: 178.23193300003186 185.20402100030333 290.34614999964833 294.72790600033477 295.39550800062716 296.5537109998986 297.8876949995756 298.4578450000845 298.5738929999061 298.5944010000676 300.0363770001568 300.9034420000389 301.1766760000028 301.52730299998075 305.0789790004492 305.2008880004287 305.5765789998695 305.9587400001474 306.51424100017175 307.1750490004197 309.98254400026053 310.8026529997587 315.57922299951315 322.34171600081027 322.48168900003657 334.45707200001925 381.96671599987894 389.8013110002503 390.0715739997104 391.89542699977756 394.8355299998075 396.1600750000216 396.61853000056 397.9672849997878 398.43172300001606 398.9202890000306 398.9556480003521 399.76383400009945 399.9696450000629 400.399209999945 403.5965989995748 404.5499260001816 408.5393880000338 409.124673999846 409.47920699976385 409.552775000222 409.784994000569 410.9829099997878 412.18461100012064 413.21602400019765 413.3604739997536 413.49703000020236 415.57539900019765 415.93273899983615 416.04492300003767 419.2882489999756 421.9621590003371 422.009766000323 438.1753750005737 451.80061800032854
Report typing (CPU) Baseline
Mean: 87.990 %
Stdev: 4.940 % (5.6%)
Runs: 77.90198107007693 78.4297734230065 80.23286873736669 80.4309878817264 80.80891692891669 80.89171428349982 81.1971468640004 81.2158845009297 82.20004747309716 82.27398704904631 82.44452609545152 82.54203854629814 82.9046405669882 83.94149079192206 84.68812244157058 85.16415052642547 85.55954963033504 85.76256044548005 85.83527171519933 85.99361162447039 86.44385044697582 86.50939704635371 87.44810265215698 87.53314886192187 87.70666828389528 87.83562854014536 88.07670329424346 88.52582290596034 88.9949456079539 89.19977263981521 89.55044093870337 90.05941552204081 90.65183742374866 90.76391447820552 90.98917988448623 91.17698333692132 91.45998659846992 91.47026908627231 91.50439421795993 91.53183212430919 91.89896009556146 92.23642382526006 92.28126727895993 92.3054641805154 93.16687595870599 93.35267039725714 93.48652988046948 93.95676185599507 94.00490178123707 94.04503212044108 94.5770019637076 95.14023790468119 95.63599441504104 97.5246441355311

Current
Mean: 88.196 %
Stdev: 6.486 % (7.4%)
Runs: 78.17345849055889 78.48879668321102 78.79268567206796 79.1315093388363 79.41412373798715 79.66648828757617 80.27646639620022 80.30685279354014 80.9973092253848 81.1801039197025 81.3471170275603 81.49924538361375 81.67661747579047 82.15599190727917 82.958400539055 83.12269389376303 83.20278331588051 83.55815094365977 83.88182990554472 84.13818622297603 84.64775106585279 86.35435898448254 86.77212050730478 86.88534399588981 87.37242720293158 87.40908536069253 87.47499366273064 87.81323501313899 87.84773984267761 88.08669256812007 88.17153963421762 88.3802885073807 88.5021675072169 88.54112933599637 88.64477780655655 89.09139468963066 90.39252173839776 90.49415534877744 90.67529917477724 90.97797240212846 91.50443639774724 91.58084418009737 92.0577612532331 92.26047413376476 92.5536084485081 93.6762410844763 93.7413324244137 93.93844023473733 93.96103592955801 94.07229087734174 94.59070401684562 95.15131395321211 95.54293919713129 96.00437770365262 96.17521841077064 96.47139850805566 96.85535293579633 106.99920262012395 107.92778360309856
Report typing (FPS) Baseline
Mean: 60.000 FPS
Stdev: 0.000 FPS (0.0%)
Runs: 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60

Current
Mean: 60.000 FPS
Stdev: 0.000 FPS (0.0%)
Runs: 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60
Report typing (RAM) Baseline
Mean: 447.808 MB
Stdev: 8.777 MB (2.0%)
Runs: 433.74921875 433.86245888157896 434.0634765625 435.2682291666667 435.5234375 435.98716517857144 436.557421875 436.834375 437.7278645833333 437.87022569444446 438.171875 438.4908203125 439.05546875 439.47547743055554 439.6178042763158 439.6763671875 440.3778782894737 440.86551339285717 441.3095238095238 442.5588107638889 443.4267113095238 444.4274259868421 446.1324013157895 446.8969983552632 447.38560267857144 448.66387648809524 449.5413240131579 449.7826891447368 450.01377467105266 450.0266927083333 450.9173519736842 451.5176711309524 451.93433779761904 452.0540364583333 452.205859375 452.4668898809524 452.5557154605263 453.10848721590907 453.41171875 453.5005580357143 453.60526315789474 453.6129261363636 454.1422230113636 456.0452302631579 456.2645970394737 457.2201171875 457.40995065789474 457.7131990131579 458.364453125 458.5718005952381 458.63589638157896 458.83861019736844 459.4176136363636 461.0943667763158 471.46571180555554

Current
Mean: 447.745 MB
Stdev: 7.233 MB (1.6%)
Runs: 436.4361328125 436.55546875 437.2920386904762 438.353125 438.4124177631579 438.4427734375 438.7174479166667 438.748046875 439.435546875 439.457421875 439.9068359375 440.125 440.4615885416667 440.6217447916667 441.0662109375 441.2865953947368 441.66611842105266 442.1878720238095 442.302734375 442.87265625 443.194140625 443.3296875 443.6021792763158 445.034375 445.2169921875 445.9837890625 446.1852384868421 446.7475818452381 447.49272017045456 449.176953125 449.3079769736842 450.1744140625 450.4120163690476 450.7544921875 450.9342105263158 451.06373355263156 451.0953125 451.71112351190476 451.7693359375 451.83522727272725 453.70578835227275 453.77808779761904 453.81126644736844 454.69839638157896 454.736328125 454.81082589285717 455.3999255952381 456.21957236842104 456.2197779605263 456.64535361842104 457.0765625 457.18984375 457.62332589285717 457.671484375 458.7201171875 459.52467105263156 464.2638671875
Report typing (CPU/JS) Baseline
Mean: 0.000 %
Stdev: 0.000 % (NaN%)
Runs: 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0

Current
Mean: 0.000 %
Stdev: 0.000 % (NaN%)
Runs: 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0
Report typing (CPU/UI) Baseline
Mean: 19.731 %
Stdev: 0.916 % (4.6%)
Runs: 17.7 17.7 17.9 18.2 18.3 18.3 18.4 18.4 18.5 18.7 18.9 18.9 19.1 19.2 19.3 19.3 19.4 19.5 19.7 19.7 19.7 19.7 19.8 19.8 19.8 19.8 19.8 19.8 19.8 19.8 20 20 20 20 20.2 20.2 20.3 20.3 20.3 20.4 20.4 20.5 20.6 20.6 20.6 20.7 20.7 20.7 20.7 20.9 20.9 21 21.2 21.4

Current
Mean: 19.571 %
Stdev: 1.052 % (5.4%)
Runs: 17.1 17.3 17.5 17.5 17.6 18.2 18.2 18.3 18.4 18.4 18.5 18.9 18.9 18.9 19 19 19 19.1 19.2 19.2 19.3 19.3 19.4 19.5 19.5 19.6 19.6 19.7 19.7 19.8 19.8 19.8 19.8 19.9 19.9 19.9 20 20 20 20 20 20 20.1 20.2 20.4 20.5 20.5 20.5 20.6 20.6 20.7 20.7 20.8 21 21.1 21.3 21.7 21.7
Chat opening Chat TTI Baseline
Mean: 737.894 ms
Stdev: 46.934 ms (6.4%)
Runs: 660.4521079994738 661.7122809998691 662.8874109992757 672.8542480003089 673.3288170006126 673.615275000222 677.1131189996377 677.7423100005835 677.9027920002118 680.3386639999226 684.3190919999033 686.4204110000283 691.0788569999859 691.1271980004385 692.0041100000963 694.7775070006028 699.9553220001981 703.3842369997874 704.7189949993044 710.3458249997348 714.6901859994978 715.2664790004492 719.5628669997677 719.6735020000488 720.1568200001493 727.6948250001296 728.0080970004201 734.6289470000193 735.4984539998695 739.1243089996278 740.9153650002554 745.5959470001981 747.7117919996381 749.2143970001489 752.3888759994879 755.0509850000963 756.2489830004051 757.3662930000573 758.1585290003568 758.2769370004535 771.0113939996809 775.6750900000334 782.3828130001202 785.215779999271 785.9567869994789 787.4913739999756 789.7188729997724 789.7558190003037 789.9060060000047 790.1739499997348 791.2207450000569 791.8518479997292 798.3810229999945 799.9818529998884 802.3258469998837 802.7556569995359 806.6461589997634 819.4263510005549 824.5630289996043

Current
Mean: 746.256 ms
Stdev: 51.731 ms (6.9%)
Runs: 648.7480469997972 658.4051109999418 668.7344570001587 669.2545169992372 670.1853429991752 678.3035479998216 680.0732840001583 680.1230469997972 684.1042490005493 691.4513349998742 693.6286220001057 695.5774339996278 700.0847180001438 702.5322270002216 704.3059899993241 705.6646320000291 706.0522059993818 707.8247480001301 708.9837649995461 709.8117269994691 712.0378430001438 715.4973959997296 719.4323730003089 723.2562669999897 724.3825279995799 725.2565919999033 730.223063999787 733.3788259997964 734.5237220004201 734.7827150002122 738.7609459999949 765.3991700001061 770.5829670000821 770.6022549998015 771.4946299996227 777.5174569999799 781.3327639997005 781.7312430003658 782.8286540005356 783.9666349999607 786.8522140001878 786.8747570002452 788.8898930000141 789.0793059999123 792.0702320002019 792.2487389994785 792.5925709996372 792.9509279998019 793.1322030005977 801.3103029998019 802.9019369995221 804.8711340008304 807.884398999624 808.9670410007238 809.2207849994302 824.5511879995465 829.653442999348 833.6455089999363 850.5411390000954
Chat opening (CPU) Baseline
Mean: 162.831 %
Stdev: 3.922 % (2.4%)
Runs: 154.13455949192755 154.48627079577858 154.95410388607434 155.54261613254138 156.8901164399769 157.26445005979133 158.28632551641115 158.4810982600563 158.65515561039757 159.2767050261926 159.3462177347942 159.88727885893672 160.13514710798242 160.24935116081852 160.4231916542108 160.49940000454257 160.5377342941776 160.83460769134564 160.84031936127747 160.9513944223108 161.07398793724187 161.6780774840208 161.89600072736454 162.01866545250013 162.03428979281153 162.22217578928993 162.2467115552624 162.2720965553928 162.320839293628 162.33325078062586 162.66069689985216 163.02594810379247 163.67220749614003 163.74894930924916 163.76730473901836 164.13612296834876 164.25901060392619 164.43651721596493 164.49047990199935 164.84142142947564 165.1725047826374 165.26475733791384 165.371291353826 165.41017540753336 165.96059596023437 166.12632088727597 166.13271797911798 166.15114847242734 166.2968930262352 166.7457805050527 166.83640479868316 167.06135458167338 167.28731569057132 167.700695400249 167.79167619536312 168.4260079874637 169.72268425756528 170.2451464475979 172.53736978394502

Current
Mean: 161.271 %
Stdev: 3.196 % (2.0%)
Runs: 154.2181693527451 155.47969636713546 155.87174874973562 156.50702513157086 156.62897781275686 156.96620172087057 157.27177285628972 157.77996815743472 158.00154455892604 158.20253408740876 158.38853018290527 158.4271081181749 158.43300689158033 159.2785861030165 159.70880924497976 159.71902308074246 159.9528181884557 160.05855134107333 160.09740579185456 160.14247765992047 160.16963639384568 160.24233077286942 160.4029834018317 160.48197000544155 160.54752167913534 160.63762175990897 160.65752073901965 160.733796831089 160.8234718457063 161.02206152736622 161.49943408986667 161.65548550150922 161.69125881424262 161.692729950177 161.78201068333843 161.96479180215462 161.97984336108613 162.0196625012482 162.23867471162146 162.3489649747932 162.53627825318182 162.87034525946916 162.89329628626362 163.32296476146723 163.3905716965381 163.837812437225 164.34845283941044 164.41285674047487 164.69486127346903 165.1612594312527 165.44402039269715 166.0413483657078 166.41490184336936 167.08149968804182 167.21749569931322 168.03246923927725 169.0115753104356
Chat opening (FPS) Baseline
Mean: 60.000 FPS
Stdev: 0.000 FPS (0.0%)
Runs: 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60

Current
Mean: 60.000 FPS
Stdev: 0.000 FPS (0.0%)
Runs: 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60
Chat opening (RAM) Baseline
Mean: 389.540 MB
Stdev: 8.192 MB (2.1%)
Runs: 373.63671875 376.330078125 379.205078125 379.3232421875 379.38984375 379.5458984375 379.6865234375 380.2001953125 380.400390625 381.40625 381.46484375 381.697265625 382.0595703125 382.22109375 382.509765625 382.8876953125 383.6015625 383.88515625 384.19921875 384.8505859375 385.1611328125 385.3125 385.6625 385.88671875 385.946875 386.05625 386.1109375 386.6265625 386.9951171875 387.19921875 387.7548828125 388.13125 388.64375 389.31484375 389.64453125 390.171875 390.778125 390.7861328125 391.599609375 392.16015625 393.12265625 394.189453125 395.4921875 396.275390625 397.021875 398.87890625 398.98515625 399.31953125 399.6703125 399.80703125 400.11015625 400.49296875 400.8890625 401.28515625 401.6859375 402.00859375 402.134375 402.3609375 404.8640625 405.34140625

Current
Mean: 389.724 MB
Stdev: 7.151 MB (1.8%)
Runs: 378.888671875 379.2041015625 380.83984375 381.2919921875 381.3115234375 381.650390625 382.2294921875 382.35546875 382.357421875 383.025390625 383.2578125 383.453125 383.568359375 383.6337890625 383.75703125 383.8642578125 383.98515625 384.26328125 384.333984375 384.3974609375 384.5078125 384.75390625 385.6982421875 386.51328125 386.971875 387.0478515625 387.34765625 387.564453125 387.58828125 388.1875 388.326171875 388.486328125 388.79140625 389.553125 389.7705078125 389.95859375 390.00546875 390.5234375 390.9033203125 391.3798828125 392.44609375 393.21484375 393.3796875 393.66796875 396.0029296875 396.2734375 399.02265625 399.0625 399.6046875 399.85703125 399.8734375 400.11953125 400.3328125 400.33828125 401.1609375 402.9046875 403.25546875 403.8203125 403.86015625
Chat opening (CPU/JS) Baseline
Mean: 0.000 %
Stdev: 0.000 % (NaN%)
Runs: 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0

Current
Mean: 0.000 %
Stdev: 0.000 % (NaN%)
Runs: 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0
Chat opening (CPU/UI) Baseline
Mean: 31.629 %
Stdev: 1.577 % (5.0%)
Runs: 28.4 29.1 29.1 29.2 29.2 29.5 29.6 29.6 29.7 30 30 30.1 30.4 30.4 30.4 30.4 30.6 30.7 30.8 31 31.1 31.1 31.2 31.3 31.3 31.5 31.6 31.7 31.8 31.8 31.8 31.8 31.9 31.9 31.9 32.2 32.2 32.2 32.3 32.3 32.4 32.4 32.4 32.5 32.6 32.8 32.9 33 33.2 33.5 33.6 33.9 33.9 33.9 34 34 34.1 36.3

Current
Mean: 31.655 %
Stdev: 1.691 % (5.3%)
Runs: 28.8 29.2 29.4 29.4 29.4 29.5 29.5 29.6 29.7 29.8 29.9 29.9 29.9 30.2 30.3 30.4 30.4 30.6 30.6 30.6 30.6 30.8 30.8 30.8 30.9 30.9 31 31 31.3 31.5 31.5 31.6 31.6 31.7 31.9 32.1 32.2 32.3 32.4 32.4 32.4 32.4 32.5 32.5 32.8 32.8 33 33.3 33.6 33.6 33.9 33.9 34 34.4 34.4 34.4 34.4 34.5 34.9 35.2

@github-actions GitHub Actions
Copy link
Contributor

@Expensify/mobile-deployers 📣 Please look into this performance regression as it's a deploy blocker.

@mountiny mountiny removed the DeployBlockerCash This issue or pull request should block deployment label May 21, 2025
@github-actions github-actions bot mentioned this pull request May 21, 2025
Closed
@github-actions GitHub Actions
Copy link
Contributor

🚀 Deployed to staging by https://github.com/mountiny in version: 9.1.48-0 🚀

platform result
🖥 desktop 🖥 failure ❌
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 failure ❌

@github-actions GitHub Actions
Copy link
Contributor

🚀 Deployed to staging by https://github.com/mountiny in version: 9.1.48-0 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 failure ❌

@github-actions GitHub Actions
Copy link
Contributor

🚀 Deployed to staging by https://github.com/mountiny in version: 9.1.49-5 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@github-actions GitHub Actions
Copy link
Contributor

🚀 Deployed to production by https://github.com/arosiclair in version: 9.1.50-0 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 failure ❌
🍎 iOS 🍎 success ✅

@melvin-bot melvin-bot bot mentioned this pull request May 23, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mountiny mountiny mountiny approved these changes

@DylanDylann DylanDylann Awaiting requested review from DylanDylann

Assignees

@sumo-slonik sumo-slonik

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sumo-slonik @mountiny @OSBotify